diff options
| author | Lennart Poettering <lennart@poettering.net> | 2005-10-27 14:30:46 +0000 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2005-10-27 14:30:46 +0000 |
| commit | 20011324500a728851e4888c890a756ecf71394b (patch) | |
| tree | 9dc37356855fa1b1c009aa978158fac9c85f2d16 /avahi-core | |
| parent | cf5ee4f9a5c3625a3d13b92603d1035f976228b0 (diff) | |
Add validity checking to TXT data parsing, this fixes a remotely exploitable vulnerability.
git-svn-id: file:///home/lennart/svn/public/avahi/trunk@888 941a03a8-eaeb-0310-b9a0-b1bbd8fe43fe
Diffstat (limited to 'avahi-core')
| -rw-r--r-- | avahi-core/dns.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/avahi-core/dns.c b/avahi-core/dns.c index 63ea8a0..d237d55 100644 --- a/avahi-core/dns.c +++ b/avahi-core/dns.c @@ -544,7 +544,8 @@ static int parse_rdata(AvahiDnsPacket *p, AvahiRecord *r, uint16_t rdlength) { case AVAHI_DNS_TYPE_TXT: if (rdlength > 0) { - r->data.txt.string_list = avahi_string_list_parse(avahi_dns_packet_get_rptr(p), rdlength); + if (avahi_string_list_parse(avahi_dns_packet_get_rptr(p), rdlength, &r->data.txt.string_list) < 0) + return -1; if (avahi_dns_packet_skip(p, rdlength) < 0) return -1; |