From d68a57d8bee6643b230b752b4588f66d89e51524 Mon Sep 17 00:00:00 2001 From: Marcel Holtmann Date: Fri, 3 Oct 2008 08:29:51 +0200 Subject: Fix uninitialized reply of multiple GetProperties methods --- audio/control.c | 4 ++++ audio/sink.c | 4 ++++ input/device.c | 4 ++++ network/connection.c | 4 ++++ 4 files changed, 16 insertions(+) diff --git a/audio/control.c b/audio/control.c index 124de432..d455e33d 100644 --- a/audio/control.c +++ b/audio/control.c @@ -958,6 +958,10 @@ static DBusMessage *control_get_properties(DBusConnection *conn, DBusMessageIter dict; gboolean value; + reply = dbus_message_new_method_return(msg); + if (!reply) + return NULL; + dbus_message_iter_init_append(reply, &iter); dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY, diff --git a/audio/sink.c b/audio/sink.c index f5256274..0d273e93 100644 --- a/audio/sink.c +++ b/audio/sink.c @@ -519,6 +519,10 @@ static DBusMessage *sink_get_properties(DBusConnection *conn, DBusMessageIter dict; gboolean value; + reply = dbus_message_new_method_return(msg); + if (!reply) + return NULL; + dbus_message_iter_init_append(reply, &iter); dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY, diff --git a/input/device.c b/input/device.c index dd5ac823..23c51ea6 100644 --- a/input/device.c +++ b/input/device.c @@ -995,6 +995,10 @@ static DBusMessage *device_get_properties(DBusConnection *conn, DBusMessageIter dict; dbus_bool_t connected; + reply = dbus_message_new_method_return(msg); + if (!reply) + return NULL; + dbus_message_iter_init_append(reply, &iter); dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY, diff --git a/network/connection.c b/network/connection.c index 27aa2546..a8dd5689 100644 --- a/network/connection.c +++ b/network/connection.c @@ -453,6 +453,10 @@ static DBusMessage *connection_get_properties(DBusConnection *conn, const char *property; GSList *l; + reply = dbus_message_new_method_return(msg); + if (!reply) + return NULL; + dbus_message_iter_init_append(reply, &iter); dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY, -- cgit