From 1c195ab280da561f38e54449e4eb3d6882c69b3b Mon Sep 17 00:00:00 2001 From: Johan Hedberg Date: Wed, 25 Feb 2009 17:48:40 +0200 Subject: Fix strncpy length parameters to avoid non-nul-terminated strings --- input/device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'input/device.c') diff --git a/input/device.c b/input/device.c index a41df177..0090bd4b 100644 --- a/input/device.c +++ b/input/device.c @@ -177,7 +177,7 @@ static int uinput_create(char *name) memset(&dev, 0, sizeof(dev)); if (name) - strncpy(dev.name, name, UINPUT_MAX_NAME_SIZE); + strncpy(dev.name, name, UINPUT_MAX_NAME_SIZE - 1); dev.id.bustype = BUS_BLUETOOTH; dev.id.vendor = 0x0000; @@ -635,7 +635,7 @@ static int hidp_add_connection(const struct input_device *idev, } if (idev->name) - strncpy(req->name, idev->name, 128); + strncpy(req->name, idev->name, sizeof(req->name) - 1); /* Encryption is mandatory for keyboards */ if (req->subclass & 0x40) { -- cgit