From b81980264b744de5dda6f8e5cca15c4b829c64d9 Mon Sep 17 00:00:00 2001 From: Claudio Takahasi Date: Thu, 4 Sep 2008 15:54:03 -0300 Subject: Input: Missing DBusConnection unref --- input/main.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'input') diff --git a/input/main.c b/input/main.c index d3d152e0..4851324c 100644 --- a/input/main.c +++ b/input/main.c @@ -28,7 +28,6 @@ #include #include -#include #include @@ -36,6 +35,8 @@ #include "logging.h" #include "manager.h" +DBusConnection *connection = NULL; + static GKeyFile *load_config_file(const char *file) { GKeyFile *keyfile; @@ -56,16 +57,15 @@ static GKeyFile *load_config_file(const char *file) static int input_init(void) { GKeyFile *config; - DBusConnection *conn; - conn = dbus_bus_get(DBUS_BUS_SYSTEM, NULL); - if (conn == NULL) + connection = dbus_bus_get(DBUS_BUS_SYSTEM, NULL); + if (connection == NULL) return -EIO; config = load_config_file(CONFIGDIR "/input.conf"); - if (input_manager_init(conn, config) < 0) { - dbus_connection_unref(conn); + if (input_manager_init(connection, config) < 0) { + dbus_connection_unref(connection); return -EIO; } @@ -78,6 +78,7 @@ static int input_init(void) static void input_exit(void) { input_manager_exit(); + dbus_connection_unref(connection); } BLUETOOTH_PLUGIN_DEFINE("input", input_init, input_exit) -- cgit From df73479a0cde71ecff54d75e0450891aa449f53a Mon Sep 17 00:00:00 2001 From: Claudio Takahasi Date: Thu, 4 Sep 2008 17:40:41 -0300 Subject: Input: Minor cleanup --- input/manager.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) (limited to 'input') diff --git a/input/manager.c b/input/manager.c index a2a22762..d3829323 100644 --- a/input/manager.c +++ b/input/manager.c @@ -25,21 +25,14 @@ #include #endif -#include -#include #include -#include -#include #include #include -#include #include #include #include -#include -#include #include #include "logging.h" @@ -49,10 +42,8 @@ #include "device.h" #include "server.h" -#include "error.h" #include "manager.h" #include "storage.h" -#include "glib-helper.h" static int idle_timeout = 0; @@ -319,12 +310,11 @@ int input_manager_init(DBusConnection *conn, GKeyFile *config) void input_manager_exit(void) { - - btd_unregister_adapter_driver(&input_server_driver); - btd_unregister_device_driver(&input_hid_driver); btd_unregister_device_driver(&input_headset_driver); + btd_unregister_adapter_driver(&input_server_driver); + dbus_connection_unref(connection); connection = NULL; -- cgit From 26dc8445ffa66aa3c933442848c3a92070b25fb7 Mon Sep 17 00:00:00 2001 From: Johan Hedberg Date: Sat, 6 Sep 2008 02:09:05 +0300 Subject: Fix audio and input interfaces match the API documentation --- input/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'input') diff --git a/input/device.c b/input/device.c index e5fe0c46..44bec0d6 100644 --- a/input/device.c +++ b/input/device.c @@ -52,7 +52,7 @@ #include "fakehid.h" #include "glib-helper.h" -#define INPUT_DEVICE_INTERFACE "org.bluez.input.Device" +#define INPUT_DEVICE_INTERFACE "org.bluez.Input" #define BUF_SIZE 16 -- cgit From c74f11481aabe51612c7200e1e3ab91f7f1c4abb Mon Sep 17 00:00:00 2001 From: Marcel Holtmann Date: Sat, 6 Sep 2008 01:10:56 +0200 Subject: Fix D-Bus connection init --- input/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'input') diff --git a/input/main.c b/input/main.c index 4851324c..8df96891 100644 --- a/input/main.c +++ b/input/main.c @@ -35,8 +35,6 @@ #include "logging.h" #include "manager.h" -DBusConnection *connection = NULL; - static GKeyFile *load_config_file(const char *file) { GKeyFile *keyfile; @@ -54,6 +52,8 @@ static GKeyFile *load_config_file(const char *file) return keyfile; } +static DBusConnection *connection; + static int input_init(void) { GKeyFile *config; @@ -78,6 +78,7 @@ static int input_init(void) static void input_exit(void) { input_manager_exit(); + dbus_connection_unref(connection); } -- cgit