summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHavoc Pennington <hp@redhat.com>2005-07-30 01:33:55 +0000
committerHavoc Pennington <hp@redhat.com>2005-07-30 01:33:55 +0000
commitba04a545aa4c2cf475a9fb52653a46a88d01c9d9 (patch)
treead18fc8c3243496631b48636e791d6c178e690a6
parentc8a5cff51576c889266181a341a66abe6858f967 (diff)
2005-07-29 Havoc Pennington <hp@redhat.com>
* test/glib/test-profile.c (write_junk): initialize the junk buffer so valgrind doesn't have a breakdown
-rw-r--r--ChangeLog5
-rw-r--r--doc/TODO7
-rw-r--r--test/glib/test-profile.c5
3 files changed, 15 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 6832d4e6..2a53e5aa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2005-07-29 Havoc Pennington <hp@redhat.com>
+ * test/glib/test-profile.c (write_junk): initialize the junk
+ buffer so valgrind doesn't have a breakdown
+
+2005-07-29 Havoc Pennington <hp@redhat.com>
+
* bus/signals.c (bus_signals_test): add match_rule_equal() tests
(match_rule_matches): remove unused arg
(test_matching): add tests for match_rule_matches()
diff --git a/doc/TODO b/doc/TODO
index 0d68910a..55ba9222 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -28,6 +28,13 @@ Important for 1.0 GLib Bindings
- Add support for getting sender
+ - format_version in the object info doesn't look like it's handled correctly. The creator
+ of the object info should specify some fixed number per struct version; the library
+ should handle only specific numbers it knows about. There's no assumption that all
+ numbers >= the given one are compatible. The idea is that new versions of the lib
+ can offer totally different object info structs, but old versions
+ keep working.
+
Important for 1.0 Python bindings
===
diff --git a/test/glib/test-profile.c b/test/glib/test-profile.c
index ea42bd08..21d58852 100644
--- a/test/glib/test-profile.c
+++ b/test/glib/test-profile.c
@@ -48,7 +48,7 @@
*/
#define N_CLIENT_THREADS 1
/* It seems like at least 750000 or so iterations reduces the variability to sane levels */
-#define N_ITERATIONS 750000
+#define N_ITERATIONS 25000
#define N_PROGRESS_UPDATES 20
/* Don't make PAYLOAD_SIZE too huge because it gets used as a static buffer size */
#define PAYLOAD_SIZE 0
@@ -654,7 +654,7 @@ write_junk (int fd,
int val;
char *buf;
char *allocated;
- char not_allocated[512+PAYLOAD_SIZE];
+ char not_allocated[512+PAYLOAD_SIZE] = { '\0', };
g_assert (count < (int) sizeof(not_allocated));
@@ -978,6 +978,7 @@ plain_sockets_thread_func (void *data)
cd.iterations = 1;
cd.loop = g_main_loop_new (context, FALSE);
+ cd.vtable = data;
channel = g_io_channel_unix_new (fd);