2005-01-15 Havoc Pennington <hp@redhat.com>

	* Land the new message args API and type system.

	This patch is huge, but the public API change is not
	really large. The set of D-BUS types has changed somewhat,
	and the arg "getters" are more geared toward language bindings;
	they don't make a copy, etc.

	There are also some known issues. See these emails for details
	on this huge patch:
	http://lists.freedesktop.org/archives/dbus/2004-December/001836.html
        http://lists.freedesktop.org/archives/dbus/2005-January/001922.html

	* dbus/dbus-marshal-*: all the new stuff

	* dbus/dbus-message.c: basically rewritten

	* dbus/dbus-memory.c (check_guards): with "guards" enabled, init
	freed blocks to be all non-nul bytes so using freed memory is less
	likely to work right

	* dbus/dbus-internals.c (_dbus_test_oom_handling): add
	DBUS_FAIL_MALLOC=N environment variable, so you can do
	DBUS_FAIL_MALLOC=0 to skip the out-of-memory checking, or
	DBUS_FAIL_MALLOC=10 to make it really, really, really slow and
	thorough.

	* qt/message.cpp: port to the new message args API
	(operator<<): use str.utf8() rather than str.unicode()
	(pretty sure this is right from the Qt docs?)

	* glib/dbus-gvalue.c: port to the new message args API

	* bus/dispatch.c, bus/driver.c: port to the new message args API

	* dbus/dbus-string.c (_dbus_string_init_const_len): initialize the
	"locked" flag to TRUE and align_offset to 0; I guess we never
	looked at these anyhow, but seems cleaner.

	* dbus/dbus-string.h (_DBUS_STRING_ALLOCATION_PADDING):
	move allocation padding macro to this header; use it to implement
	(_DBUS_STRING_STATIC): ability to declare a static string.

	* dbus/dbus-message.c (_dbus_message_has_type_interface_member):
	change to return TRUE if the interface is not set.

	* dbus/dbus-string.[hc]: move the D-BUS specific validation stuff
	to dbus-marshal-validate.[hc]

	* dbus/dbus-marshal-basic.c (_dbus_type_to_string): move here from
	dbus-internals.c

	* dbus/Makefile.am: cut over from dbus-marshal.[hc]
	to dbus-marshal-*.[hc]

	* dbus/dbus-object-tree.c (_dbus_decompose_path): move this
	function here from dbus-marshal.c

1 files changed, 15 insertions, 10 deletions

diff --git a/dbus/dbus-bus.c b/dbus/dbus-bus.c
index be296fc7..bc1750b6 100644
--- a/dbus/dbus-bus.c
+++ b/dbus/dbus-bus.c
@@ -479,8 +479,13 @@ dbus_bus_register (DBusConnection *connection,
                                    DBUS_TYPE_INVALID))
     goto out;
   
-  bd->base_service = name;
-
+  bd->base_service = _dbus_strdup (name);
+  if (bd->base_service == NULL)
+    {
+      _DBUS_SET_OOM (error);
+      goto out;
+    }
+  
   retval = TRUE;
   
  out:
@@ -578,7 +583,7 @@ dbus_bus_get_unix_user (DBusConnection *connection,
     }
  
   if (!dbus_message_append_args (message,
-				 DBUS_TYPE_STRING, service,
+				 DBUS_TYPE_STRING, &service,
 				 DBUS_TYPE_INVALID))
     {
       dbus_message_unref (message);
@@ -659,8 +664,8 @@ dbus_bus_acquire_service (DBusConnection *connection,
     }
  
   if (!dbus_message_append_args (message,
-				 DBUS_TYPE_STRING, service_name,
-				 DBUS_TYPE_UINT32, flags,
+				 DBUS_TYPE_STRING, &service_name,
+				 DBUS_TYPE_UINT32, &flags,
 				 DBUS_TYPE_INVALID))
     {
       dbus_message_unref (message);
@@ -731,7 +736,7 @@ dbus_bus_service_exists (DBusConnection *connection,
     }
   
   if (!dbus_message_append_args (message,
-				 DBUS_TYPE_STRING, service_name,
+				 DBUS_TYPE_STRING, &service_name,
 				 DBUS_TYPE_INVALID))
     {
       dbus_message_unref (message);
@@ -791,8 +796,8 @@ dbus_bus_activate_service (DBusConnection *connection,
                                       DBUS_INTERFACE_ORG_FREEDESKTOP_DBUS,
                                       "ActivateService");
 
-  if (!dbus_message_append_args (msg, DBUS_TYPE_STRING, service_name,
-			  	 DBUS_TYPE_UINT32, flags, DBUS_TYPE_INVALID))
+  if (!dbus_message_append_args (msg, DBUS_TYPE_STRING, &service_name,
+			  	 DBUS_TYPE_UINT32, &flags, DBUS_TYPE_INVALID))
     {
       dbus_message_unref (msg);
       _DBUS_SET_OOM (error);
@@ -895,7 +900,7 @@ dbus_bus_add_match (DBusConnection *connection,
       return;
     }
 
-  if (!dbus_message_append_args (msg, DBUS_TYPE_STRING, rule,
+  if (!dbus_message_append_args (msg, DBUS_TYPE_STRING, &rule,
                                  DBUS_TYPE_INVALID))
     {
       dbus_message_unref (msg);
@@ -933,7 +938,7 @@ dbus_bus_remove_match (DBusConnection *connection,
                                       DBUS_INTERFACE_ORG_FREEDESKTOP_DBUS,
                                       "RemoveMatch");
 
-  if (!dbus_message_append_args (msg, DBUS_TYPE_STRING, rule,
+  if (!dbus_message_append_args (msg, DBUS_TYPE_STRING, &rule,
                                  DBUS_TYPE_INVALID))
     {
       dbus_message_unref (msg);