summaryrefslogtreecommitdiffstats
path: root/dbus/dbus-string.c
diff options
context:
space:
mode:
authorHavoc Pennington <hp@redhat.com>2003-02-05 05:56:53 +0000
committerHavoc Pennington <hp@redhat.com>2003-02-05 05:56:53 +0000
commita07bc460ae1a3d3582a6dac7e48ed1ea117990ef (patch)
tree951980157d356ce81ef1aadc9b860dce85acd4a9 /dbus/dbus-string.c
parent69824400caa9ff2a1f24e06728f27e0f50f0033d (diff)
2003-02-02 Havoc Pennington <hp@pobox.com>
* dbus/dbus-keyring.c, dbus/dbus-keyring.h: template files for code to manage cookies in your home directory * dbus/dbus-sysdeps.c (_dbus_generate_random_bytes): new function * dbus/dbus-auth.c (get_state): impose a maximum number of tries to authenticate, then disconnect the client.
Diffstat (limited to 'dbus/dbus-string.c')
-rw-r--r--dbus/dbus-string.c10
1 files changed, 9 insertions, 1 deletions
diff --git a/dbus/dbus-string.c b/dbus/dbus-string.c
index 17a7d918..a5bf3ebc 100644
--- a/dbus/dbus-string.c
+++ b/dbus/dbus-string.c
@@ -374,7 +374,11 @@ _dbus_string_get_data (DBusString *str,
}
/**
- * Gets the raw character buffer from a const string.
+ * Gets the raw character buffer from a const string.
+ *
+ * @todo should return the const char* instead of using an out param;
+ * the temporary variable encourages a bug where you use const data
+ * after modifying the string and possibly causing a realloc.
*
* @param str the string
* @param data_return location to store returned data
@@ -420,6 +424,10 @@ _dbus_string_get_data_len (DBusString *str,
/**
* const version of _dbus_string_get_data_len().
*
+ * @todo should return the const char* instead of using an out param;
+ * the temporary variable encourages a bug where you use const data
+ * after modifying the string and possibly causing a realloc.
+ *
* @param str the string
* @param data_return location to return the buffer
* @param start byte offset to return