summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | dbus_message_append_args_valist - abandon containerScott James Remnant2009-07-091-2/+6
| | | | | | | | | | | | | | | | | | | | | In case of OOM when constructing an array, we should abandon the container to free the resources. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | bfo22316 - add dbus_message_iter_abandon_container()Scott James Remnant2009-07-093-2/+59
| | | | | | | | | | | | | | | | | | | | | | | | It's not currently possible to abandon creation of a container without either hitting asserts or leaking memory. This new function allows that. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Add test case for assert when unwinding a container.Scott James Remnant2009-07-091-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | * dbus/dbus-message-util.c: when constructing an array of structures, it's not possible to unwind in case of an error part-way through. This test will therefore assert. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Bump configure.in for GITScott James Remnant2009-07-091-1/+1
| | | | | | | | | | | | Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Add tests for pending call timeoutsScott James Remnant2009-05-285-1/+173
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * test/test-service.c (handle_delay_echo, path_message_func): Add a variant of the Echo method which sleeps for a short time. * test/name-test/test-pending-call-timeout.c: Run tests with default, specified and infinite timeout to make sure we get the reply. * test/name-test/run-test.sh: Run the new test * test/name-test/Makefile.am: Build the new test Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Unrestrict session bus timeout.Scott James Remnant2009-05-281-1/+0
| | | | | | | | | | | | | | | | | | | | | * bus/session.conf.in: Remove the reply_timeout stanza, previously intended to increase the reply timeout, this now reduces it. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Change default reply timeout.Scott James Remnant2009-05-281-1/+1
| | | | | | | | | | | | | | | | | | | | | * bus/config-parser.c (bus_config_parser_new): change the default reply timeout to "never" Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Expire list timeout may be negative for no expiry.Scott James Remnant2009-05-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | * bus/expirelist.c (do_expiration_with_current_time): Don't check for expiry if expire_after is negative, will just disable the expiry timer after the call. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Explicitly check for zero time fields.Scott James Remnant2009-05-281-1/+2
| | | | | | | | | | | | | | | | | | | | | * bus/expirelist.c (do_expiration_with_current_time): If the item added time fields are both zero, always expire. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Remove 6 hour timeout restriction.Scott James Remnant2009-05-281-7/+0
| | | | | | | | | | | | | | | | | | | | | * dbus/dbus-pending-call.c (_dbus_pending_call_new_unlocked): Now that the timeout math won't overflow, don't clamp to six hours. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Fix issue where timeouts can overflow.Scott James Remnant2009-05-281-14/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | * dbus/dbus-connection.c (_dbus_connection_block_pending_call): Rework the timeout math so instead of calculating an end time, which may overflow, we instead calculate the elapsed time which is always smaller than the boundaries. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Update documentation now that INT_MAX means no timeout.Scott James Remnant2009-05-281-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | * dbus/dbus-connection.c (dbus_connection_send_with_reply): Fix documentation now that INT_MAX will not be clamped. (dbus_connection_send_with_reply_and_block): Update documentation too. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Don't allocate DBusTimeout for pending call when passed INT_MAXScott James Remnant2009-05-281-19/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | * dbus/dbus-pending-call.c (_dbus_pending_call_new_unlocked): When passed INT_MAX, do not clamp the value and do not allocate a timeout for the call (_dbus_pending_call_get_timeout_unlocked): Document that this may return NULL. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Allow a pending call to block foreverScott James Remnant2009-05-281-14/+48
| | | | | | | | | | | | | | | | | | | | | | | | * dbus/dbus-connection.c (_dbus_connection_block_pending_call): Allow the pending call to have no timeout, in which case we simply block until we complete, have data or get disconnected. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | | Make sure a pending call timeout isn't assumed.Scott James Remnant2009-05-281-14/+29
| |/ |/| | | | | | | | | | | | | | | | | * dbus/dbus-connection.c (_dbus_connection_attach_pending_call_unlocked): Don't assume that the pending call has a timeout. (connection_timeout_and_complete_all_pending_call_unlocked): check that the timeout was actually added before removing it; this safeguards us if the pending call doesn't have a timeout. Signed-off-by: Scott James Remnant <scott@ubuntu.com>
* | Merge branch 'dbus-1.2'Thiago Macieira2009-05-131-3/+14
|\|
| * configure.in: fail abstract socket test gracefully when cross-compilingMarc Mutz2009-05-131-2/+10
| | | | | | | | | | | | | | | | * configure.in: only run AC_CACHE_CHECK if enable_abstract_sockets=auto * configure.in: warn that, when cross-compiling, we're unable to detect abstract sockets availability automatically Signed-off-by: Thiago Macieira <thiago@kde.org>
| * configure.in: not all gccs support -Wno-pointer-signMarc Mutz2009-05-131-1/+4
| | | | | | | | Signed-off-by: Thiago Macieira <thiago@kde.org>
* | Merge branch 'dbus-1.2'Thiago Macieira2009-05-131-1/+1
|\| | | | | | | | | Conflicts: dbus/dbus-sysdeps-util-unix.c
| * Release 1.2.14Colin Walters2009-05-061-1/+1
| |
| * libselinux behavior in permissive mode wrt invalid domainsEamon Walsh2009-05-061-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stephen Smalley wrote: > On Tue, 2009-04-21 at 16:32 -0400, Joshua Brindle wrote: > >> Stephen Smalley wrote: >> >>> On Thu, 2009-04-16 at 20:47 -0400, Eamon Walsh wrote: >>> >>>> Stephen Smalley wrote: >>>> >> <snip> >> >> >>> No, I don't want to change the behavior upon context_to_sid calls in >>> general, as we otherwise lose all context validity checking in >>> permissive mode. >>> >>> I think I'd rather change compute_sid behavior to preclude the situation >>> from arising in the first place, possibly altering the behavior in >>> permissive mode upon an invalid context to fall back on the ssid >>> (process) or the tsid (object). But I'm not entirely convinced any >>> change is required here. >>> >>> >> I just want to follow up to make sure we are all on the same page here. Was the >> suggestion to change avc_has_perm in libselinux or context_to_sid in the kernel >> or leave the code as is and fix the callers of avc_has_perm to correctly handle >> error codes? >> >> I prefer the last approach because of Eamon's explanation, EINVAL is already >> passed in errno to specify the context was invalid (and if object managers >> aren't handling that correctly now there is a good chance they aren't handling >> the ENOMEM case either). >> > > I'd be inclined to change compute_sid (not context_to_sid) in the kernel > to prevent invalid contexts from being formed even in permissive mode > (scenario is a type transition where role is not authorized for the new > type). That was originally to allow the system to boot in permissive > mode. But an alternative would be to just stay in the caller's context > (ssid) in that situation. > > Changing the callers of avc_has_perm() to handle EINVAL and/or ENOMEM > may make sense, but that logic should not depend on enforcing vs. > permissive mode. > > FWIW, the following patch to D-Bus should help: bfo21072 - Log SELinux denials better by checking errno for the cause Note that this does not fully address the bug report since EINVAL can still be returned in permissive mode. However the log messages will now reflect the proper cause of the denial. Signed-off-by: Eamon Walsh <ewalsh@tycho.nsa.gov> Signed-off-by: Colin Walters <walters@verbum.org>
| * bfo20738 - Return a useful error message from dbus_signature_validate()Federico Mena Quintero2009-05-061-3/+9
| | | | | | | | Signed-off-by: Federico Mena Quintero <federico@novell.com>
| * bfo20738 - Translate DBusValidity into error messageFederico Mena Quintero2009-05-062-0/+73
| | | | | | | | Signed-off-by: Federico Mena Quintero <federico@novell.com>
| * Bug 19567 - Make marshaling code usable without DBusConnectionWilliam Lachance2009-05-067-21/+90
| | | | | | | | | | | | | | | | | | | | Some projects want to reuse the DBus message format, without actually going through a DBusConnection. This set of changes makes a few functions from DBusMessage public, and adds a new function to determine the number of bytes needed to demarshal a message. Signed-off-by: Colin Walters <walters@verbum.org>
| * Followup Bug 19502 - Don't attempt to init va_list, not portableColin Walters2009-05-061-1/+1
| |
| * Bug 19502 - Sparse warning cleanupsKjartan Maraas2009-05-0611-13/+14
| | | | | | | | | | | | | | This patch makes various things that should be static static, corrects some "return FALSE" where it should be NULL, etc. Signed-off-by: Colin Walters <walters@verbum.org>
| * dbus-launch: use InputOnly X windowEamon Walsh2009-05-061-3/+3
| | | | | | | | | | | | | | | | | | | | Working on SELinux policy for X, and came across this issue in dbus-launch: Windows created for use as property/selection placeholders should be of class InputOnly, since no drawing is ever done to them. Signed-off-by: Eamon Walsh <ewalsh@tycho.nsa.gov> Signed-off-by: Thiago Macieira <thiago@kde.org>
| * Bug 20494 - Fix signed confusion for dbus_message_get_reply_serial returnJohan Gyllenspetz2009-05-061-2/+2
| | | | | | | | | | | | | | We were incorrectly converting the serial to a signed integer and comparing it to -1. Signed-off-by: Colin Walters <walters@verbum.org>
| * Bug 20137 - Fix alignment usage when demarshaling basicsColin Walters2009-05-061-12/+28
| | | | | | | | | | | | | | | | | | | | | | We can't safely type-pun from e.g. char * to DBusBasicValue *, because the latter has higher alignment requirements. Instead, create an explicit pointer for each case. Also, we mark each one volatile to sidestep strict aliasing issues, for the future when we turn on strict aliasing support. Original patch and review from Jay Estabrook <jay.estabrook@hp.com>.
| * Always append closing quote in log commandColin Walters2009-05-061-6/+5
| | | | | | | | Patch suggested by Tomas Hoger <thoger@redhat.com>
| * Bug 17803 - Fix both test case and validation logicColin Walters2009-05-062-7/+8
| | | | | | | | | | | | | | | | | | | | | | The previous commit had errors in both the test case and the validation logic. The test case was missing a trailing comma before the previous one, so we weren't testing the signature we thought we were. The validation logic was wrong because if the type was not valid, we'd drop through the entire if clause, and thus skip returning an error code, and accept the signature.
* | Merge branch 'dbus-1.2'Thiago Macieira2009-04-284-25/+23
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: bus/bus.c bus/config-parser-common.c bus/config-parser-common.h bus/config-parser.c bus/connection.c bus/dbus-daemon.1.in dbus/dbus-marshal-validate-util.c dbus/dbus-marshal-validate.c dbus/dbus-sysdeps-util-unix.c test/name-test/tmp-session-like-system.conf
| * configure.in: fix help string alignmentMarc Mutz2009-04-281-1/+1
| | | | | | | | | | | | | | * AC_ARG_ENABLE(libaudit: use AS_HELP_STRING for aligned help messages Signed-off-by: Thiago Macieira <thiago@kde.org> (cherry picked from commit 660073925b03cad2f6e95ba9f25a81c2d9727185)
| * Fix typo in docs.Xan Lopez2009-02-021-1/+1
| |
| * Bump for unstable cycleColin Walters2009-01-061-1/+1
| |
| * Release 1.2.12.dbus-1.2.12Colin Walters2009-01-061-1/+1
| |
| * Add Scott to HACKINGColin Walters2009-01-061-2/+1
| |
| * Bug 17060: Explicitly hard fail if expat is not availableColin Walters2009-01-061-11/+8
| | | | | | | | * configure.in: Tweak libxml/expat detection and handling.
| * Bug 17969: Don't test for abstract sockets if explicitly disabledLionel Landwerlin2009-01-061-0/+2
| | | | | | | | Signed-off-by: Colin Walters <walters@verbum.org>
| * Bug 18064 - more efficient validation for fixed-size type arraysJon Gosting2009-01-061-11/+60
| | | | | | | | | | | | | | * dbus/dbus-marshal-validate.c: If an array is fixed size, skip validation Signed-off-by: Colin Walters <walters@verbum.org>
| * Initialize AVC earlier so we can look up service security contextsJames Carter2009-01-061-5/+5
| | | | | | | | | | | | | | * bus/bus.c: Initialize AVC earlier: http://lists.freedesktop.org/archives/dbus/2008-October/010493.html Signed-off-by: Colin Walters <walters@verbum.org>
| * Print serial in dbus-monitorMichael Meeks2009-01-061-1/+2
| | | | | | | | | | | | * tools/dbus-print-message.c: Print serial too. Signed-off-by: Colin Walters <walters@verbum.org>
| * [win32] Protect usage of SIGHUP with #ifdefTor Lillqvist2009-01-062-9/+16
| | | | | | | | Signed-off-by: Colin Walters <walters@verbum.org>
| * Bug 15412: Add --address option to dbus-sendLawrence R. Steeger2009-01-061-6/+45
| | | | | | | | Signed-off-by: Colin Walters <walters@verbum.org>
| * Bug 18446: Keep umask for session busMatt McCutchen2009-01-0611-10/+72
| | | | | | | | Signed-off-by: Colin Walters <walters@verbum.org>
| * Fix cross-compiling with autotools.Diego E. 'Flameeyes' Pettenò2009-01-061-4/+4
| | | | | | | | | | | | | | | | | | | | | | The AC_CANONICAL_TARGET macro and the $target_os variables are used for the target of compilers and other code-generation tools, and should not be used during cross-compile of generic software. Replace them with AC_CANONICAL_HOST and $host_os instead, as they should have been from the start. For a breakdown of what host, build and target machines are, please see http://blog.flameeyes.eu/s/canonical-target .
| * Avoid possible use of uninitialized variablePeter Breitenlohner2009-01-061-1/+1
| | | | | | | | Signed-off-by: Colin Walters <walters@verbum.org>
| * Enable -Werror by default with --enable-maintainer-mode, and change warningsColin Walters2009-01-061-6/+42
| | | | | | | | | | | | | | Important compiler warnings were being lost in the noise from warnings we know about but aren't problems, and moreover made using -Werror difficult. Now we expect *all* developers and testers to be using -Werror.
| * Various compiler warning fixesColin Walters2009-01-066-6/+8
| |
| * Bump for unstable cycleColin Walters2008-12-191-1/+1
| |
generated by cgit (git 2.34.1) at 2024-06-19 10:37:36 +0000