From 5cf7ec5c399537b89fdbf6637413c4d2c002f4a4 Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Mon, 6 Jan 2003 16:19:26 +0000 Subject: add a comment about needed fix for dbus_static_mutex_lock --- dbus/dbus-threads.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/dbus/dbus-threads.c b/dbus/dbus-threads.c index 434148b8..b132e8a4 100644 --- a/dbus/dbus-threads.c +++ b/dbus/dbus-threads.c @@ -172,12 +172,18 @@ dbus_threads_init (const DBusThreadFunctions *functions) /** * Lock a static mutex * + * @todo currently broken on some platforms due to + * non-workingness of "double checked locking" + * see http://bugzilla.gnome.org/show_bug.cgi?id=69668 + * and http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html + * for example. + * * @param mutex the mutex to lock * @returns #TRUE on success */ dbus_bool_t dbus_static_mutex_lock (DBusStaticMutex *mutex) -{ +{ if (_DBUS_STATIC_MUTEX_IMPL (mutex)) return dbus_mutex_lock (_DBUS_STATIC_MUTEX_IMPL (mutex)); -- cgit