From abfdfb2dfb2f2f0317856083dcf6ca71b271c9b9 Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Sat, 28 Oct 2006 01:50:08 +0000 Subject: 2006-10-27 Havoc Pennington * dbus/dbus-connection.c (dbus_connection_open_private): document how to choose shared vs. private connections --- ChangeLog | 5 +++++ dbus/dbus-connection.c | 12 +++++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index f0d4d89f..7e5458b1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-10-27 Havoc Pennington + + * dbus/dbus-connection.c (dbus_connection_open_private): document + how to choose shared vs. private connections + 2006-10-27 Havoc Pennington * dbus/dbus-test.c: enclose more of the file in the diff --git a/dbus/dbus-connection.c b/dbus/dbus-connection.c index db625588..552ecfd8 100644 --- a/dbus/dbus-connection.c +++ b/dbus/dbus-connection.c @@ -2381,6 +2381,11 @@ _dbus_connection_block_pending_call (DBusPendingCall *pending) * Because this connection is shared, no user of the connection * may call dbus_connection_close(). However, when you are done with the * connection you should call dbus_connection_unref(). + * + * @note Prefer dbus_connection_open() to dbus_connection_open_private() + * unless you have good reason; connections are expensive enough + * that it's wasteful to create lots of connections to the same + * server. * * @param address the address. * @param error address where an error can be returned. @@ -2419,7 +2424,12 @@ dbus_connection_open (const char *address, * (The dbus_connection_close() can be skipped if the * connection is already known to be disconnected, for example * if you are inside a handler for the Disconnected signal.) - * + * + * @note Prefer dbus_connection_open() to dbus_connection_open_private() + * unless you have good reason; connections are expensive enough + * that it's wasteful to create lots of connections to the same + * server. + * * @param address the address. * @param error address where an error can be returned. * @returns new connection, or #NULL on failure. -- cgit