From ce173b29fc1e9432cb5956952afdbe775da12415 Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Sun, 16 Mar 2003 08:08:21 +0000 Subject: 2003-03-16 Havoc Pennington Oops - test code was only testing failure of around 30 of the mallocs in the test path, but it turns out there are 500+ mallocs. I believe this was due to misguided linking setup such that there was one copy of dbus_malloc etc. in the daemon and one in the shared lib, and only daemon mallocs were tested. In any case, the test case now tests all 500+ mallocs, and doesn't pass yet, though there are lots of fixes in this patch. * dbus/dbus-connection.c (dbus_connection_dispatch_message): fix this so that it doesn't need to allocate memory, since it has no way of indicating failure due to OOM (and would be annoying if it did). * dbus/dbus-list.c (_dbus_list_pop_first_link): new function * bus/Makefile.am: rearrange to create two self-contained libraries, to avoid having libraries with overlapping symbols. that was resulting in weirdness, e.g. I'm pretty sure there were two copies of global static variables. * dbus/dbus-internals.c: move the malloc debug stuff to dbus-memory.c * dbus/dbus-list.c (free_link): free list mempool if it becomes empty. * dbus/dbus-memory.c (_dbus_disable_mem_pools): new function * dbus/dbus-address.c (dbus_parse_address): free list nodes on failure. * bus/dispatch.c (bus_dispatch_add_connection): free message_handler_slot when no longer using it, so memory leak checkers are happy for the test suite. * dbus/dbus-server-debug-pipe.c (debug_finalize): free server name * bus/bus.c (new_connection_callback): disconnect in here if bus_connections_setup_connection fails. * bus/connection.c (bus_connections_unref): fix to free the connections (bus_connections_setup_connection): if this fails, don't disconnect the connection, just be sure there are no side effects. * dbus/dbus-string.c (undo_alignment): unbreak this * dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were leaking (_dbus_auth_new): fix the order in which we free strings on OOM failure * bus/connection.c (bus_connection_disconnected): fix to not send ServiceDeleted multiple times in case of memory allocation failure * dbus/dbus-bus.c (dbus_bus_get_base_service): new function to get the base service name (dbus_bus_register_client): don't return base service name, instead store it on the DBusConnection and have an accessor function for it. (dbus_bus_register_client): rename dbus_bus_register() * bus/dispatch.c (check_hello_message): verify that other connections on the bus also got the correct results, not just the one sending hello --- dbus/Makefile.am | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) (limited to 'dbus/Makefile.am') diff --git a/dbus/Makefile.am b/dbus/Makefile.am index c66c5367..20be7919 100644 --- a/dbus/Makefile.am +++ b/dbus/Makefile.am @@ -21,7 +21,7 @@ dbusinclude_HEADERS= \ dbus-threads.h \ dbus-types.h -libdbus_1_la_SOURCES= \ +DBUS_SOURCES= \ dbus-address.c \ dbus-auth.c \ dbus-auth.h \ @@ -67,16 +67,7 @@ libdbus_1_la_SOURCES= \ ## dbus-md5.c \ ## dbus-md5.h \ - -## this library is linked into both libdbus and the bus -## itself, but does not export any symbols from libdbus. -## i.e. the point is to contain symbols that we don't -## want the shared lib to export, but we do want the -## message bus to be able to use. - -noinst_LTLIBRARIES=libdbus-convenience.la - -libdbus_convenience_la_SOURCES= \ +UTIL_SOURCES= \ dbus-dataslot.c \ dbus-dataslot.h \ dbus-hash.c \ @@ -98,7 +89,19 @@ libdbus_convenience_la_SOURCES= \ dbus-sysdeps.c \ dbus-sysdeps.h -libdbus_1_la_LIBADD= $(DBUS_CLIENT_LIBS) libdbus-convenience.la +libdbus_1_la_SOURCES= \ + $(DBUS_SOURCES) \ + $(UTIL_SOURCES) + +libdbus_convenience_la_SOURCES= \ + $(DBUS_SOURCES) \ + $(UTIL_SOURCES) + +## this library is the same as libdbus, but exports all the symbols +## and is only used for static linking within the dbus package. +noinst_LTLIBRARIES=libdbus-convenience.la + +libdbus_1_la_LIBADD= $(DBUS_CLIENT_LIBS) ## don't export symbols that start with "_" (we use this ## convention for internal symbols) libdbus_1_la_LDFLAGS= -export-symbols-regex "^[^_].*" @@ -120,7 +123,7 @@ noinst_PROGRAMS=$(TESTS) dbus_test_SOURCES= \ dbus-test-main.c -dbus_test_LDADD= $(DBUS_CLIENT_LIBS) libdbus-convenience.la libdbus-1.la +dbus_test_LDADD= $(DBUS_CLIENT_LIBS) libdbus-1.la ## mop up the gcov files clean-local: -- cgit