From 17fbe2b702cdc880abd6cbe117e620b6432f42e0 Mon Sep 17 00:00:00 2001
From: Havoc Pennington <hp@redhat.com>
Date: Tue, 24 Dec 2002 06:37:33 +0000
Subject: 2002-12-24  Havoc Pennington  <hp@pobox.com>

	* glib/dbus-gthread.c: fix include

	* glib/dbus-glib.h: rename DBusMessageHandler for now.
	I think glib API needs to change, though, as you don't
	want to use DBusMessageFunction, you want to use the
	DBusMessageHandler object. Probably
	dbus_connection_open_with_g_main_loop()
	and dbus_connection_setup_g_main_loop() or something like that
	(but think of better names...) that just create a connection
	that has watch/timeout functions etc. already set up.

	* dbus/dbus-connection.c
	(dbus_connection_send_message_with_reply): new function just to
	show how the message handler helps us deal with replies.

	* dbus/dbus-list.c (_dbus_list_remove_last): new function

	* dbus/dbus-string.c (_dbus_string_test): free a string that
	wasn't

	* dbus/dbus-hash.c: use memory pools for the hash entries
	(rebuild_table): be more paranoid about overflow, and
	shrink table when we can
	(_dbus_hash_test): reduce number of sprintfs and write
	valid C89. Add tests for case where we grow and then
	shrink the hash table.

	* dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools

	* dbus/dbus-connection.c (dbus_connection_register_handler)
	(dbus_connection_unregister_handler): new functions

	* dbus/dbus-message.c (dbus_message_get_name): new

	* dbus/dbus-list.c: fix docs typo

	* dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
	an object representing a handler for messages.
---
 dbus/dbus-list.c | 35 +++++++++++++++++++++++++++++++++--
 1 file changed, 33 insertions(+), 2 deletions(-)

(limited to 'dbus/dbus-list.c')

diff --git a/dbus/dbus-list.c b/dbus/dbus-list.c
index 31e5ae3f..c36246cb 100644
--- a/dbus/dbus-list.c
+++ b/dbus/dbus-list.c
@@ -133,7 +133,7 @@ link_after (DBusList **list,
  * while (link != NULL)
  *   {
  *     printf ("value is %p\n", link->data);
- *     link = _dbus_list_get_next_link (&list);
+ *     link = _dbus_list_get_next_link (&link);
  *   }
  * @endcode
  *
@@ -155,7 +155,7 @@ link_after (DBusList **list,
  * while (link != NULL)
  *   {
  *     printf ("value is %p\n", link->data);
- *     link = _dbus_list_get_prev_link (&list);
+ *     link = _dbus_list_get_prev_link (&link);
  *   }
  * @endcode
  *
@@ -300,6 +300,37 @@ _dbus_list_remove (DBusList **list,
   return FALSE;
 }
 
+/**
+ * Removes a value from the list. Only removes the
+ * last value equal to the given data pointer,
+ * even if multiple values exist which match.
+ * This is a linear-time operation.
+ *
+ * @param list address of the list head.
+ * @param data the value to remove.
+ * @returns #TRUE if a value was found to remove.
+ */
+dbus_bool_t
+_dbus_list_remove_last (DBusList **list,
+                        void      *data)
+{
+  DBusList *link;
+
+  link = _dbus_list_get_last_link (list);
+  while (link != NULL)
+    {
+      if (link->data == data)
+        {
+          _dbus_list_remove_link (list, link);
+          return TRUE;
+        }
+      
+      link = _dbus_list_get_prev_link (list, link);
+    }
+
+  return FALSE;
+}
+
 /**
  * Removes a link from the list. This is a constant-time operation.
  *
-- 
cgit