From e84c3a03b3be9cfc351ca8e0b9b935cca455e672 Mon Sep 17 00:00:00 2001
From: Alexander Larsson <alexl@redhat.com>
Date: Thu, 10 Apr 2003 11:04:24 +0000
Subject: 2003-04-10  Alexander Larsson  <alexl@redhat.com>

	* dbus/dbus-marshal.[ch]:
	Add array_type_pos argument to _dbus_marshal_validate_arg.
	Let you pass a NULL end_pos to _dbus_marshal_validate_type.

	* dbus/dbus-message.[ch]:
	Multi-dimensional arrays have full type specification in the
	outermost array. Iter code re-arranged to handle this.
	Added some more iter tests.

	* doc/dbus-specification.sgml:
	Add me to authors.
	Remove old FIXME.
	Update new array encoding description.
	Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.

	* test/data/invalid-messages/array-with-mixed-types.message:
	* test/data/valid-messages/array-of-array-of-uint32.message:
	Change to the new array format.

	* test/data/invalid-messages/too-short-dict.message:
	Fix bug in test.

	* test/data/valid-messages/recursive-types.message:
	Fix up and extend test.
---
 dbus/dbus-marshal.c | 55 ++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 38 insertions(+), 17 deletions(-)

(limited to 'dbus/dbus-marshal.c')

diff --git a/dbus/dbus-marshal.c b/dbus/dbus-marshal.c
index b1eb6fc7..02343174 100644
--- a/dbus/dbus-marshal.c
+++ b/dbus/dbus-marshal.c
@@ -1027,8 +1027,8 @@ _dbus_marshal_get_arg_end_pos (const DBusString *str,
       {
 	int len;
 
-	/* Demarshal the length (element type is at pos + 0 */
-	len = _dbus_demarshal_uint32 (str, byte_order, pos + 1, &pos);
+	/* Demarshal the length  */
+	len = _dbus_demarshal_uint32 (str, byte_order, pos, &pos);
 	
 	*end_pos = pos + len;
       }
@@ -1169,7 +1169,8 @@ _dbus_marshal_validate_type   (const DBusString *str,
   if (*data > DBUS_TYPE_INVALID && *data <= DBUS_TYPE_LAST)
     {
       *type = *data;
-      *end_pos = pos + 1;
+      if (end_pos != NULL)
+	*end_pos = pos + 1;
       return TRUE;
     }
   
@@ -1194,6 +1195,8 @@ _dbus_marshal_validate_type   (const DBusString *str,
  * @param byte_order the byte order to use
  * @param depth current recursion depth, to prevent excessive recursion
  * @param type the type of the argument
+ * @param array_type_pos the position of the current array type, or
+ *        -1 if not in an array
  * @param pos the pos where the arg starts
  * @param end_pos pointer where the position right
  * after the end position will follow
@@ -1204,6 +1207,7 @@ _dbus_marshal_validate_arg (const DBusString *str,
                             int	              byte_order,
                             int               depth,
 			    int               type,
+			    int               array_type_pos,
                             int               pos,
                             int              *end_pos)
 {
@@ -1340,21 +1344,38 @@ _dbus_marshal_validate_arg (const DBusString *str,
 	int end;
 	int array_type;
 
-	if (!_dbus_marshal_validate_type (str, pos, &array_type, &pos))
+	if (array_type_pos == -1)
+	  {
+	    array_type_pos = pos;
+
+	    do
+	      {
+		if (!_dbus_marshal_validate_type (str, pos, &array_type, &pos))
+		  {
+		    _dbus_verbose ("invalid array type\n");
+		    return FALSE;
+		  }
+		
+		/* NIL values take up no space, so you couldn't iterate over an array of them.
+		 * array of nil seems useless anyway; the useful thing might be array of
+		 * (nil OR string) but we have no framework for that.
+		 */
+		if (array_type == DBUS_TYPE_NIL)
+		  {
+		    _dbus_verbose ("array of NIL is not allowed\n");
+		    return FALSE;
+		  }
+	      }
+	    while (array_type == DBUS_TYPE_ARRAY);
+	  }
+	else
+	  array_type_pos++;
+
+	if (!_dbus_marshal_validate_type (str, array_type_pos, &array_type, NULL))
 	  {
 	    _dbus_verbose ("invalid array type\n");
 	    return FALSE;
 	  }
-
-        /* NIL values take up no space, so you couldn't iterate over an array of them.
-         * array of nil seems useless anyway; the useful thing might be array of
-         * (nil OR string) but we have no framework for that.
-         */
-        if (array_type == DBUS_TYPE_NIL)
-          {
-            _dbus_verbose ("array of NIL is not allowed\n");
-            return FALSE;
-          }
         
 	len = demarshal_and_validate_len (str, byte_order, pos, &pos);
         if (len < 0)
@@ -1371,7 +1392,7 @@ _dbus_marshal_validate_arg (const DBusString *str,
 	while (pos < end)
 	  {
 	    if (!_dbus_marshal_validate_arg (str, byte_order, depth + 1,
-					     array_type, pos, &pos))
+					     array_type, array_type_pos, pos, &pos))
 	      return FALSE;
 	  }
 
@@ -1417,7 +1438,7 @@ _dbus_marshal_validate_arg (const DBusString *str,
 	  {
 	    /* Validate name */
 	    if (!_dbus_marshal_validate_arg (str, byte_order, depth + 1,
-					     DBUS_TYPE_STRING, pos, &pos))
+					     DBUS_TYPE_STRING, -1, pos, &pos))
 	      return FALSE;
 	    
 	    if (!_dbus_marshal_validate_type (str, pos, &dict_type, &pos))
@@ -1428,7 +1449,7 @@ _dbus_marshal_validate_arg (const DBusString *str,
 	    
 	    /* Validate element */
 	    if (!_dbus_marshal_validate_arg (str, byte_order, depth + 1,
-					     dict_type, pos, &pos))
+					     dict_type, -1, pos, &pos))
 	      return FALSE;
 	  }
 	
-- 
cgit