From 4c95a9782c65f88e2904c44abeb734a1b00f6353 Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Sat, 15 Mar 2003 02:19:02 +0000 Subject: 2003-03-14 Havoc Pennington * dbus/dbus-memory.c: add a "detect buffer overwrites on free" cheesy hack * dbus/dbus-transport-debug.c: rework this a good bit to be less complicated. hopefully still works. * dbus/dbus-server-debug.c (handle_new_client): remove timeout manually * glib/dbus-gmain.c (timeout_handler): don't remove timeout after running it * dbus/dbus-message.c (dbus_message_copy): rename from dbus_message_new_from_message, fix it up to copy all the message fields, add test case * bus/dispatch.c (bus_dispatch_test): add some more test code, not quite passing yet --- dbus/dbus-transport-unix.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'dbus/dbus-transport-unix.c') diff --git a/dbus/dbus-transport-unix.c b/dbus/dbus-transport-unix.c index 81c18b4a..a2b8a384 100644 --- a/dbus/dbus-transport-unix.c +++ b/dbus/dbus-transport-unix.c @@ -136,7 +136,12 @@ check_write_watch (DBusTransport *transport) _dbus_watch_new (unix_transport->fd, DBUS_WATCH_WRITABLE); - /* we can maybe add it some other time, just silently bomb */ + /* FIXME this is total crack. The proper fix is probably to + * allocate the write watch on transport creation, keep it + * allocated. But that doesn't solve needing memory to add the + * watch. messages_pending is going to have to handle OOM + * somehow (probably being part of PreallocatedSend) + */ if (unix_transport->write_watch == NULL) goto out; -- cgit