From 1eae184450a585f10c8988613e0f7259e1d6066a Mon Sep 17 00:00:00 2001 From: "John (J5) Palmieri" Date: Wed, 6 Sep 2006 22:00:07 +0000 Subject: * doc/TODO: - Remove pending call locking todo item - dbus_connection_open now holds hard ref. Remove todo item - do proper locking on _dbus_bus_check_connection_and_unref and handle DBUS_BUS_STARTER. Remove todo item - Warn on closing of a shared connection. Remove todo item * bus/bus.c, bus/connection.c, bus/dispatch.c, dbus/dbus-bus.c, dbus/dbus-connection.c: Use the dbus_connection_close_internal so we don't get the warning when closing shared connections * test/test-service.c, test/test-shell-service.c: Applications don't close shared connections themselves so we unref instead of close * test/test-utils.c (test_connection_shutdown): Close the connection * dbus/dbus-bus.c (_dbus_bus_check_connection_and_unref): Changed to _dbus_bus_check_connection_and_unref_unlocked since we only call this method on a locked connection. Make sure we call _dbus_connection_unref_unlocked instead of dbus_connection_unref also. Handle DBUS_BUS_STARTER correctly * dbus/dbus-connection.c (connection_record_shared_unlocked): Mark as shared and hard ref the connection (connection_forget_shared_unlocked): Remove the hard ref from the connection (_dbus_connection_close_internal_and_unlock): New internal function which takes a locked connection and unlocks it after closing it (_dbus_connection_close_internal): New internal function which acts like the origonal dbus_connection_close method by grabbing a connection lock and calling _dbus_connection_close_internal_and_unlock (dbus_connection_close): Public close method, warns when the app trys to close a shared connection --- doc/TODO | 15 --------------- 1 file changed, 15 deletions(-) (limited to 'doc') diff --git a/doc/TODO b/doc/TODO index 2ef7fdef..d3ece326 100644 --- a/doc/TODO +++ b/doc/TODO @@ -21,21 +21,6 @@ Important for 1.0 - just before 1.0, try a HAVE_INT64=0 build and be sure it runs - - fix locking on DBusPendingCall - - - dbus_connection_open() is like dbus_bus_get() in that it returns a shared - connection; it needs the corresponding fix to hold a strong reference to - these connections. - - - _dbus_bus_check_connection_and_unref does not do proper locking and - doesn't handle all the shared connections, e.g. DBUS_BUS_STARTER - - - for both the dbus-bus.c shared connections and dbus_connection_open() - shared connections, it is probably appropriate to warn() if someone - calls close() on them ; essentially shared connections are not closeable - because it's unclear who would do the closing and when, short of - dbus_shutdown() - Important for 1.0 GLib Bindings === -- cgit