From 4058579dae09659ea2dc7f3dd20e034a3be3b0bf Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Thu, 27 Mar 2008 16:52:40 -0400 Subject: Do not provide a signature to dbus_message_iter_open_container() when opening a dict entry. 2008-03-27 Havoc Pennington * tools/dbus-send.c (append_dict): Do not provide a signature to dbus_message_iter_open_container() when opening a dict entry. --- tools/dbus-send.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'tools') diff --git a/tools/dbus-send.c b/tools/dbus-send.c index 66d0bcf9..407c0497 100644 --- a/tools/dbus-send.c +++ b/tools/dbus-send.c @@ -150,14 +150,10 @@ append_dict (DBusMessageIter *iter, int keytype, int valtype, const char *value) while (val != NULL) { DBusMessageIter subiter; - char sig[3]; - sig[0] = keytype; - sig[1] = valtype; - sig[2] = '\0'; dbus_message_iter_open_container (iter, DBUS_TYPE_DICT_ENTRY, - sig, + NULL, &subiter); append_arg (&subiter, keytype, val); -- cgit From 193ebb7083fb1e9dccff04fc0a9d805a0aa03ea2 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Mon, 31 Mar 2008 18:16:00 -0400 Subject: Make sure we call XFlush() on all code paths (FDO bug #15293) --- tools/dbus-launch-x11.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'tools') diff --git a/tools/dbus-launch-x11.c b/tools/dbus-launch-x11.c index 927d8634..442e9ba2 100644 --- a/tools/dbus-launch-x11.c +++ b/tools/dbus-launch-x11.c @@ -341,7 +341,7 @@ static Window set_address_in_x11(char *address, pid_t pid) { char *current_address; - Window wid; + Window wid = None; unsigned long pid32; /* Xlib property functions want _long_ not 32-bit for format "32" */ /* lock the X11 display to make sure we're doing this atomically */ @@ -350,16 +350,14 @@ set_address_in_x11(char *address, pid_t pid) if (!x11_get_address (¤t_address, NULL, NULL)) { /* error! */ - XUngrabServer (xdisplay); - return None; + goto out; } if (current_address != NULL) { /* someone saved the address in the meantime */ - XUngrabServer (xdisplay); free (current_address); - return None; + goto out; } /* Create our window */ @@ -378,9 +376,11 @@ set_address_in_x11(char *address, pid_t pid) /* Now grab the selection */ XSetSelectionOwner (xdisplay, selection_atom, wid, CurrentTime); + out: /* Ungrab the server to let other people use it too */ XUngrabServer (xdisplay); + /* And make sure that the ungrab gets sent to X11 */ XFlush (xdisplay); return wid; -- cgit From 0bfc5e8d23a5ae56eee5ef2073911cddcbd0c4b0 Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Mon, 31 Mar 2008 18:20:07 -0400 Subject: Check for X11 events before selecting (FDO bug #15293) --- tools/dbus-launch.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) (limited to 'tools') diff --git a/tools/dbus-launch.c b/tools/dbus-launch.c index 6a10ffa3..216f7435 100644 --- a/tools/dbus-launch.c +++ b/tools/dbus-launch.c @@ -458,6 +458,17 @@ kill_bus_when_session_ends (void) while (TRUE) { +#ifdef DBUS_BUILD_X11 + /* Dump events on the floor, and let + * IO error handler run if we lose + * the X connection. It's important to + * run this before going into select() since + * we might have queued outgoing messages or + * events. + */ + x11_handle_event (); +#endif + FD_ZERO (&read_set); FD_ZERO (&err_set); @@ -472,7 +483,7 @@ kill_bus_when_session_ends (void) FD_SET (x_fd, &read_set); FD_SET (x_fd, &err_set); } - + select (MAX (tty_fd, x_fd) + 1, &read_set, NULL, &err_set, NULL); @@ -483,15 +494,12 @@ kill_bus_when_session_ends (void) } #ifdef DBUS_BUILD_X11 - /* Dump events on the floor, and let - * IO error handler run if we lose - * the X connection + /* Events will be processed before we select again */ if (x_fd >= 0) verbose ("X fd condition reading = %d error = %d\n", FD_ISSET (x_fd, &read_set), FD_ISSET (x_fd, &err_set)); - x11_handle_event (); #endif if (tty_fd >= 0) -- cgit