From 6ee0b41bcb113e2db50193fd797623f56242e95d Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Sat, 17 Oct 2009 00:05:10 +0200 Subject: pulse: mainloop creation can fail too, so handle that --- ext/pulse/pulsemixerctrl.c | 10 +++++++--- ext/pulse/pulseprobe.c | 12 +++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/ext/pulse/pulsemixerctrl.c b/ext/pulse/pulsemixerctrl.c index 8df08407..591337bf 100644 --- a/ext/pulse/pulsemixerctrl.c +++ b/ext/pulse/pulsemixerctrl.c @@ -213,7 +213,7 @@ static gboolean gst_pulsemixer_ctrl_open (GstPulseMixerCtrl * c) { int e; - gchar *name = gst_pulse_client_name (); + gchar *name; pa_operation *o = NULL; g_assert (c); @@ -221,10 +221,14 @@ gst_pulsemixer_ctrl_open (GstPulseMixerCtrl * c) GST_DEBUG_OBJECT (c->object, "ctrl open"); c->mainloop = pa_threaded_mainloop_new (); - g_assert (c->mainloop); + if (!c->mainloop) + return FALSE; e = pa_threaded_mainloop_start (c->mainloop); - g_assert (e == 0); + if (e < 0) + return FALSE; + + name = gst_pulse_client_name (); pa_threaded_mainloop_lock (c->mainloop); diff --git a/ext/pulse/pulseprobe.c b/ext/pulse/pulseprobe.c index b393b2c2..6ebbfb21 100644 --- a/ext/pulse/pulseprobe.c +++ b/ext/pulse/pulseprobe.c @@ -1,3 +1,5 @@ +/*-*- Mode: C; c-basic-offset: 2 -*-*/ + /* * GStreamer pulseaudio plugin * @@ -99,17 +101,21 @@ static gboolean gst_pulseprobe_open (GstPulseProbe * c) { int e; - gchar *name = gst_pulse_client_name (); + gchar *name; g_assert (c); GST_DEBUG_OBJECT (c->object, "probe open"); c->mainloop = pa_threaded_mainloop_new (); - g_assert (c->mainloop); + if (!c->mainloop) + return FALSE; e = pa_threaded_mainloop_start (c->mainloop); - g_assert (e == 0); + if (e < 0) + return FALSE; + + name = gst_pulse_client_name (); pa_threaded_mainloop_lock (c->mainloop); -- cgit