summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* protocol-native: Use original requested latency on stream movesArun Raghavan2011-06-141-4/+12
| | | | | | | | We were calculating new latency based on the latency set on the old sink/source, rather than the actual latency requested by the client. Over a series of moves, this will lead the latency being ~halved each time, resulting in an eventual rewind flood from a latency that cannot be handled.
* echo-cancel: More preprocessing fixesArun Raghavan2011-06-131-2/+6
| | | | | The speex_preprocess_ctl() function takes a spx_int32_t, but we've been passing a pa_bool_t, which could potentially crash.
* echo-cancel: Fix preprocessor initialisationArun Raghavan2011-06-131-1/+1
| | | | | | We were using the block size in bytes instead of samples, which meant preprocessing was broken. This fix makes a large-ish difference in the quality of echo-cancellation with speex.
* win32: define WIN32_LEAN_AND_MEANMaarten Bosmans2011-06-121-0/+1
| | | | | This makes windows.h include less headers. Otherwise boolean is typedef'ed and that clashes with libjson.
* gitignore: Add connect-stress, extended-test and format-test.Tanu Kaskinen2011-06-121-0/+3
|
* tests: Update extended API testArun Raghavan2011-06-121-3/+3
| | | | | The test wasn't updated after we changed the pa_format_info proplist format.
* combine: Fix a crash on shutdown if the module is loaded outside of our control.Colin Guthrie2011-06-081-5/+7
| | | | By using module indexes rather than module pointers we avoid this posibility.
* device-manager: Free a hook slot to prevent segv on unloadColin Guthrie2011-06-061-0/+3
|
* pulsecore: Add a couple pa_asserts() on pa_tagstruct* calls.Colin Guthrie2011-06-061-0/+2
|
* module-combine-sink: Check running flag before rendering in null modeForest Bond2011-06-021-0/+4
| | | | | This makes process_render_null consistent with render_memblock and avoids introducing slight inaccuracies in early latency estimates.
* module-combine-sink: Initialize smoother in paused stateForest Bond2011-06-021-6/+9
| | | | | | | | | | | | | The smoother is paused on initialization and resumed when the sink state is set to running. Otherwise, early latency estimates are too low since there is some delay between module initialization and entering the running state. After the smoother is initially resumed, it is paused when the sink state is not running. The previous behavior was to pause only when the sink enters suspended state, however, this would lead to large errors in latency estimates after the sink has been idle for some time.
* module-combine-sink: Initialize smoother with offset pa_rtclock_now()Forest Bond2011-06-021-1/+1
| | | | | The smoother was being initialized with offset zero, which caused the sink latency to be unconditionally reported as zero.
* streams: Fix the actual resampler method shown in debug messages.Colin Guthrie2011-06-022-0/+2
|
* osx: pass -headerpad_max_install_names to the linker, tooDaniel Mack2011-05-301-1/+1
| | | | | This option won't make it to the actual libtool command which does the linking when not prefixed with -Wl,
* alsa-mixer: Fix the assumption that volume is always positiveLu Guanqun2011-05-301-1/+5
| | | | | | | | | | | | | | | | | Add a variable to track whether the actual volume is set or not. Suppose this: min volume: -126 max volume: 0 then when user wants to set some constant volume to -10, it would fail. While the alsa values are typically positive, some values are "funky" and have negative values. It is desirable to fix this at the alsa level so that the numbers are positive, but it's not technically invalid, and thus we have to support it. Discussed here: http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/9832 and http://thread.gmane.org/gmane.linux.alsa.devel/85459
* echo-cancel: Fix a crash is speex cleanupArun Raghavan2011-05-281-1/+2
| | | | | | If module initialisation fails, the speex done() function might try to free a value that's not been allocated yet. Adding protection for this condition.
* echo-cancel: Fix echo suppression, add some knobsBart Cerneels2011-05-282-3/+36
| | | | | | | The echo suppress attenuation value was being incorrectly modified. Fixed and added 2 arguments to change the attenuation of the residual echo filter. Default values of the speex preprocessor will be used when omitted.
* echo-cancel: Speex preprocessor has to run *after* the AEC.Bart Cerneels2011-05-281-3/+4
| | | | This is how it is expected to be run.
* echo-cancel: Add speex preprocessingArun Raghavan2011-05-242-3/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows the selective enabling of speex' preprocessing algorithms before running the echo-canceller -- for now this includes automatic gain control, noise suppression and echo suppression. It's all off by default for now, though at some point in the near future we might want to enable at least denoising by default. The denoising works pretty well, though we might want to add a way to tweak the noise-suppression knob that libspeex provides. The AGC option is just a stop-gap -- we need a real AGC mechanism that tweaks the source volume rather than doing this in software. The speex documentation mentions VAD and dereverb, but it appears that these are not complete yet. We don't do all this in a separate module from module-echo-cancel to avoid the overhead of adding another virtual source. It makes more sense to make a separate virtual source module that can be used for cases where preprocessing is useful but AEC is not (for e.g. noise suppression for fan noise in a recording application). Another reason to keep this integrated with the AEC module is that the echo suppression bits use the speex echo canceller state. This does leak some information about the AEC implementation into module-echo-cancel, but this is unavoidable.
* format: Fix channel map handlingArun Raghavan2011-05-202-7/+9
| | | | | Channel map handling in the extended API was broken. Thanks for Milos_SD for pointing this out on IRC.
* echo-cancel: Remove extraneous debug messageArun Raghavan2011-05-201-1/+0
| | | | This was making it impossible to run in debug mode with save_aec=1
* echo-cancel: Don't overpad variableArun Raghavan2011-05-161-1/+1
| | | | The padding was to be 16 bytes, not 16 elements.
* build-sys: Link libpulse directly to libdbus-1 if neededSjoerd Simons2011-05-161-1/+6
| | | | | | Linking libpulse with gold or when using ld --no-add-needed fails as libpulse uses dbus methods directly but isn't explicitly linked to it. So link to it when needed :)
* protocol-native: Fix memory leaks introduced in protocol 21 (passthrough ↵Colin Guthrie2011-05-161-26/+30
| | | | | | | | | | | support) The proplist used may never be freed if an error condition was found with CHECK_VALIDITY macro and the formats idxset was never freed regardless of error state. This change fixes adds a new maco CHECK_VALIDITY_GOTO() which allows for cleanup to be done before returning.
* sink-input: Fix memory leak of proplist when sending format-changed eventsColin Guthrie2011-05-161-0/+1
|
* loopback: Add a modarg for disabling remixing.Tanu Kaskinen2011-05-151-5/+13
|
* bluetooth: Fix early return styling and add missing return valueColin Guthrie2011-05-151-5/+6
| | | | Thanks to Tanu Kaskinen for pointing out the missing return.
* suspend-on-idle: Trigger mempool vacuumingJyri Sarha2011-05-151-1/+40
| | | | | | | | In a setup with one or more filter sinks or sources there is always at least one stream existing. In such a situation normal mempool vacuuming never happens. This patch causes suspend-on-idle module to vacuum memory when ever it notices that all sinks and sources are suspended. The behavior can be enabled with a module parameter.
* protocol-native: Stop auto timing updates if connected to suspended sink or ↵Jyri Sarha2011-05-151-4/+24
| | | | | | | | | | | | | source This quite is an old patch. It was added to N900 to avoid unnecessary wake-ups when the phone is in power save mode (= blank screen and no user interaction). In this situation if the user had a browser window with flash animation open pulseaudio kept waking up every 10 seconds, causing a severe hit to use times. Anyway I do not see any reason to send timing updates if the sink or source where the stream is connected to is suspended.
* tests: Fix resampler-test.Colin Guthrie2011-05-151-4/+3
| | | | | | | | | | This has been broken since c376ac5920fdeb46ca844d9518e22f17adffb635 when run without any arguments. Passing in -v (verbose) caused the test to work fine. I think this oversight is just a thinko in the original work but it obviously broke 'make check' and thus distcheck. Also fix a couple compiler warnings.
* Merge branch 'passthrough'Colin Guthrie2011-05-1545-198/+1758
|\
| * module-tunnel: Update for recent protocol changesArun Raghavan2011-05-151-0/+59
| | | | | | | | | | | | | | | | | | This updates the tunnel module for protocol version >= 19. module-tunnel-sink does not proxy server-side passthrough support (yet). This would require a few more changes, namely keeping track of what formats are available and if any other sink inputs are connected on the server-side.
| * format: Add some convenience API for setting propertiesArun Raghavan2011-05-153-3/+38
| | | | | | | | | | Adds functions to set sample format, rate, channels and channel map on a format to make life easier for users of the API.
| * format: Extend properties to handle lists/rangesArun Raghavan2011-05-156-22/+383
| | | | | | | | | | | | | | | | | | | | | | | | | | This replaces the simple string used by pa_format_info's proplist with a JSON string (accessed via new API only). This allows us to express lists and ranges more cleanly, and embed type information for future extensibility. We use json-c for JSON parsing. This is a lightweight depdency (32 KB on my system) and avoids the hassle of having to reinvent a JSON parser. Also included is a test which verifies functionality and is valgrind-clean.
| * sink-input: Provide more information to client when format is lostArun Raghavan2011-05-152-1/+13
| | | | | | | | | | | | | | | | When the sink format changes and we kill the stream, clients need a way to know (a) what device they should reconnect to, and (b) what the stream running time was when the stream got killed (pa_stream_get_time() won't work after the stream has been killed). This adds these two bits of information in the event callback's proplist parameter.
| * format: Add correct sample spec conversion for E-AC3Arun Raghavan2011-05-151-0/+3
| | | | | | | | | | | | | | IEC61937-encapsulated E-AC3 frames contain 6 audio blocks per substream, which corresponds to 1536 samples contained a 24576-byte frame. To cope with this, we maintain the s16le stereo sample spec, but quadruple the sample rate so that the conversion remains accurate.
| * format: Export pa_format_info_is_compatible in APIArun Raghavan2011-05-154-2/+11
| | | | | | | | This allows clients to perform checks between formats as well.
| * sink-input: Add a format-lost eventArun Raghavan2011-05-152-1/+9
| | | | | | | | | | | | | | This event is emitted if the sink-input could not be moved to a new sink because it doesn't support the format of the sink-input. Clients can reconnect their stream with a different format if they wish or gracefully exit.
| * sink-input: Don't restore volume for passthrough streamsArun Raghavan2011-05-151-0/+6
| |
| * sink-input: Don't print an error if a passthrough connection failsArun Raghavan2011-05-151-1/+2
| | | | | | | | | | | | The assertion message is misleading, since the passthrough connection can fail for reasons the client has no control over (like other sink inputs being connected).
| * core: Factor out passthrough checks into their own functionsArun Raghavan2011-05-024-17/+41
| | | | | | | | | | | | | | | | | | | | Since we currently have two mechanisms to signal a passthrough connection (non-PCM format or PA_SINK_INPUT_PASSTHROUGH flag), we move all the related checks into functions and use those everywhere. This makes things more consistent, and should we decide to get rid of the flag, we only need to change pa_sink_input_*_is_passthrough() accordingly.
| * format: Add a type for DTSArun Raghavan2011-05-022-0/+4
| |
| * introspect: Get format of sink inputArun Raghavan2011-05-024-2/+11
| | | | | | | | | | This gets the negotiated format of sink inputs in pa_context_get_sink_input*(). Also prints the format in 'pactl list'.
| * introspect: Get formats for sinksArun Raghavan2011-05-024-1/+60
| | | | | | | | | | This gets the list of supported formats for a sink in pa_context_get_sink_info*(). Also prints these in 'pactl list'.
| * stream: Add API to get a stream's pa_format_infoArun Raghavan2011-05-023-0/+14
| |
| * format: Add some convenience functions for printingArun Raghavan2011-05-023-0/+51
| |
| * format: Const-ify some parametersArun Raghavan2011-05-022-4/+4
| |
| * alsa: Reconfigure sink sample rate for passthrough inputsArun Raghavan2011-05-021-0/+52
| | | | | | | | | | | | When a passthrough sink-input is added, we need to reconfigure the sink's sample rate since no resampling occurs. We revert to the original rate when the passthrough sink-input is removed.
| * core: Suspend monitor when a sink enters passthrough modeArun Raghavan2011-05-023-1/+18
| | | | | | | | | | | | | | | | | | | | | | In most cases it is expected that clients cannot consume compressed data from monitor sources, so we suspend the monitor source when the sink goes into passthrough mode. Eventually, when the extended API includes client notifications for changed formats, we should emit a notification on the monitor so that clients can decide what they want to do when this happens (disconnect or consume the data anyway).
| * sink: Trivial typo fix in commentArun Raghavan2011-05-021-1/+1
| |