From aa9348441db34b787784711f19882d6c42fa315d Mon Sep 17 00:00:00 2001 From: huan zheng Date: Wed, 6 Jan 2010 00:21:07 +0100 Subject: core: volume ramping fix Hi, I found that volume ramping is inside PA now. there's a minor fix here, it is a bug i found after the patch is submitted: line 1781 of sink-input.c : if ((i->thread_info.ramp_info.envelope_dying - nbytes) <= 0) { need to be changed to if ((i->thread_info.ramp_info.envelope_dying - (ssize_t) nbytes) <= 0) { otherwise this argument will never be negative since nbytes is of type size_t which is unsigned. Please change it when you have time, sorry if bring any inconvenience. :) --- src/pulsecore/sink-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/pulsecore/sink-input.c') diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c index 9b4edeb9..a4902909 100644 --- a/src/pulsecore/sink-input.c +++ b/src/pulsecore/sink-input.c @@ -1780,7 +1780,7 @@ static void sink_input_rewind_ramp_info(pa_sink_input *i, size_t nbytes) { i->thread_info.ramp_info.is_ramping = TRUE; } } else if (i->thread_info.ramp_info.envelope_dying < envelope_length) { - if ((i->thread_info.ramp_info.envelope_dying - nbytes) <= 0) { + if ((i->thread_info.ramp_info.envelope_dying - (ssize_t) nbytes) <= 0) { pa_log_debug("Envelope Restart"); pa_envelope_restart(i->thread_info.ramp_info.envelope); } -- cgit