From 2edb4df175ee69e386ec3923e69af6899f55e2eb Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Thu, 29 Oct 2009 01:49:40 +0100 Subject: smoother: add comments about optimization recommendations from Jason Newton --- src/pulsecore/time-smoother.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src/pulsecore/time-smoother.c') diff --git a/src/pulsecore/time-smoother.c b/src/pulsecore/time-smoother.c index d6c37878..1371ad56 100644 --- a/src/pulsecore/time-smoother.c +++ b/src/pulsecore/time-smoother.c @@ -196,6 +196,13 @@ static double avg_gradient(pa_smoother *s, pa_usec_t x) { int64_t ax = 0, ay = 0, k, t; double r; + /* FIXME: Optimization: Jason Newton suggested that instead of + * going through the history on each iteration we could calculated + * avg_gradient() as we go. + * + * Second idea: it might make sense to weight history entries: + * more recent entries should matter more than old ones. */ + /* Too few measurements, assume gradient of 1 */ if (s->n_history < s->min_history) return 1; -- cgit