diff options
Diffstat (limited to 'avahi-core')
| -rw-r--r-- | avahi-core/core.h | 2 | ||||
| -rw-r--r-- | avahi-core/iface-pfroute.c | 41 | ||||
| -rw-r--r-- | avahi-core/iface.c | 145 | ||||
| -rw-r--r-- | avahi-core/server.c | 331 | 
4 files changed, 298 insertions, 221 deletions
diff --git a/avahi-core/core.h b/avahi-core/core.h index 55aafe2..94d1970 100644 --- a/avahi-core/core.h +++ b/avahi-core/core.h @@ -47,6 +47,8 @@ typedef struct AvahiServerConfig {      char *domain_name;                /**< Default domain name. If left empty defaults to .local */      int use_ipv4;                     /**< Enable IPv4 support */      int use_ipv6;                     /**< Enable IPv6 support */ +    AvahiStringList *allow_interfaces;/**< Allow specific interface to be used for Avahi */ +    AvahiStringList *deny_interfaces; /**< Deny specific interfaces to be used for Avahi */      int publish_hinfo;                /**< Register a HINFO record for the host containing the local OS and CPU type */      int publish_addresses;            /**< Register A, AAAA and PTR records for all local IP addresses */      int publish_workstation;          /**< Register a _workstation._tcp service */ diff --git a/avahi-core/iface-pfroute.c b/avahi-core/iface-pfroute.c index f96bfc2..391081e 100644 --- a/avahi-core/iface-pfroute.c +++ b/avahi-core/iface-pfroute.c @@ -125,7 +125,7 @@ static void rtm_addr(struct rt_msghdr *rtm, AvahiInterfaceMonitor *m)    int raddr_valid = 0;    struct ifa_msghdr *ifam = (struct ifa_msghdr *) rtm;    char *cp = (char *)(ifam + 1); -  int addrs = ifam->ifam_addrs; +  char *cp0;    int i;    int prefixlen = 0;    struct sockaddr *sa  =NULL; @@ -135,17 +135,30 @@ static void rtm_addr(struct rt_msghdr *rtm, AvahiInterfaceMonitor *m)      ((struct sockaddr *)cp)->sa_family = AF_INET;  #endif -  if(((struct sockaddr *)cp)->sa_family != AF_INET && ((struct sockaddr *)cp)->sa_family != AF_INET6) +  for (cp0 = cp, i = 0; i < RTAX_MAX; i++) { +    if (!(ifam->ifam_addrs & (1<<i))) +      continue; +    sa = (struct sockaddr *)cp; +    if (i == RTAX_IFA) +      break; +#ifdef SA_SIZE +    cp += SA_SIZE(sa); +#else +    ADVANCE(cp, sa); +#endif +  } + +  if(sa->sa_family != AF_INET && sa->sa_family != AF_INET6)      return; -  if (!(iface = avahi_interface_monitor_get_interface(m, (AvahiIfIndex) ifam->ifam_index, avahi_af_to_proto(((struct sockaddr *)cp)->sa_family)))) +  if (!(iface = avahi_interface_monitor_get_interface(m, (AvahiIfIndex) ifam->ifam_index, avahi_af_to_proto(sa->sa_family))))      return; -  raddr.proto = avahi_af_to_proto(((struct sockaddr *)cp)->sa_family); +  raddr.proto = avahi_af_to_proto(sa->sa_family); -  for(i = 0; addrs != 0 && i < RTAX_MAX; addrs &= ~(1<<i), i++) +  for(cp = cp0, i = 0; i < RTAX_MAX; i++)      { -      if (!(addrs & 1<<i)) +      if (!(ifam->ifam_addrs & (1<<i)))  	continue;        sa = (struct sockaddr *)cp;  #ifdef HAVE_SYS_SYSCTL_H @@ -172,6 +185,13 @@ static void rtm_addr(struct rt_msghdr *rtm, AvahiInterfaceMonitor *m)  	  break;  	case RTA_IFA:  	  memcpy(raddr.data.data, &((struct sockaddr_in6 *)sa)->sin6_addr,  sizeof(struct in6_addr)); +#ifdef __KAME__ +	  if (IN6_IS_ADDR_LINKLOCAL((struct in6_addr *)raddr.data.data)) +	    { +	      ((struct in6_addr *)raddr.data.data)->s6_addr[2] = 0; +	      ((struct in6_addr *)raddr.data.data)->s6_addr[3] = 0; +	    } +#endif  	  raddr_valid = 1;  	default:  	  break; @@ -196,9 +216,12 @@ static void rtm_addr(struct rt_msghdr *rtm, AvahiInterfaceMonitor *m)        if (!(addriface = avahi_interface_monitor_get_address(m, iface, &raddr)))  	if (!(addriface = avahi_interface_address_new(m, iface, &raddr, prefixlen)))  	  return; /* OOM */ -      /*       FIXME */ -      /*       addriface->global_scope = ifaddrmsg->ifa_scope == RT_SCOPE_UNIVERSE || ifaddrmsg->ifa_scope == RT_SCOPE_SITE; */ -      addriface->global_scope = 1; +      if (raddr.proto == AVAHI_PROTO_INET6) +        { +	  addriface->global_scope = !(IN6_IS_ADDR_LINKLOCAL((struct in6_addr *)raddr.data.data) || IN6_IS_ADDR_MULTICAST((struct in6_addr *)raddr.data.data)); +	} +      else +        addriface->global_scope = 1;      }    else      { diff --git a/avahi-core/iface.c b/avahi-core/iface.c index 8098de4..5fbfc19 100644 --- a/avahi-core/iface.c +++ b/avahi-core/iface.c @@ -2,17 +2,17 @@  /***    This file is part of avahi. -  +    avahi is free software; you can redistribute it and/or modify it    under the terms of the GNU Lesser General Public License as    published by the Free Software Foundation; either version 2.1 of the    License, or (at your option) any later version. -  +    avahi is distributed in the hope that it will be useful, but WITHOUT    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY    or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General    Public License for more details. -  +    You should have received a copy of the GNU Lesser General Public    License along with avahi; if not, write to the Free Software    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 @@ -59,19 +59,19 @@ void avahi_interface_address_update_rrs(AvahiInterfaceAddress *a, int remove_rrs          m->server->state == AVAHI_SERVER_REGISTERING)) {          /* Fill the entry group */ -        if (!a->entry_group)  +        if (!a->entry_group)              a->entry_group = avahi_s_entry_group_new(m->server, avahi_host_rr_entry_group_callback, NULL);          if (!a->entry_group) /* OOM */              return; -         +          if (avahi_s_entry_group_is_empty(a->entry_group)) {              char t[AVAHI_ADDRESS_STR_MAX];              AvahiProtocol p;              p = (a->interface->protocol == AVAHI_PROTO_INET && m->server->config.publish_a_on_ipv6) ||                  (a->interface->protocol == AVAHI_PROTO_INET6 && m->server->config.publish_aaaa_on_ipv4) ? AVAHI_PROTO_UNSPEC : a->interface->protocol; -             +              avahi_address_snprint(t, sizeof(t), &a->address);              avahi_log_info("Registering new address record for %s on %s.%s.", t, a->interface->hardware->name, p == AVAHI_PROTO_UNSPEC ? "*" : avahi_proto_to_string(p)); @@ -97,15 +97,15 @@ void avahi_interface_address_update_rrs(AvahiInterfaceAddress *a, int remove_rrs                  avahi_server_decrease_host_rr_pending(m->server);              avahi_log_info("Withdrawing address record for %s on %s.", t, a->interface->hardware->name); -             +              avahi_s_entry_group_reset(a->entry_group);          } -    }  +    }  }  void avahi_interface_update_rrs(AvahiInterface *i, int remove_rrs) {      AvahiInterfaceAddress *a; -     +      assert(i);      for (a = i->addresses; a; a = a->address_next) @@ -132,21 +132,21 @@ void avahi_hw_interface_update_rrs(AvahiHwInterface *hw, int remove_rrs) {          if (!hw->entry_group)              return; /* OOM */ -         +          if (avahi_s_entry_group_is_empty(hw->entry_group)) {              char name[AVAHI_LABEL_MAX], mac[256];              avahi_format_mac_address(mac, sizeof(mac), hw->mac_address, hw->mac_address_size);              snprintf(name, sizeof(name), "%s [%s]", m->server->host_name, mac); -            if (avahi_server_add_service(m->server, hw->entry_group, hw->index, AVAHI_PROTO_UNSPEC, 0, name, "_workstation._tcp", NULL, NULL, 9, NULL) < 0) {  +            if (avahi_server_add_service(m->server, hw->entry_group, hw->index, AVAHI_PROTO_UNSPEC, 0, name, "_workstation._tcp", NULL, NULL, 9, NULL) < 0) {                  avahi_log_warn(__FILE__": avahi_server_add_service() failed: %s", avahi_strerror(m->server->error));                  avahi_s_entry_group_free(hw->entry_group);                  hw->entry_group = NULL;              } else                  avahi_s_entry_group_commit(hw->entry_group);          } -         +      } else {          if (hw->entry_group && !avahi_s_entry_group_is_empty(hw->entry_group)) { @@ -179,7 +179,7 @@ static int interface_mdns_mcast_join(AvahiInterface *i, int join) {      if ((i->protocol == AVAHI_PROTO_INET6 && i->monitor->server->fd_ipv6 < 0) ||          (i->protocol == AVAHI_PROTO_INET && i->monitor->server->fd_ipv4 < 0))          return -1; -     +      if (join) {          AvahiInterfaceAddress *a; @@ -210,7 +210,7 @@ static int interface_mdns_mcast_join(AvahiInterface *i, int join) {          r = avahi_mdns_mcast_join_ipv6(i->monitor->server->fd_ipv6, &i->local_mcast_address.data.ipv6, i->hardware->index, join);      else {          assert(i->protocol == AVAHI_PROTO_INET); -             +          r = avahi_mdns_mcast_join_ipv4(i->monitor->server->fd_ipv4, &i->local_mcast_address.data.ipv4, i->hardware->index, join);      } @@ -218,7 +218,7 @@ static int interface_mdns_mcast_join(AvahiInterface *i, int join) {          i->mcast_joined = 0;      else          i->mcast_joined = join; -     +      return 0;  } @@ -231,11 +231,11 @@ static int interface_mdns_mcast_rejoin(AvahiInterface *i) {      /* Check whether old address we joined with is still available. If       * not, rejoin using an other address. */ -     +      for (a = i->addresses; a; a = a->address_next) {          if (a->global_scope && !usable)              usable = a; -         +          if (avahi_address_cmp(&a->address, &i->local_mcast_address) == 0) {              if (a->global_scope) @@ -250,7 +250,7 @@ static int interface_mdns_mcast_rejoin(AvahiInterface *i) {      if (found && !usable)          /* No action necessary: the address still exists and no better one has been found */          return 0; -     +      interface_mdns_mcast_join(i, 0);      return interface_mdns_mcast_join(i, 1);  } @@ -266,7 +266,7 @@ void avahi_interface_address_free(AvahiInterfaceAddress *a) {          avahi_s_entry_group_free(a->entry_group);      interface_mdns_mcast_rejoin(a->interface); -     +      avahi_free(a);  } @@ -280,14 +280,14 @@ void avahi_interface_free(AvahiInterface *i, int send_goodbye) {      if (i->mcast_joined)          interface_mdns_mcast_join(i, 0); -     +      /* Remove queriers */      avahi_querier_free_all(i);      avahi_hashmap_free(i->queriers_by_key);      /* Remove local RRs */      avahi_interface_update_rrs(i, 1); -     +      while (i->addresses)          avahi_interface_address_free(i->addresses); @@ -295,10 +295,10 @@ void avahi_interface_free(AvahiInterface *i, int send_goodbye) {      avahi_query_scheduler_free(i->query_scheduler);      avahi_probe_scheduler_free(i->probe_scheduler);      avahi_cache_free(i->cache); -     +      AVAHI_LLIST_REMOVE(AvahiInterface, interface, i->monitor->interfaces, i);      AVAHI_LLIST_REMOVE(AvahiInterface, by_hardware, i->hardware->interfaces, i); -     +      avahi_free(i);  } @@ -306,13 +306,13 @@ void avahi_hw_interface_free(AvahiHwInterface *hw, int send_goodbye) {      assert(hw);      avahi_hw_interface_update_rrs(hw, 1); -     +      while (hw->interfaces)          avahi_interface_free(hw->interfaces, send_goodbye);      if (hw->entry_group)          avahi_s_entry_group_free(hw->entry_group); -     +      AVAHI_LLIST_REMOVE(AvahiHwInterface, hardware, hw->monitor->hw_interfaces, hw);      avahi_hashmap_remove(hw->monitor->hashmap, &hw->index); @@ -322,14 +322,14 @@ void avahi_hw_interface_free(AvahiHwInterface *hw, int send_goodbye) {  AvahiInterface* avahi_interface_new(AvahiInterfaceMonitor *m, AvahiHwInterface *hw, AvahiProtocol protocol) {      AvahiInterface *i; -     +      assert(m);      assert(hw);      assert(AVAHI_PROTO_VALID(protocol));      if (!(i = avahi_new(AvahiInterface, 1)))          goto fail; /* OOM */ -         +      i->monitor = m;      i->hardware = hw;      i->protocol = protocol; @@ -354,7 +354,7 @@ AvahiInterface* avahi_interface_new(AvahiInterfaceMonitor *m, AvahiHwInterface *      AVAHI_LLIST_PREPEND(AvahiInterface, interface, m->interfaces, i);      return i; -     +  fail:      if (i) { @@ -373,13 +373,13 @@ fail:  AvahiHwInterface *avahi_hw_interface_new(AvahiInterfaceMonitor *m, AvahiIfIndex idx) {      AvahiHwInterface *hw; -     +      assert(m);      assert(AVAHI_IF_VALID(idx));      if  (!(hw = avahi_new(AvahiHwInterface, 1)))          return NULL; -         +      hw->monitor = m;      hw->name = NULL;      hw->flags_ok = 0; @@ -390,7 +390,7 @@ AvahiHwInterface *avahi_hw_interface_new(AvahiInterfaceMonitor *m, AvahiIfIndex      AVAHI_LLIST_HEAD_INIT(AvahiInterface, hw->interfaces);      AVAHI_LLIST_PREPEND(AvahiHwInterface, hardware, m->hw_interfaces, hw); -             +      avahi_hashmap_insert(m->hashmap, &hw->index, hw);      if (m->server->fd_ipv4 >= 0 || m->server->config.publish_a_on_ipv6) @@ -441,7 +441,7 @@ void avahi_interface_check_relevant(AvahiInterface *i) {              avahi_announce_interface(m->server, i);              avahi_multicast_lookup_engine_new_interface(m->server->multicast_lookup_engine, i);          } -         +      } else if (!b && i->announcing) {          avahi_log_info("Interface %s.%s no longer relevant for mDNS.", i->hardware->name, avahi_proto_to_string(i->protocol)); @@ -456,14 +456,14 @@ void avahi_interface_check_relevant(AvahiInterface *i) {          avahi_cache_flush(i->cache);          i->announcing = 0; -         +      } else          interface_mdns_mcast_rejoin(i);  }  void avahi_hw_interface_check_relevant(AvahiHwInterface *hw) {      AvahiInterface *i; -     +      assert(hw);      for (i = hw->interfaces; i; i = i->by_hardware_next) @@ -484,7 +484,7 @@ AvahiInterfaceMonitor *avahi_interface_monitor_new(AvahiServer *s) {      if (!(m = avahi_new0(AvahiInterfaceMonitor, 1)))          return NULL; /* OOM */ -         +      m->server = s;      m->list_complete = 0;      m->hashmap = avahi_hashmap_new(avahi_int_hash, avahi_int_equal, NULL, NULL); @@ -511,7 +511,7 @@ void avahi_interface_monitor_free(AvahiInterfaceMonitor *m) {      assert(!m->interfaces);      avahi_interface_monitor_free_osdep(m); -     +      if (m->hashmap)          avahi_hashmap_free(m->hashmap); @@ -522,7 +522,7 @@ void avahi_interface_monitor_free(AvahiInterfaceMonitor *m) {  AvahiInterface* avahi_interface_monitor_get_interface(AvahiInterfaceMonitor *m, AvahiIfIndex idx, AvahiProtocol protocol) {      AvahiHwInterface *hw;      AvahiInterface *i; -     +      assert(m);      assert(idx >= 0);      assert(protocol != AVAHI_PROTO_UNSPEC); @@ -546,7 +546,7 @@ AvahiHwInterface* avahi_interface_monitor_get_hw_interface(AvahiInterfaceMonitor  AvahiInterfaceAddress* avahi_interface_monitor_get_address(AvahiInterfaceMonitor *m, AvahiInterface *i, const AvahiAddress *raddr) {      AvahiInterfaceAddress *ia; -     +      assert(m);      assert(i);      assert(raddr); @@ -564,7 +564,7 @@ void avahi_interface_send_packet_unicast(AvahiInterface *i, AvahiDnsPacket *p, c      if (!i->announcing)          return; -     +      assert(!a || a->proto == i->protocol);      if (i->protocol == AVAHI_PROTO_INET && i->monitor->server->fd_ipv4 >= 0) @@ -586,7 +586,7 @@ int avahi_interface_post_query(AvahiInterface *i, AvahiKey *key, int immediately      if (!i->announcing)          return 0; -     +      return avahi_query_scheduler_post(i->query_scheduler, key, immediately, ret_id);  } @@ -601,14 +601,14 @@ int avahi_interface_post_response(AvahiInterface *i, AvahiRecord *record, int fl      if (!i->announcing)          return 0; -     +      return avahi_response_scheduler_post(i->response_scheduler, record, flush_cache, querier, immediately);  }  int avahi_interface_post_probe(AvahiInterface *i, AvahiRecord *record, int immediately) {      assert(i);      assert(record); -     +      if (!i->announcing)          return 0; @@ -632,21 +632,42 @@ int avahi_dump_caches(AvahiInterfaceMonitor *m, AvahiDumpCallback callback, void      return 0;  } -int avahi_interface_is_relevant(AvahiInterface *i) { +static int avahi_interface_is_relevant_internal(AvahiInterface *i) {      AvahiInterfaceAddress *a; -     +      assert(i);      if (!i->hardware->flags_ok)          return 0; -     +      for (a = i->addresses; a; a = a->address_next)          if (avahi_interface_address_is_relevant(a))              return 1;      return 0;  } -     + +int avahi_interface_is_relevant(AvahiInterface *i) { +    AvahiStringList *l; +    assert(i); + +    for (l = i->monitor->server->config.deny_interfaces; l; l = l->next) +        if (strcasecmp((char*) l->text, i->hardware->name) == 0) +            return 0; + +    if (i->monitor->server->config.allow_interfaces) { + +        for (l = i->monitor->server->config.allow_interfaces; l; l = l->next) +            if (strcasecmp((char*) l->text, i->hardware->name) == 0) +                goto good; + +        return 0; +    } + +good: +    return avahi_interface_is_relevant_internal(i); +} +  int avahi_interface_address_is_relevant(AvahiInterfaceAddress *a) {      AvahiInterfaceAddress *b;      assert(a); @@ -655,12 +676,12 @@ int avahi_interface_address_is_relevant(AvahiInterfaceAddress *a) {      if (a->global_scope)          return 1;      else { -         +          /* Publish link local IP addresses if they are the only ones on the link */          for (b = a->interface->addresses; b; b = b->address_next) {              if (b == a)                  continue; -             +              if (b->global_scope)                  return 0;          } @@ -673,7 +694,7 @@ int avahi_interface_address_is_relevant(AvahiInterfaceAddress *a) {  int avahi_interface_match(AvahiInterface *i, AvahiIfIndex idx, AvahiProtocol protocol) {      assert(i); -     +      if (idx != AVAHI_IF_UNSPEC && idx != i->hardware->index)          return 0; @@ -686,14 +707,14 @@ int avahi_interface_match(AvahiInterface *i, AvahiIfIndex idx, AvahiProtocol pro  void avahi_interface_monitor_walk(AvahiInterfaceMonitor *m, AvahiIfIndex interface, AvahiProtocol protocol, AvahiInterfaceMonitorWalkCallback callback, void* userdata) {      assert(m);      assert(callback); -     +      if (interface != AVAHI_IF_UNSPEC) {          if (protocol != AVAHI_PROTO_UNSPEC) {              AvahiInterface *i; -             +              if ((i = avahi_interface_monitor_get_interface(m, interface, protocol)))                  callback(m, i, userdata); -             +          } else {              AvahiHwInterface *hw;              AvahiInterface *i; @@ -703,10 +724,10 @@ void avahi_interface_monitor_walk(AvahiInterfaceMonitor *m, AvahiIfIndex interfa                      if (avahi_interface_match(i, interface, protocol))                          callback(m, i, userdata);          } -         +      } else {          AvahiInterface *i; -         +          for (i = m->interfaces; i; i = i->interface_next)              if (avahi_interface_match(i, interface, protocol))                  callback(m, i, userdata); @@ -730,7 +751,7 @@ int avahi_address_is_local(AvahiInterfaceMonitor *m, const AvahiAddress *a) {  int avahi_interface_address_on_link(AvahiInterface *i, const AvahiAddress *a) {      AvahiInterfaceAddress *ia; -     +      assert(i);      assert(a); @@ -741,9 +762,9 @@ int avahi_interface_address_on_link(AvahiInterface *i, const AvahiAddress *a) {          if (a->proto == AVAHI_PROTO_INET) {              uint32_t m; -             +              m = ~(((uint32_t) -1) >> ia->prefix_len); -             +              if ((ntohl(a->data.ipv4.address) & m) == (ntohl(ia->address.data.ipv4.address) & m))                  return 1;          } else { @@ -752,13 +773,13 @@ int avahi_interface_address_on_link(AvahiInterface *i, const AvahiAddress *a) {              assert(a->proto == AVAHI_PROTO_INET6);              pl = ia->prefix_len; -             +              for (j = 0; j < 16; j++) {                  uint8_t m;                  if (pl == 0)                      return 1; -                 +                  if (pl >= 8) {                      m = 0xFF;                      pl -= 8; @@ -766,7 +787,7 @@ int avahi_interface_address_on_link(AvahiInterface *i, const AvahiAddress *a) {                      m = ~(0xFF >> pl);                      pl = 0;                  } -                 +                  if ((a->data.ipv6.address[j] & m) != (ia->address.data.ipv6.address[j] & m))                      break;              } @@ -779,7 +800,7 @@ int avahi_interface_address_on_link(AvahiInterface *i, const AvahiAddress *a) {  int avahi_interface_has_address(AvahiInterfaceMonitor *m, AvahiIfIndex iface, const AvahiAddress *a) {      AvahiInterface *i;      AvahiInterfaceAddress *j; -     +      assert(m);      assert(iface != AVAHI_IF_UNSPEC);      assert(a); @@ -809,7 +830,7 @@ AvahiIfIndex avahi_find_interface_for_address(AvahiInterfaceMonitor *m, const Av          if (i->protocol != a->proto)              continue; -         +          for (ai = i->addresses; ai; ai = ai->address_next)              if (avahi_address_cmp(a, &ai->address) == 0)                  return i->hardware->index; diff --git a/avahi-core/server.c b/avahi-core/server.c index 453db09..73ae1cb 100644 --- a/avahi-core/server.c +++ b/avahi-core/server.c @@ -2,17 +2,17 @@  /***    This file is part of avahi. -  +    avahi is free software; you can redistribute it and/or modify it    under the terms of the GNU Lesser General Public License as    published by the Free Software Foundation; either version 2.1 of the    License, or (at your option) any later version. -  +    avahi is distributed in the hope that it will be useful, but WITHOUT    ANY WARRANTY; without even the implied warranty of MERCHANTABILITY    or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General    Public License for more details. -  +    You should have received a copy of the GNU Lesser General Public    License along with avahi; if not, write to the Free Software    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 @@ -59,7 +59,7 @@ static void enum_aux_records(AvahiServer *s, AvahiInterface *i, const char *name      if (type == AVAHI_DNS_TYPE_ANY) {          AvahiEntry *e; -         +          for (e = s->entries; e; e = e->entries_next)              if (!e->dead &&                  avahi_entry_is_registered(s, e, i) && @@ -70,14 +70,14 @@ static void enum_aux_records(AvahiServer *s, AvahiInterface *i, const char *name      } else {          AvahiEntry *e;          AvahiKey *k; -         +          if (!(k = avahi_key_new(name, AVAHI_DNS_CLASS_IN, type)))              return; /** OOM */ -         +          for (e = avahi_hashmap_lookup(s->entries_by_key, k); e; e = e->by_key_next) -            if (!e->dead && avahi_entry_is_registered(s, e, i))  +            if (!e->dead && avahi_entry_is_registered(s, e, i))                  callback(s, e->record, e->flags & AVAHI_PUBLISH_UNIQUE, userdata); -         +          avahi_key_unref(k);      }  } @@ -89,7 +89,7 @@ void avahi_server_enumerate_aux_records(AvahiServer *s, AvahiInterface *i, Avahi      assert(callback);      /* Call the specified callback far all records referenced by the one specified in *r */ -     +      if (r->key->clazz == AVAHI_DNS_CLASS_IN) {          if (r->key->type == AVAHI_DNS_TYPE_PTR) {              enum_aux_records(s, i, r->data.ptr.name, AVAHI_DNS_TYPE_SRV, callback, userdata); @@ -121,7 +121,7 @@ void avahi_server_prepare_matching_responses(AvahiServer *s, AvahiInterface *i,          AvahiEntry *e;          /* Handle ANY query */ -         +          for (e = s->entries; e; e = e->entries_next)              if (!e->dead && avahi_key_pattern_match(k, e->record->key) && avahi_entry_is_registered(s, e, i))                  avahi_server_prepare_response(s, i, e, unicast_response, 0); @@ -130,7 +130,7 @@ void avahi_server_prepare_matching_responses(AvahiServer *s, AvahiInterface *i,          AvahiEntry *e;          /* Handle all other queries */ -         +          for (e = avahi_hashmap_lookup(s->entries_by_key, k); e; e = e->by_key_next)              if (!e->dead && avahi_entry_is_registered(s, e, i))                  avahi_server_prepare_response(s, i, e, unicast_response, 0); @@ -145,7 +145,7 @@ void avahi_server_prepare_matching_responses(AvahiServer *s, AvahiInterface *i,          if (!(cname_key = avahi_key_new(k->name, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_CNAME)))              return; -         +          avahi_server_prepare_matching_responses(s, i, cname_key, unicast_response);          avahi_key_unref(cname_key);      } @@ -160,11 +160,11 @@ static void withdraw_entry(AvahiServer *s, AvahiEntry *e) {      if (e->dead)          return; -     +      if (e->group) {          AvahiEntry *k; -         -        for (k = e->group->entries; k; k = k->by_group_next)  + +        for (k = e->group->entries; k; k = k->by_group_next)              if (!k->dead) {                  avahi_goodbye_entry(s, k, 0, 1);                  k->dead = 1; @@ -183,12 +183,12 @@ static void withdraw_entry(AvahiServer *s, AvahiEntry *e) {  static void withdraw_rrset(AvahiServer *s, AvahiKey *key) {      AvahiEntry *e; -     +      assert(s);      assert(key);      /* Withdraw an entry RRSset */ -     +      for (e = avahi_hashmap_lookup(s->entries_by_key, key); e; e = e->by_key_next)          withdraw_entry(s, e);  } @@ -196,25 +196,25 @@ static void withdraw_rrset(AvahiServer *s, AvahiKey *key) {  static void incoming_probe(AvahiServer *s, AvahiRecord *record, AvahiInterface *i) {      AvahiEntry *e, *n;      int ours = 0, won = 0, lost = 0; -     +      assert(s);      assert(record);      assert(i);      /* Handle incoming probes and check if they conflict our own probes */ -     +      for (e = avahi_hashmap_lookup(s->entries_by_key, record->key); e; e = n) {          int cmp;          n = e->by_key_next;          if (e->dead)              continue; -         +          if ((cmp = avahi_record_lexicographical_compare(e->record, record)) == 0) {              ours = 1;              break;          } else { -             +              if (avahi_entry_is_probing(s, e, i)) {                  if (cmp > 0)                      won = 1; @@ -226,14 +226,14 @@ static void incoming_probe(AvahiServer *s, AvahiRecord *record, AvahiInterface *      if (!ours) {          char *t = avahi_record_to_string(record); -         +          if (won)              avahi_log_debug("Received conflicting probe [%s]. Local host won.", t);          else if (lost) {              avahi_log_debug("Received conflicting probe [%s]. Local host lost. Withdrawing.", t);              withdraw_rrset(s, record->key);          } -         +          avahi_free(t);      }  } @@ -241,13 +241,13 @@ static void incoming_probe(AvahiServer *s, AvahiRecord *record, AvahiInterface *  static int handle_conflict(AvahiServer *s, AvahiInterface *i, AvahiRecord *record, int unique) {      int valid = 1, ours = 0, conflict = 0, withdraw_immediately = 0;      AvahiEntry *e, *n, *conflicting_entry = NULL; -     +      assert(s);      assert(i);      assert(record);      /* Check whether an incoming record conflicts with one of our own */ -     +      for (e = avahi_hashmap_lookup(s->entries_by_key, record->key); e; e = n) {          n = e->by_key_next; @@ -261,7 +261,7 @@ static int handle_conflict(AvahiServer *s, AvahiInterface *i, AvahiRecord *recor                  char *t;                  /* Refresh */ -                t = avahi_record_to_string(record);  +                t = avahi_record_to_string(record);                  avahi_log_debug("Received goodbye record for one of our records [%s]. Refreshing.", t);                  avahi_server_prepare_matching_responses(s, i, e->record->key, 0); @@ -273,36 +273,36 @@ static int handle_conflict(AvahiServer *s, AvahiInterface *i, AvahiRecord *recor              /* If the goodybe packet doesn't match one of our own RRs, we simply ignore it. */              continue;          } -         +          if (!(e->flags & AVAHI_PUBLISH_UNIQUE) && !unique)              continue;          /* Either our entry or the other is intended to be unique, so let's check */ -         +          if (avahi_record_equal_no_ttl(e->record, record)) {              ours = 1; /* We have an identical record, so this is no conflict */ -             +              /* Check wheter there is a TTL conflict */              if (record->ttl <= e->record->ttl/2 &&                  avahi_entry_is_registered(s, e, i)) {                  char *t;                  /* Refresh */ -                t = avahi_record_to_string(record);  -                 +                t = avahi_record_to_string(record); +                  avahi_log_debug("Received record with bad TTL [%s]. Refreshing.", t);                  avahi_server_prepare_matching_responses(s, i, e->record->key, 0);                  valid = 0; -                 +                  avahi_free(t);              } -                 +              /* There's no need to check the other entries of this RRset */              break;          } else { -             +              if (avahi_entry_is_registered(s, e, i)) { -                 +                  /* A conflict => we have to return to probe mode */                  conflict = 1;                  conflicting_entry = e; @@ -320,11 +320,11 @@ static int handle_conflict(AvahiServer *s, AvahiInterface *i, AvahiRecord *recor      if (!ours && conflict) {          char *t; -  +          valid = 0; -        t = avahi_record_to_string(record);  -  +        t = avahi_record_to_string(record); +          if (withdraw_immediately) {              avahi_log_debug("Received conflicting record [%s] with local record to be. Withdrawing.", t);              withdraw_rrset(s, record->key); @@ -349,7 +349,7 @@ static void append_aux_callback(AvahiServer *s, AvahiRecord *r, int flush_cache,      assert(s);      assert(r);      assert(unicast_response); -     +      avahi_record_list_push(s->record_list, r, flush_cache, *unicast_response, 1);  } @@ -372,11 +372,11 @@ void avahi_server_generate_response(AvahiServer *s, AvahiInterface *i, AvahiDnsP          if (!(reply = avahi_dns_packet_new_reply(p, 512 + AVAHI_DNS_PACKET_EXTRA_SIZE /* unicast DNS maximum packet size is 512 */ , 1, 1)))              return; /* OOM */ -         +          while ((r = avahi_record_list_next(s->record_list, NULL, NULL, NULL))) {              append_aux_records_to_list(s, i, r, 0); -             +              if (avahi_dns_packet_append_record(reply, r, 0, 10))                  avahi_dns_packet_inc_field(reply, AVAHI_DNS_FIELD_ANCOUNT);              else { @@ -402,7 +402,7 @@ void avahi_server_generate_response(AvahiServer *s, AvahiInterface *i, AvahiDnsP          immediately, because known answer suppression records might be          contained in later packets */          int tc = p && !!(avahi_dns_packet_get_field(p, AVAHI_DNS_FIELD_FLAGS) & AVAHI_DNS_FLAG_TC); -         +          while ((r = avahi_record_list_next(s->record_list, &flush_cache, &unicast_response, &auxiliary))) {              int im = immediately; @@ -411,7 +411,7 @@ void avahi_server_generate_response(AvahiServer *s, AvahiInterface *i, AvahiDnsP               * unique entry AND it is not in reply to a truncated               * packet AND it is not an auxiliary record AND all other               * responses for this record are unique too. */ -             +              if (flush_cache && !tc && !auxiliary && avahi_record_list_all_flush_cache(s->record_list))                  im = 1; @@ -422,21 +422,21 @@ void avahi_server_generate_response(AvahiServer *s, AvahiInterface *i, AvahiDnsP                   * case. Therefore we prepare such a response */                  append_aux_records_to_list(s, i, r, unicast_response); -                 +                  for (;;) { -                 +                      if (!reply) {                          assert(p);                          if (!(reply = avahi_dns_packet_new_reply(p, i->hardware->mtu, 0, 0)))                              break; /* OOM */                      } -                 +                      if (avahi_dns_packet_append_record(reply, r, flush_cache, 0)) {                          /* Appending this record succeeded, so incremeant                           * the specific header field, and return to the caller */ -                         +                          avahi_dns_packet_inc_field(reply, AVAHI_DNS_FIELD_ANCOUNT);                          break;                      } @@ -456,7 +456,7 @@ void avahi_server_generate_response(AvahiServer *s, AvahiInterface *i, AvahiDnsP                              /* Appending this record succeeded, so incremeant                               * the specific header field, and return to the caller */ -                             +                              avahi_dns_packet_inc_field(reply, AVAHI_DNS_FIELD_ANCOUNT);                              break; @@ -465,7 +465,7 @@ void avahi_server_generate_response(AvahiServer *s, AvahiInterface *i, AvahiDnsP                              /* We completely fucked up, there's                               * nothing we can do. The RR just doesn't                               * fit in. Let's ignore it. */ -                             +                              char *t;                              avahi_dns_packet_free(reply);                              reply = NULL; @@ -487,7 +487,7 @@ void avahi_server_generate_response(AvahiServer *s, AvahiInterface *i, AvahiDnsP          }          if (reply) { -            if (avahi_dns_packet_get_field(reply, AVAHI_DNS_FIELD_ANCOUNT) != 0)  +            if (avahi_dns_packet_get_field(reply, AVAHI_DNS_FIELD_ANCOUNT) != 0)                  avahi_interface_send_packet_unicast(i, reply, a, port);              avahi_dns_packet_free(reply);          } @@ -498,7 +498,7 @@ void avahi_server_generate_response(AvahiServer *s, AvahiInterface *i, AvahiDnsP  static void reflect_response(AvahiServer *s, AvahiInterface *i, AvahiRecord *r, int flush_cache) {      AvahiInterface *j; -     +      assert(s);      assert(i);      assert(r); @@ -525,7 +525,7 @@ static void* reflect_cache_walk_callback(AvahiCache *c, AvahiKey *pattern, Avahi  static void reflect_query(AvahiServer *s, AvahiInterface *i, AvahiKey *k) {      AvahiInterface *j; -     +      assert(s);      assert(i);      assert(k); @@ -547,7 +547,7 @@ static void reflect_query(AvahiServer *s, AvahiInterface *i, AvahiKey *k) {  static void reflect_probe(AvahiServer *s, AvahiInterface *i, AvahiRecord *r) {      AvahiInterface *j; -     +      assert(s);      assert(i);      assert(r); @@ -563,7 +563,7 @@ static void reflect_probe(AvahiServer *s, AvahiInterface *i, AvahiRecord *r) {  static void handle_query_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInterface *i, const AvahiAddress *a, uint16_t port, int legacy_unicast, int from_local_iface) {      size_t n;      int is_probe; -     +      assert(s);      assert(p);      assert(i); @@ -572,7 +572,7 @@ static void handle_query_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInterfac      assert(avahi_record_list_is_empty(s->record_list));      is_probe = avahi_dns_packet_get_field(p, AVAHI_DNS_FIELD_NSCOUNT) > 0; -     +      /* Handle the questions */      for (n = avahi_dns_packet_get_field(p, AVAHI_DNS_FIELD_QDCOUNT); n > 0; n --) {          AvahiKey *key; @@ -594,7 +594,7 @@ static void handle_query_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInterfac              /* Allow our own queries to be suppressed by incoming               * queries only when they do not include known answers */              avahi_query_scheduler_incoming(i->query_scheduler, key); -         +          avahi_server_prepare_matching_responses(s, i, key, unicast_response);          avahi_key_unref(key);      } @@ -605,35 +605,35 @@ static void handle_query_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInterfac          for (n = avahi_dns_packet_get_field(p, AVAHI_DNS_FIELD_ANCOUNT); n > 0; n --) {              AvahiRecord *record;              int unique = 0; -             +              if (!(record = avahi_dns_packet_consume_record(p, &unique))) {                  avahi_log_warn(__FILE__": Packet too short or invalid while reading known answer record. (Maybe a UTF-8 problem?)");                  goto fail;              } -             +              avahi_response_scheduler_suppress(i->response_scheduler, record, a);              avahi_record_list_drop(s->record_list, record);              avahi_cache_stop_poof(i->cache, record, a); -             +              avahi_record_unref(record);          } -         +          /* Probe record */          for (n = avahi_dns_packet_get_field(p, AVAHI_DNS_FIELD_NSCOUNT); n > 0; n --) {              AvahiRecord *record;              int unique = 0; -             +              if (!(record = avahi_dns_packet_consume_record(p, &unique))) {                  avahi_log_warn(__FILE__": Packet too short or invalid while reading probe record. (Maybe a UTF-8 problem?)");                  goto fail;              } -             +              if (!avahi_key_is_pattern(record->key)) {                  if (!from_local_iface)                      reflect_probe(s, i, record);                  incoming_probe(s, record, i);              } -             +              avahi_record_unref(record);          }      } @@ -642,14 +642,14 @@ static void handle_query_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInterfac          avahi_server_generate_response(s, i, p, a, port, legacy_unicast, is_probe);      return; -     +  fail:      avahi_record_list_flush(s->record_list);  }  static void handle_response_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInterface *i, const AvahiAddress *a, int from_local_iface) {      unsigned n; -     +      assert(s);      assert(p);      assert(i); @@ -660,7 +660,7 @@ static void handle_response_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInter          AvahiRecord *record;          int cache_flush = 0;  /*         char *txt; */ -         +          if (!(record = avahi_dns_packet_consume_record(p, &cache_flush))) {              avahi_log_warn(__FILE__": Packet too short or invalid while reading response record. (Maybe a UTF-8 problem?)");              break; @@ -675,7 +675,7 @@ static void handle_response_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInter                  avahi_response_scheduler_incoming(i->response_scheduler, record, cache_flush);              }          } -             +          avahi_record_unref(record);      } @@ -689,7 +689,7 @@ static void handle_response_packet(AvahiServer *s, AvahiDnsPacket *p, AvahiInter  static AvahiLegacyUnicastReflectSlot* allocate_slot(AvahiServer *s) {      unsigned n, idx = (unsigned) -1;      AvahiLegacyUnicastReflectSlot *slot; -     +      assert(s);      if (!s->legacy_unicast_reflect_slots) @@ -697,7 +697,7 @@ static AvahiLegacyUnicastReflectSlot* allocate_slot(AvahiServer *s) {      for (n = 0; n < AVAHI_LEGACY_UNICAST_REFLECT_SLOTS_MAX; n++, s->legacy_unicast_reflect_id++) {          idx = s->legacy_unicast_reflect_id % AVAHI_LEGACY_UNICAST_REFLECT_SLOTS_MAX; -         +          if (!s->legacy_unicast_reflect_slots[idx])              break;      } @@ -711,7 +711,7 @@ static AvahiLegacyUnicastReflectSlot* allocate_slot(AvahiServer *s) {      s->legacy_unicast_reflect_slots[idx] = slot;      slot->id = s->legacy_unicast_reflect_id++;      slot->server = s; -     +      return slot;  } @@ -726,7 +726,7 @@ static void deallocate_slot(AvahiServer *s, AvahiLegacyUnicastReflectSlot *slot)      assert(s->legacy_unicast_reflect_slots[idx] == slot);      avahi_time_event_free(slot->time_event); -     +      avahi_free(slot);      s->legacy_unicast_reflect_slots[idx] = NULL;  } @@ -748,12 +748,12 @@ static void free_slots(AvahiServer *s) {  static AvahiLegacyUnicastReflectSlot* find_slot(AvahiServer *s, uint16_t id) {      unsigned idx; -     +      assert(s);      if (!s->legacy_unicast_reflect_slots)          return NULL; -     +      idx = id % AVAHI_LEGACY_UNICAST_REFLECT_SLOTS_MAX;      if (!s->legacy_unicast_reflect_slots[idx] || s->legacy_unicast_reflect_slots[idx]->id != id) @@ -782,7 +782,7 @@ static void reflect_legacy_unicast_query_packet(AvahiServer *s, AvahiDnsPacket *      assert(a);      assert(port > 0);      assert(i->protocol == a->proto); -     +      if (!s->config.enable_reflector)          return; @@ -810,7 +810,7 @@ static void reflect_legacy_unicast_query_packet(AvahiServer *s, AvahiDnsPacket *      /* Patch the packet with our new locally generatet id */      avahi_dns_packet_set_field(p, AVAHI_DNS_FIELD_ID, slot->id); -     +      for (j = s->monitor->interfaces; j; j = j->interface_next)          if (j->announcing &&              j != i && @@ -833,14 +833,14 @@ static int originates_from_local_legacy_unicast_socket(AvahiServer *s, const Ava      if (!s->config.enable_reflector)          return 0; -     +      if (!avahi_address_is_local(s->monitor, address))          return 0; -     +      if (address->proto == AVAHI_PROTO_INET && s->fd_legacy_unicast_ipv4 >= 0) {          struct sockaddr_in lsa;          socklen_t l = sizeof(lsa); -         +          if (getsockname(s->fd_legacy_unicast_ipv4, (struct sockaddr*) &lsa, &l) != 0)              avahi_log_warn("getsockname(): %s", strerror(errno));          else @@ -884,7 +884,7 @@ static int originates_from_local_iface(AvahiServer *s, AvahiIfIndex iface, const  static void dispatch_packet(AvahiServer *s, AvahiDnsPacket *p, const AvahiAddress *src_address, uint16_t port, const AvahiAddress *dst_address, AvahiIfIndex iface, int ttl) {      AvahiInterface *i;      int from_local_iface = 0; -     +      assert(s);      assert(p);      assert(src_address); @@ -898,6 +898,12 @@ static void dispatch_packet(AvahiServer *s, AvahiDnsPacket *p, const AvahiAddres          return;      } +    if (port <= 0) { +        /* This fixes RHBZ #475394 */ +        avahi_log_warn("Received packet from invalid source port %u.", (unsigned) port); +        return; +    } +      if (avahi_address_is_ipv4_in_ipv6(src_address))          /* This is an IPv4 address encapsulated in IPv6, so let's ignore it. */          return; @@ -931,36 +937,40 @@ static void dispatch_packet(AvahiServer *s, AvahiDnsPacket *p, const AvahiAddres                  avahi_log_warn("Invalid legacy unicast query packet.");                  return;              } -         +              legacy_unicast = 1;          }          if (legacy_unicast)              reflect_legacy_unicast_query_packet(s, p, i, src_address, port); -         +          handle_query_packet(s, p, i, src_address, port, legacy_unicast, from_local_iface); -         +      } else { +        char t[AVAHI_ADDRESS_STR_MAX]; +          if (port != AVAHI_MDNS_PORT) { -            avahi_log_warn("Received response with invalid source port %u on interface '%s.%i'", port, i->hardware->name, i->protocol); +            avahi_log_warn("Received response from host %s with invalid source port %u on interface '%s.%i'", avahi_address_snprint(t, sizeof(t), src_address), port, i->hardware->name, i->protocol);              return;          }          if (ttl != 255 && s->config.check_response_ttl) { -            avahi_log_warn("Received response with invalid TTL %u on interface '%s.%i'.", ttl, i->hardware->name, i->protocol); +            avahi_log_warn("Received response from host %s with invalid TTL %u on interface '%s.%i'.", avahi_address_snprint(t, sizeof(t), src_address), ttl, i->hardware->name, i->protocol);              return;          }          if (!is_mdns_mcast_address(dst_address) &&              !avahi_interface_address_on_link(i, src_address)) { -            avahi_log_warn("Received non-local response on interface '%s.%i'.", i->hardware->name, i->protocol); + +            avahi_log_warn("Received non-local response from host %s on interface '%s.%i'.", avahi_address_snprint(t, sizeof(t), src_address), i->hardware->name, i->protocol);              return;          } -         +          if (avahi_dns_packet_get_field(p, AVAHI_DNS_FIELD_QDCOUNT) != 0 ||              avahi_dns_packet_get_field(p, AVAHI_DNS_FIELD_ANCOUNT) == 0 ||              avahi_dns_packet_get_field(p, AVAHI_DNS_FIELD_NSCOUNT) != 0) { -            avahi_log_warn("Invalid response packet."); + +            avahi_log_warn("Invalid response packet from host %s.", avahi_address_snprint(t, sizeof(t), src_address));              return;          } @@ -971,7 +981,7 @@ static void dispatch_packet(AvahiServer *s, AvahiDnsPacket *p, const AvahiAddres  static void dispatch_legacy_unicast_packet(AvahiServer *s, AvahiDnsPacket *p) {      AvahiInterface *j;      AvahiLegacyUnicastReflectSlot *slot; -     +      assert(s);      assert(p); @@ -1001,7 +1011,7 @@ static void dispatch_legacy_unicast_packet(AvahiServer *s, AvahiDnsPacket *p) {  static void cleanup_dead(AvahiServer *s) {      assert(s); -     +      avahi_cleanup_dead_entries(s);      avahi_browser_cleanup(s);  } @@ -1017,7 +1027,7 @@ static void mcast_socket_event(AvahiWatch *w, int fd, AvahiWatchEvent events, vo      assert(w);      assert(fd >= 0);      assert(events & AVAHI_WATCH_IN); -     +      if (fd == s->fd_ipv4) {          dest.proto = src.proto = AVAHI_PROTO_INET;          p = avahi_recv_dns_packet_ipv4(s->fd_ipv4, &src.data.ipv4, &port, &dest.data.ipv4, &iface, &ttl); @@ -1026,11 +1036,11 @@ static void mcast_socket_event(AvahiWatch *w, int fd, AvahiWatchEvent events, vo          dest.proto = src.proto = AVAHI_PROTO_INET6;          p = avahi_recv_dns_packet_ipv6(s->fd_ipv6, &src.data.ipv6, &port, &dest.data.ipv6, &iface, &ttl);      } -         +      if (p) { -        if (iface == AVAHI_IF_UNSPEC)  +        if (iface == AVAHI_IF_UNSPEC)              iface = avahi_find_interface_for_address(s->monitor, &dest); -         +          if (iface != AVAHI_IF_UNSPEC)              dispatch_packet(s, p, &src, port, &dest, iface, ttl);          else @@ -1049,7 +1059,7 @@ static void legacy_unicast_socket_event(AvahiWatch *w, int fd, AvahiWatchEvent e      assert(w);      assert(fd >= 0);      assert(events & AVAHI_WATCH_IN); -     +      if (fd == s->fd_legacy_unicast_ipv4)          p = avahi_recv_dns_packet_ipv4(s->fd_legacy_unicast_ipv4, NULL, NULL, NULL, NULL, NULL);      else { @@ -1070,11 +1080,11 @@ static void server_set_state(AvahiServer *s, AvahiServerState state) {      if (s->state == state)          return; -     +      s->state = state;      avahi_interface_monitor_update_rrs(s->monitor, 0); -     +      if (s->callback)          s->callback(s, state, s->userdata);  } @@ -1094,7 +1104,7 @@ static void withdraw_host_rrs(AvahiServer *s) {  void avahi_server_decrease_host_rr_pending(AvahiServer *s) {      assert(s); -     +      assert(s->n_host_rr_pending > 0);      if (--s->n_host_rr_pending == 0) @@ -1108,12 +1118,12 @@ void avahi_host_rr_entry_group_callback(AvahiServer *s, AvahiSEntryGroup *g, Ava      if (state == AVAHI_ENTRY_GROUP_REGISTERING &&          s->state == AVAHI_SERVER_REGISTERING)          s->n_host_rr_pending ++; -     +      else if (state == AVAHI_ENTRY_GROUP_COLLISION &&          (s->state == AVAHI_SERVER_REGISTERING || s->state == AVAHI_SERVER_RUNNING)) {          withdraw_host_rrs(s);          server_set_state(s, AVAHI_SERVER_COLLISION); -         +      } else if (state == AVAHI_ENTRY_GROUP_ESTABLISHED &&                 s->state == AVAHI_SERVER_REGISTERING)          avahi_server_decrease_host_rr_pending(s); @@ -1122,9 +1132,9 @@ void avahi_host_rr_entry_group_callback(AvahiServer *s, AvahiSEntryGroup *g, Ava  static void register_hinfo(AvahiServer *s) {      struct utsname utsname;      AvahiRecord *r; -     +      assert(s); -     +      if (!s->config.publish_hinfo)          return; @@ -1137,19 +1147,19 @@ static void register_hinfo(AvahiServer *s) {          avahi_log_warn("Failed to create HINFO entry group: %s", avahi_strerror(s->error));          return;      } -     +      /* Fill in HINFO rr */      if ((r = avahi_record_new_full(s->host_name_fqdn, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_HINFO, AVAHI_DEFAULT_TTL_HOST_NAME))) {          if (uname(&utsname) < 0)              avahi_log_warn("uname() failed: %s\n", avahi_strerror(errno));          else { -             +              r->data.hinfo.cpu = avahi_strdup(avahi_strup(utsname.machine));              r->data.hinfo.os = avahi_strdup(avahi_strup(utsname.sysname)); -             +              avahi_log_info("Registering HINFO record with values '%s'/'%s'.", r->data.hinfo.cpu, r->data.hinfo.os); -             +              if (avahi_server_add(s, s->hinfo_entry_group, AVAHI_IF_UNSPEC, AVAHI_PROTO_UNSPEC, AVAHI_PUBLISH_UNIQUE, r) < 0) {                  avahi_log_warn("Failed to add HINFO RR: %s", avahi_strerror(s->error));                  return; @@ -1167,7 +1177,7 @@ static void register_hinfo(AvahiServer *s) {  static void register_localhost(AvahiServer *s) {      AvahiAddress a;      assert(s); -     +      /* Add localhost entries */      avahi_address_parse("127.0.0.1", AVAHI_PROTO_INET, &a);      avahi_server_add_address(s, NULL, AVAHI_IF_UNSPEC, AVAHI_PROTO_UNSPEC, AVAHI_PUBLISH_NO_PROBE|AVAHI_PUBLISH_NO_ANNOUNCE, "localhost", &a); @@ -1194,7 +1204,7 @@ static void register_browse_domain(AvahiServer *s) {          avahi_log_warn("Failed to create browse domain entry group: %s", avahi_strerror(s->error));          return;      } -     +      if (avahi_server_add_ptr(s, s->browse_domain_entry_group, AVAHI_IF_UNSPEC, AVAHI_PROTO_UNSPEC, 0, AVAHI_DEFAULT_TTL, "b._dns-sd._udp.local", s->domain_name) < 0) {          avahi_log_warn("Failed to add browse domain RR: %s", avahi_strerror(s->error));          return; @@ -1215,14 +1225,14 @@ static void register_stuff(AvahiServer *s) {      avahi_interface_monitor_update_rrs(s->monitor, 0);      s->n_host_rr_pending --; -     +      if (s->n_host_rr_pending == 0)          server_set_state(s, AVAHI_SERVER_RUNNING);  }  static void update_fqdn(AvahiServer *s) {      char *n; -     +      assert(s);      assert(s->host_name);      assert(s->domain_name); @@ -1237,7 +1247,7 @@ static void update_fqdn(AvahiServer *s) {  int avahi_server_set_host_name(AvahiServer *s, const char *host_name) {      char *hn = NULL;      assert(s); -     +      AVAHI_CHECK_VALIDITY(s, !host_name || avahi_is_valid_host_name(host_name), AVAHI_ERR_INVALID_HOST_NAME);      if (!host_name) { @@ -1250,12 +1260,12 @@ int avahi_server_set_host_name(AvahiServer *s, const char *host_name) {          avahi_free(hn);          return avahi_server_set_errno(s, AVAHI_ERR_NO_CHANGE);      } -     +      withdraw_host_rrs(s);      avahi_free(s->host_name);      s->host_name = hn ? hn : avahi_strdup(host_name); -     +      update_fqdn(s);      register_stuff(s); @@ -1272,7 +1282,7 @@ int avahi_server_set_domain_name(AvahiServer *s, const char *domain_name) {          dn = avahi_strdup("local");          domain_name = dn;      } -     +      if (avahi_domain_equal(s->domain_name, domain_name)) {          avahi_free(dn);          return avahi_server_set_errno(s, AVAHI_ERR_NO_CHANGE); @@ -1297,10 +1307,10 @@ static int valid_server_config(const AvahiServerConfig *sc) {      if (sc->n_wide_area_servers > AVAHI_WIDE_AREA_SERVERS_MAX)          return AVAHI_ERR_INVALID_CONFIG; -     +      if (sc->host_name && !avahi_is_valid_host_name(sc->host_name))          return AVAHI_ERR_INVALID_HOST_NAME; -     +      if (sc->domain_name && !avahi_is_valid_domain_name(sc->domain_name))          return AVAHI_ERR_INVALID_DOMAIN_NAME; @@ -1313,10 +1323,10 @@ static int valid_server_config(const AvahiServerConfig *sc) {  static int setup_sockets(AvahiServer *s) {      assert(s); -     +      s->fd_ipv4 = s->config.use_ipv4 ? avahi_open_socket_ipv4(s->config.disallow_other_stacks) : -1;      s->fd_ipv6 = s->config.use_ipv6 ? avahi_open_socket_ipv6(s->config.disallow_other_stacks) : -1; -     +      if (s->fd_ipv6 < 0 && s->fd_ipv4 < 0)          return AVAHI_ERR_NO_NETWORK; @@ -1327,35 +1337,35 @@ static int setup_sockets(AvahiServer *s) {      s->fd_legacy_unicast_ipv4 = s->fd_ipv4 >= 0 && s->config.enable_reflector ? avahi_open_unicast_socket_ipv4() : -1;      s->fd_legacy_unicast_ipv6 = s->fd_ipv6 >= 0 && s->config.enable_reflector ? avahi_open_unicast_socket_ipv6() : -1; -     +      s->watch_ipv4 =          s->watch_ipv6 =          s->watch_legacy_unicast_ipv4 =          s->watch_legacy_unicast_ipv6 = NULL; -     +      if (s->fd_ipv4 >= 0)          s->watch_ipv4 = s->poll_api->watch_new(s->poll_api, s->fd_ipv4, AVAHI_WATCH_IN, mcast_socket_event, s);      if (s->fd_ipv6 >= 0)          s->watch_ipv6 = s->poll_api->watch_new(s->poll_api, s->fd_ipv6, AVAHI_WATCH_IN, mcast_socket_event, s); -     +      if (s->fd_legacy_unicast_ipv4 >= 0)          s->watch_legacy_unicast_ipv4 = s->poll_api->watch_new(s->poll_api, s->fd_legacy_unicast_ipv4, AVAHI_WATCH_IN, legacy_unicast_socket_event, s);      if (s->fd_legacy_unicast_ipv6 >= 0)          s->watch_legacy_unicast_ipv6 = s->poll_api->watch_new(s->poll_api, s->fd_legacy_unicast_ipv6, AVAHI_WATCH_IN, legacy_unicast_socket_event, s); -             +      return 0;  }  AvahiServer *avahi_server_new(const AvahiPoll *poll_api, const AvahiServerConfig *sc, AvahiServerCallback callback, void* userdata, int *error) {      AvahiServer *s;      int e; -     +      if (sc && (e = valid_server_config(sc)) < 0) {          if (error)              *error = e;          return NULL;      } -     +      if (!(s = avahi_new(AvahiServer, 1))) {          if (error)              *error = AVAHI_ERR_NO_MEMORY; @@ -1376,10 +1386,10 @@ AvahiServer *avahi_server_new(const AvahiPoll *poll_api, const AvahiServerConfig          avahi_server_config_free(&s->config);          avahi_free(s); -         +          return NULL;      } -     +      s->n_host_rr_pending = 0;      s->need_entry_cleanup = 0;      s->need_group_cleanup = 0; @@ -1412,7 +1422,7 @@ AvahiServer *avahi_server_new(const AvahiPoll *poll_api, const AvahiServerConfig      s->legacy_unicast_reflect_id = 0;      s->record_list = avahi_record_list_new(); -     +      /* Get host name */      s->host_name = s->config.host_name ? avahi_normalize_name_strdup(s->config.host_name) : avahi_get_host_name_strdup();      s->host_name[strcspn(s->host_name, ".")] = 0; @@ -1431,13 +1441,13 @@ AvahiServer *avahi_server_new(const AvahiPoll *poll_api, const AvahiServerConfig          s->wide_area_lookup_engine = NULL;      s->multicast_lookup_engine = avahi_multicast_lookup_engine_new(s); -     +      s->monitor = avahi_interface_monitor_new(s);      avahi_interface_monitor_sync(s->monitor);      register_localhost(s);      register_stuff(s); -     +      return s;  } @@ -1462,7 +1472,7 @@ void avahi_server_free(AvahiServer* s) {          avahi_s_service_resolver_free(s->service_resolvers);      while (s->record_browsers)          avahi_s_record_browser_destroy(s->record_browsers); -     +      /* Remove all locally rgeistered stuff */      while(s->entries) @@ -1484,33 +1494,33 @@ void avahi_server_free(AvahiServer* s) {      avahi_multicast_lookup_engine_free(s->multicast_lookup_engine);      avahi_time_event_queue_free(s->time_event_queue); -     +      /* Free watches */ -     +      if (s->watch_ipv4)          s->poll_api->watch_free(s->watch_ipv4);      if (s->watch_ipv6)          s->poll_api->watch_free(s->watch_ipv6); -     +      if (s->watch_legacy_unicast_ipv4)          s->poll_api->watch_free(s->watch_legacy_unicast_ipv4);      if (s->watch_legacy_unicast_ipv6)          s->poll_api->watch_free(s->watch_legacy_unicast_ipv6);      /* Free sockets */ -     +      if (s->fd_ipv4 >= 0)          close(s->fd_ipv4);      if (s->fd_ipv6 >= 0)          close(s->fd_ipv6); -     +      if (s->fd_legacy_unicast_ipv4 >= 0)          close(s->fd_legacy_unicast_ipv4);      if (s->fd_legacy_unicast_ipv6 >= 0)          close(s->fd_legacy_unicast_ipv6); -     +      /* Free other stuff */ -     +      avahi_free(s->host_name);      avahi_free(s->domain_name);      avahi_free(s->host_name_fqdn); @@ -1562,6 +1572,8 @@ AvahiServerConfig* avahi_server_config_init(AvahiServerConfig *c) {      memset(c, 0, sizeof(AvahiServerConfig));      c->use_ipv6 = 1;      c->use_ipv4 = 1; +    c->allow_interfaces = NULL; +    c->deny_interfaces = NULL;      c->host_name = NULL;      c->domain_name = NULL;      c->check_response_ttl = 0; @@ -1581,7 +1593,7 @@ AvahiServerConfig* avahi_server_config_init(AvahiServerConfig *c) {      c->allow_point_to_point = 0;      c->publish_aaaa_on_ipv4 = 1;      c->publish_a_on_ipv6 = 0; -     +      return c;  } @@ -1591,11 +1603,13 @@ void avahi_server_config_free(AvahiServerConfig *c) {      avahi_free(c->host_name);      avahi_free(c->domain_name);      avahi_string_list_free(c->browse_domains); +    avahi_string_list_free(c->allow_interfaces); +    avahi_string_list_free(c->deny_interfaces);  }  AvahiServerConfig* avahi_server_config_copy(AvahiServerConfig *ret, const AvahiServerConfig *c) {      char *d = NULL, *h = NULL; -    AvahiStringList *l = NULL; +    AvahiStringList *browse = NULL, *allow = NULL, *deny = NULL;      assert(ret);      assert(c); @@ -1609,23 +1623,40 @@ AvahiServerConfig* avahi_server_config_copy(AvahiServerConfig *ret, const AvahiS              return NULL;          } -    if (!(l = avahi_string_list_copy(c->browse_domains)) && c->browse_domains) { +    if (!(browse = avahi_string_list_copy(c->browse_domains)) && c->browse_domains) { +        avahi_free(h); +        avahi_free(d); +        return NULL; +    } + +    if (!(allow = avahi_string_list_copy(c->allow_interfaces)) && c->allow_interfaces) { +        avahi_string_list_free(browse); +        avahi_free(h); +        avahi_free(d); +        return NULL; +    } + +    if (!(deny = avahi_string_list_copy(c->deny_interfaces)) && c->deny_interfaces) { +        avahi_string_list_free(allow); +        avahi_string_list_free(browse);          avahi_free(h);          avahi_free(d);          return NULL;      } -     +      *ret = *c;      ret->host_name = h;      ret->domain_name = d; -    ret->browse_domains = l; +    ret->browse_domains = browse; +    ret->allow_interfaces = allow; +    ret->deny_interfaces = deny;      return ret;  }  int avahi_server_errno(AvahiServer *s) {      assert(s); -     +      return s->error;  } @@ -1644,7 +1675,7 @@ uint32_t avahi_server_get_local_service_cookie(AvahiServer *s) {  static AvahiEntry *find_entry(AvahiServer *s, AvahiIfIndex interface, AvahiProtocol protocol, AvahiKey *key) {      AvahiEntry *e; -     +      assert(s);      assert(key); @@ -1664,7 +1695,7 @@ int avahi_server_get_group_of_service(AvahiServer *s, AvahiIfIndex interface, Av      AvahiEntry *e;      int ret;      char n[AVAHI_DOMAIN_NAME_MAX]; -     +      assert(s);      assert(name);      assert(type); @@ -1678,7 +1709,7 @@ int avahi_server_get_group_of_service(AvahiServer *s, AvahiIfIndex interface, Av      if ((ret = avahi_service_name_join(n, sizeof(n), name, type, domain) < 0))          return avahi_server_set_errno(s, ret); -         +      if (!(key = avahi_key_new(n, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_SRV)))          return avahi_server_set_errno(s, AVAHI_ERR_NO_MEMORY); @@ -1702,7 +1733,7 @@ int avahi_server_is_service_local(AvahiServer *s, AvahiIfIndex interface, AvahiP      if (!s->host_name_fqdn)          return 0; -     +      if (!(key = avahi_key_new(name, AVAHI_DNS_CLASS_IN, AVAHI_DNS_TYPE_SRV)))          return 0; @@ -1711,7 +1742,7 @@ int avahi_server_is_service_local(AvahiServer *s, AvahiIfIndex interface, AvahiP      if (!e)          return 0; -     +      return avahi_domain_equal(s->host_name_fqdn, e->record->data.srv.name);  } @@ -1720,7 +1751,7 @@ int avahi_server_is_record_local(AvahiServer *s, AvahiIfIndex interface, AvahiPr      assert(s);      assert(record); -     +      for (e = avahi_hashmap_lookup(s->entries_by_key, record->key); e; e = e->by_key_next)          if ((e->interface == interface || e->interface <= 0 || interface <= 0) && @@ -1752,13 +1783,13 @@ const AvahiServerConfig* avahi_server_get_config(AvahiServer *s) {  /** Set the browsing domains */  int avahi_server_set_browse_domains(AvahiServer *s, AvahiStringList *domains) {      AvahiStringList *l; -     +      assert(s);      for (l = s->config.browse_domains; l; l = l->next)          if (!avahi_is_valid_domain_name((char*) l->text))              return avahi_server_set_errno(s, AVAHI_ERR_INVALID_DOMAIN_NAME); -     +      avahi_string_list_free(s->config.browse_domains);      s->config.browse_domains = avahi_string_list_copy(domains);  | 
