From a1ac214c97e81fefc4393fdfea0e5c9041f75bdd Mon Sep 17 00:00:00 2001 From: Johan Hedberg Date: Sun, 19 Oct 2008 19:54:48 +0300 Subject: Remove OPEN state change from avdtp_open_cmd Some time back the INT role OPEN transition was moved from receiving the OPEN response to actually having the stream L2CAP channel ready. Unfortunatly this patch forgot to change the ACP case so the code has so far attempted a double ->OPEN transition. According to the AVDTP spec the transition should happen before the stream L2CAP transport but this doesn't really make sense since several places want to have the stream fd ready when we go to the OPEN state. Therefore, this patch removes the ACP role OPEN transition from receiving the OPEN command and lets the state change be in having the stream L2CAP transport established. --- audio/avdtp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/audio/avdtp.c b/audio/avdtp.c index affc7fe7..361c5eee 100644 --- a/audio/avdtp.c +++ b/audio/avdtp.c @@ -1171,7 +1171,6 @@ static gboolean avdtp_open_cmd(struct avdtp *session, struct seid_req *req, stream->open_acp = TRUE; session->pending_open = stream; - avdtp_sep_set_state(session, sep, AVDTP_STATE_OPEN); stream->timer = g_timeout_add(REQ_TIMEOUT, stream_open_timeout, stream); -- cgit