From 6fc53eb13073722f6f44d0af869c7ff1eb3f206e Mon Sep 17 00:00:00 2001 From: Havoc Pennington Date: Fri, 31 Jan 2003 00:56:01 +0000 Subject: 2003-01-30 Havoc Pennington * dbus/dbus-server.c (dbus_server_listen): @todo about how we need a better way to report errors here. e.g. "unix address lacks path" or something. also "no such file" when the path doesn't exist, etc. * dbus/dbus-address.c (dbus_address_entries_free): add @todo about leaking list nodes (dbus_parse_address): add @todo about documenting address format, and allowing , and ; to be escaped --- dbus/dbus-server.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'dbus/dbus-server.c') diff --git a/dbus/dbus-server.c b/dbus/dbus-server.c index 51774318..028144f5 100644 --- a/dbus/dbus-server.c +++ b/dbus/dbus-server.c @@ -191,6 +191,9 @@ _dbus_server_remove_timeout (DBusServer *server, * dbus_server_set_watch_functions() should be called * immediately to render the server fully functional. * + * @todo error messages on bad address could really be better. + * DBusResultCode is a bit limiting here. + * * @param address the address of this server. * @param result location to store rationale for failure. * @returns a new DBusServer, or #NULL on failure. @@ -235,9 +238,10 @@ dbus_server_listen (const char *address, server = _dbus_server_debug_new (name, result); if (server) - break; + break; } - else goto bad_address; + else + goto bad_address; } dbus_address_entries_free (entries); -- cgit