From b753979d860b22e27c57fda7b190295908147e50 Mon Sep 17 00:00:00 2001 From: Tim-Philipp Müller Date: Tue, 19 Jun 2007 16:40:40 +0000 Subject: tests/check/: Add GST_OPTION_CFLAGS to CFLAGS when building unit tests, so the error flags are included and it errors... Original commit message from CVS: * tests/check/Makefile.am: * tests/check/elements/audiopanorama.c: (GST_START_TEST): * tests/check/elements/videocrop.c: (GST_START_TEST): * tests/check/elements/videofilter.c: * tests/check/elements/wavpackdec.c: (GST_START_TEST): * tests/check/elements/wavpackparse.c: (GST_START_TEST): Add GST_OPTION_CFLAGS to CFLAGS when building unit tests, so the error flags are included and it errors out on compiler warnings for CVS builds; remove unused variables in various unit tests. --- ChangeLog | 12 ++++++++++++ tests/check/Makefile.am | 2 +- tests/check/elements/audiopanorama.c | 2 +- tests/check/elements/videocrop.c | 2 -- tests/check/elements/videofilter.c | 2 +- tests/check/elements/wavpackdec.c | 4 ++-- tests/check/elements/wavpackparse.c | 2 -- 7 files changed, 17 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5d0bd94a..dd1e9f77 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2007-06-19 Tim-Philipp Müller + + * tests/check/Makefile.am: + * tests/check/elements/audiopanorama.c: (GST_START_TEST): + * tests/check/elements/videocrop.c: (GST_START_TEST): + * tests/check/elements/videofilter.c: + * tests/check/elements/wavpackdec.c: (GST_START_TEST): + * tests/check/elements/wavpackparse.c: (GST_START_TEST): + Add GST_OPTION_CFLAGS to CFLAGS when building unit tests, so the + error flags are included and it errors out on compiler warnings + for CVS builds; remove unused variables in various unit tests. + 2007-06-19 Wim Taymans * gst/rtsp/rtspconnection.c: (rtsp_connection_connect), diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am index 195f0373..83fa465b 100644 --- a/tests/check/Makefile.am +++ b/tests/check/Makefile.am @@ -77,7 +77,7 @@ TESTS = $(check_PROGRAMS) noinst_PROGRAMS = \ elements/autodetect -AM_CFLAGS = $(GST_OBJ_CFLAGS) $(GST_CHECK_CFLAGS) $(CHECK_CFLAGS) +AM_CFLAGS = $(GST_OBJ_CFLAGS) $(GST_CHECK_CFLAGS) $(CHECK_CFLAGS) $(GST_OPTION_CFLAGS) LDADD = $(GST_OBJ_LIBS) $(GST_CHECK_LIBS) $(CHECK_LIBS) # valgrind testing diff --git a/tests/check/elements/audiopanorama.c b/tests/check/elements/audiopanorama.c index b19adbec..2307ac4a 100644 --- a/tests/check/elements/audiopanorama.c +++ b/tests/check/elements/audiopanorama.c @@ -620,7 +620,7 @@ GST_END_TEST; GST_START_TEST (test_wrong_caps) { GstElement *panorama; - GstBuffer *inbuffer, *outbuffer; + GstBuffer *inbuffer; gint16 in[2] = { 16384, -256 }; GstBus *bus; GstMessage *message; diff --git a/tests/check/elements/videocrop.c b/tests/check/elements/videocrop.c index 25cc00a9..8ac17d45 100644 --- a/tests/check/elements/videocrop.c +++ b/tests/check/elements/videocrop.c @@ -74,7 +74,6 @@ GST_START_TEST (test_unit_sizes) GstBaseTransformClass *csp_klass, *vcrop_klass; GstElement *videocrop, *csp; GList *caps_list, *l; - gint i; videocrop = gst_element_factory_make ("videocrop", "videocrop"); fail_unless (videocrop != NULL, "Failed to create videocrop element"); @@ -111,7 +110,6 @@ GST_START_TEST (test_unit_sizes) for (i = 0; i < G_N_ELEMENTS (sizes_to_try); ++i) { gchar *caps_str; - guint32 format = 0; guint csp_size = 0; guint vc_size = 0; diff --git a/tests/check/elements/videofilter.c b/tests/check/elements/videofilter.c index d22d75bc..0d236e40 100644 --- a/tests/check/elements/videofilter.c +++ b/tests/check/elements/videofilter.c @@ -79,7 +79,7 @@ cleanup_filter (GstElement * filter) gst_check_teardown_element (filter); } - +static void check_filter (const gchar * name, gint num_buffers, const gchar * prop, ...) { GstElement *filter; diff --git a/tests/check/elements/wavpackdec.c b/tests/check/elements/wavpackdec.c index 812944cf..5a8cb87e 100644 --- a/tests/check/elements/wavpackdec.c +++ b/tests/check/elements/wavpackdec.c @@ -148,7 +148,7 @@ GST_END_TEST; GST_START_TEST (test_decode_frame_with_broken_header) { GstElement *wavpackdec; - GstBuffer *inbuffer, *outbuffer; + GstBuffer *inbuffer; GstBus *bus; GstMessage *message; @@ -187,7 +187,7 @@ GST_END_TEST; GST_START_TEST (test_decode_frame_with_incomplete_frame) { GstElement *wavpackdec; - GstBuffer *inbuffer, *outbuffer; + GstBuffer *inbuffer; GstBus *bus; GstMessage *message; diff --git a/tests/check/elements/wavpackparse.c b/tests/check/elements/wavpackparse.c index 7a3b8cc1..4222aeb9 100644 --- a/tests/check/elements/wavpackparse.c +++ b/tests/check/elements/wavpackparse.c @@ -214,8 +214,6 @@ GST_START_TEST (test_parsing_invalid_first_header) { GstBuffer *inbuffer, *outbuffer; int i, num_buffers; - GstFormat format = GST_FORMAT_DEFAULT; - gint64 pos; setup_wavpackparse (); -- cgit