From 009c9750ea535fca5fea1df3fbaf7aa691e962e6 Mon Sep 17 00:00:00 2001 From: Tim-Philipp Müller Date: Tue, 6 Mar 2007 23:19:30 +0000 Subject: gst/id3demux/gstid3demux.c: Don't leak caps: make gst_id3demux_add_srcpad() not take ownership of the caps passed to ... Original commit message from CVS: * gst/id3demux/gstid3demux.c: (gst_id3demux_add_srcpad), (gst_id3demux_sink_activate): Don't leak caps: make gst_id3demux_add_srcpad() not take ownership of the caps passed to it (previouslly one code path assumes it takes ownership while another one assumes it doesn't). * configure.ac: * tests/files/Makefile.am: * tests/files/id3-407349-1.tag: * tests/files/id3-407349-2.tag: Add directory where data for unit tests can be stored. * tests/Makefile.am: * tests/check/Makefile.am: * tests/check/elements/.cvsignore: * tests/check/elements/id3demux.c: (pad_added_cb), (error_cb), (read_tags_from_file), (run_check_for_file), (check_date_1977_06_23), (GST_START_TEST), (id3demux_suite): Add unit test for id3demux, and in particular for bug #407349. Only testing pull-mode for now; push mode doesn't work yet because the test files are smaller than ID3_TYPE_FIND_MIN_SIZE. --- ChangeLog | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 2ef1667d..69e141e2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,27 @@ +2007-03-06 Tim-Philipp Müller + + * gst/id3demux/gstid3demux.c: (gst_id3demux_add_srcpad), + (gst_id3demux_sink_activate): + Don't leak caps: make gst_id3demux_add_srcpad() not take ownership of the + caps passed to it (previouslly one code path assumes it takes ownership + while another one assumes it doesn't). + + * configure.ac: + * tests/files/Makefile.am: + * tests/files/id3-407349-1.tag: + * tests/files/id3-407349-2.tag: + Add directory where data for unit tests can be stored. + + * tests/Makefile.am: + * tests/check/Makefile.am: + * tests/check/elements/.cvsignore: + * tests/check/elements/id3demux.c: (pad_added_cb), (error_cb), + (read_tags_from_file), (run_check_for_file), + (check_date_1977_06_23), (GST_START_TEST), (id3demux_suite): + Add unit test for id3demux, and in particular for bug #407349. Only + testing pull-mode for now; push mode doesn't work yet because the test + files are smaller than ID3_TYPE_FIND_MIN_SIZE. + 2007-03-06 Tim-Philipp Müller * tests/check/Makefile.am: -- cgit