From 89bbfdc3683c00f14cf7142cd19faadaf2ccc1c8 Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Sat, 6 Mar 2004 20:56:27 +0000 Subject: Fix several misuse of gst_buffer_merge (it doesn't take ownership of any buffer), should fix some leaks. I hope I did... Original commit message from CVS: 2004-03-06 Christophe Fergeau * ext/faac/gstfaac.c: (gst_faac_chain): * ext/flac/gstflactag.c: (gst_flac_tag_chain): * ext/libpng/gstpngenc.c: (user_write_data): * ext/mikmod/gstmikmod.c: (gst_mikmod_loop): * gst/ac3parse/gstac3parse.c: (gst_ac3parse_chain): * gst/mpeg2sub/gstmpeg2subt.c: (gst_mpeg2subt_chain_subtitle): * gst/mpegstream/gstrfc2250enc.c: (gst_rfc2250_enc_add_slice): Fix several misuse of gst_buffer_merge (it doesn't take ownership of any buffer), should fix some leaks. I hope I didn't unref buffers that shouldn't be... --- ext/mikmod/gstmikmod.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'ext/mikmod/gstmikmod.c') diff --git a/ext/mikmod/gstmikmod.c b/ext/mikmod/gstmikmod.c index c777ef46..cec788d5 100644 --- a/ext/mikmod/gstmikmod.c +++ b/ext/mikmod/gstmikmod.c @@ -298,8 +298,11 @@ gst_mikmod_loop (GstElement *element) else { if ( mikmod->Buffer ) { - mikmod->Buffer = gst_buffer_merge( mikmod->Buffer, buffer_in ); - gst_buffer_unref( buffer_in ); + GstBuffer *merge; + merge = gst_buffer_merge( mikmod->Buffer, buffer_in ); + gst_buffer_unref( buffer_in ); + gst_buffer_unref( mikmod->Buffer ); + mikmod->Buffer = merge; } else mikmod->Buffer = buffer_in; -- cgit