From c4b1e8e4aedc9971c1352a85ce2d1cc7da775c8d Mon Sep 17 00:00:00 2001 From: Tim-Philipp Müller Date: Sun, 28 May 2006 10:39:00 +0000 Subject: ext/taglib/gstid3v2mux.cc: Handle writing of track-count or album-volume-count without track-number or albume-volume... Original commit message from CVS: * ext/taglib/gstid3v2mux.cc: Handle writing of track-count or album-volume-count without track-number or albume-volume-number (in this case the number will just be set to 0). * tests/check/elements/id3v2mux.c: (test_taglib_id3mux_check_tags): It would be nice if we actually checked the values received for track/album-volume number/count in _check_tags(), rather than setting them again ... --- ext/taglib/gstid3v2mux.cc | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) (limited to 'ext/taglib') diff --git a/ext/taglib/gstid3v2mux.cc b/ext/taglib/gstid3v2mux.cc index e77cb749..6427b82c 100644 --- a/ext/taglib/gstid3v2mux.cc +++ b/ext/taglib/gstid3v2mux.cc @@ -230,6 +230,23 @@ add_one_tag (const GstTagList * list, const gchar * tag, gpointer user_data) id3v2tag->setTrack (track_number); } } + } else if (strcmp (tag, GST_TAG_TRACK_COUNT) == 0) { + guint n; + + if (gst_tag_list_get_uint_index (list, GST_TAG_TRACK_NUMBER, 0, &n)) { + GST_DEBUG ("track-count handled with track-number, skipping"); + } else if (gst_tag_list_get_uint_index (list, GST_TAG_TRACK_COUNT, 0, &n)) { + ID3v2::TextIdentificationFrame * frame; + gchar *tag_str; + + frame = new ID3v2::TextIdentificationFrame ("TRCK", String::UTF8); + tag_str = g_strdup_printf ("0/%u", n); + GST_DEBUG ("Setting track number/count to %s", tag_str); + + id3v2tag->addFrame (frame); + frame->setText (tag_str); + g_free (tag_str); + } } else if (strcmp (tag, GST_TAG_ALBUM_VOLUME_NUMBER) == 0) { guint volume_number; @@ -252,6 +269,24 @@ add_one_tag (const GstTagList * list, const gchar * tag, gpointer user_data) GST_DEBUG ("Setting album number to %s", tag_str); + id3v2tag->addFrame (frame); + frame->setText (tag_str); + g_free (tag_str); + } + } else if (strcmp (tag, GST_TAG_ALBUM_VOLUME_COUNT) == 0) { + guint n; + + if (gst_tag_list_get_uint_index (list, GST_TAG_ALBUM_VOLUME_NUMBER, 0, &n)) { + GST_DEBUG ("volume-count handled with volume-number, skipping"); + } else if (gst_tag_list_get_uint_index (list, GST_TAG_ALBUM_VOLUME_COUNT, + 0, &n)) { + ID3v2::TextIdentificationFrame * frame; + gchar *tag_str; + + frame = new ID3v2::TextIdentificationFrame ("TPOS", String::UTF8); + tag_str = g_strdup_printf ("0/%u", n); + GST_DEBUG ("Setting album volume number/count to %s", tag_str); + id3v2tag->addFrame (frame); frame->setText (tag_str); g_free (tag_str); -- cgit