From ba36c8183bef6cacc7a2e8dc3367f2d53f5ca45b Mon Sep 17 00:00:00 2001 From: Sebastian Dröge Date: Thu, 6 Dec 2007 12:11:29 +0000 Subject: gst/audiofx/: The transform_ip() methods should do nothing if in passthrough mode. Original commit message from CVS: * gst/audiofx/audioamplify.c: (gst_audio_amplify_transform_ip): * gst/audiofx/audiochebyshevfreqband.c: (gst_audio_chebyshev_freq_band_transform_ip): * gst/audiofx/audiochebyshevfreqlimit.c: (gst_audio_chebyshev_freq_limit_transform_ip): * gst/audiofx/audiodynamic.c: (gst_audio_dynamic_transform_ip): * gst/audiofx/audioinvert.c: (gst_audio_invert_transform_ip): The transform_ip() methods should do nothing if in passthrough mode. It might get non-writable buffers in that case but the buffer might as well be writable. * gst/audiofx/audiopanorama.c: (gst_audio_panorama_transform): The transform() methods won't be called in passthrough mode and otherwise the buffer is always writable so don't check here. --- gst/audiofx/audiopanorama.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) (limited to 'gst/audiofx/audiopanorama.c') diff --git a/gst/audiofx/audiopanorama.c b/gst/audiofx/audiopanorama.c index 72fd14e8..3c7542b1 100644 --- a/gst/audiofx/audiopanorama.c +++ b/gst/audiofx/audiopanorama.c @@ -169,19 +169,19 @@ static GstFlowReturn gst_audio_panorama_transform (GstBaseTransform * base, static GstAudioPanoramaProcessFunc panorama_process_functions[2][2][2] = { { {(GstAudioPanoramaProcessFunc) gst_audio_panorama_transform_m2s_int, - (GstAudioPanoramaProcessFunc) - gst_audio_panorama_transform_m2s_int_simple}, + (GstAudioPanoramaProcessFunc) + gst_audio_panorama_transform_m2s_int_simple}, {(GstAudioPanoramaProcessFunc) gst_audio_panorama_transform_m2s_float, - (GstAudioPanoramaProcessFunc) - gst_audio_panorama_transform_m2s_float_simple} + (GstAudioPanoramaProcessFunc) + gst_audio_panorama_transform_m2s_float_simple} }, { {(GstAudioPanoramaProcessFunc) gst_audio_panorama_transform_s2s_int, - (GstAudioPanoramaProcessFunc) - gst_audio_panorama_transform_s2s_int_simple}, + (GstAudioPanoramaProcessFunc) + gst_audio_panorama_transform_s2s_int_simple}, {(GstAudioPanoramaProcessFunc) gst_audio_panorama_transform_s2s_float, - (GstAudioPanoramaProcessFunc) - gst_audio_panorama_transform_s2s_float_simple} + (GstAudioPanoramaProcessFunc) + gst_audio_panorama_transform_s2s_float_simple} } }; @@ -631,9 +631,6 @@ gst_audio_panorama_transform (GstBaseTransform * base, GstBuffer * inbuf, GstAudioPanorama *filter = GST_AUDIO_PANORAMA (base); guint num_samples = GST_BUFFER_SIZE (outbuf) / (2 * filter->width); - if (!gst_buffer_is_writable (outbuf)) - return GST_FLOW_OK; - if (GST_CLOCK_TIME_IS_VALID (GST_BUFFER_TIMESTAMP (outbuf))) gst_object_sync_values (G_OBJECT (filter), GST_BUFFER_TIMESTAMP (outbuf)); -- cgit