From bd5e70ea40406968982d4a39320fdf4fd1b2e5c1 Mon Sep 17 00:00:00 2001 From: Stefan Kost Date: Thu, 24 Aug 2006 14:16:55 +0000 Subject: gst/audiofxgood/audiopanorama.c: Fix docs & debug category. Add Fixme for volume pan levels. Original commit message from CVS: * gst/audiofxgood/audiopanorama.c: (gst_audio_panorama_transform_m2s): Fix docs & debug category. Add Fixme for volume pan levels. --- gst/audiofx/audiopanorama.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'gst/audiofx') diff --git a/gst/audiofx/audiopanorama.c b/gst/audiofx/audiopanorama.c index 760f6ed0..4bf209d7 100644 --- a/gst/audiofx/audiopanorama.c +++ b/gst/audiofx/audiopanorama.c @@ -23,15 +23,13 @@ * @short_description: audio strereo pan effect * * - * Echo effect with controllable effect-ratio, delay-time and feedback. + * Stereo panorama effect with controllable pan position. * Example launch line * * * gst-launch audiotestsrc wave=saw ! audiopanorama panorama=-100 ! alsasink * gst-launch filesrc location="melo1.ogg" ! oggdemux ! vorbisdec ! audioconvert ! audiopanorama panorama=-100 ! alsasink * - * In the latter example the echo is applied to the input signal of the - * soundcard (like a microphone). * * */ @@ -91,7 +89,7 @@ static GstStaticPadTemplate src_template = GST_STATIC_PAD_TEMPLATE ("src", ); #define DEBUG_INIT(bla) \ - GST_DEBUG_CATEGORY_INIT (gst_audio_panorama_debug, "audiopanorama", 0, "audiopanorama plugin"); + GST_DEBUG_CATEGORY_INIT (gst_audio_panorama_debug, "audiopanorama", 0, "audiopanorama element"); GST_BOILERPLATE_FULL (GstAudioPanorama, gst_audio_panorama, GstBaseTransform, GST_TYPE_BASE_TRANSFORM, DEBUG_INIT); @@ -289,6 +287,8 @@ gst_audio_panorama_transform_m2s (GstAudioPanorama * filter, gint16 * idata, /* pan: -100 0 100 * lpan: 1.0 0.5 0.0 * rpan: 0.0 0.5 1.0 + * + * FIXME: we should use -3db (1/sqtr(2)) for 50:50 */ rpan = (gdouble) (filter->panorama + 100) / 200.0; lpan = 1.0 - rpan; -- cgit