From 465a740bbf5b569251ecfb4d4ebd301b0120b2ca Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Fri, 25 May 2007 10:23:49 +0000 Subject: gst/autodetect/gstautoaudiosink.c: Don't unnecessarily perform a READY->NULL->READY transition on the detected audio ... Original commit message from CVS: * gst/autodetect/gstautoaudiosink.c: (gst_auto_audio_sink_detect): Don't unnecessarily perform a READY->NULL->READY transition on the detected audio sink when starting up. Fixes: #440127 --- gst/autodetect/gstautoaudiosink.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'gst/autodetect') diff --git a/gst/autodetect/gstautoaudiosink.c b/gst/autodetect/gstautoaudiosink.c index 3920a33d..c3dc052b 100644 --- a/gst/autodetect/gstautoaudiosink.c +++ b/gst/autodetect/gstautoaudiosink.c @@ -290,7 +290,12 @@ gst_auto_audio_sink_detect (GstAutoAudioSink * sink) } sink->kid = esink; - gst_element_set_state (sink->kid, GST_STATE (sink)); + /* Ensure the child is brought up to the right state to match the parent + * although it's currently always in READY and + * we're always doing NULL->READY. */ + if (GST_STATE (sink->kid) < GST_STATE (sink)) + gst_element_set_state (sink->kid, GST_STATE (sink)); + gst_bin_add (GST_BIN (sink), esink); /* attach ghost pad */ -- cgit