From 297bbfbebc7bf03cd94e89a4ef7b9660a6cf3e9c Mon Sep 17 00:00:00 2001 From: Tim-Philipp Müller Date: Wed, 25 Mar 2009 01:22:17 +0000 Subject: rtpmp4apay: warn if input is unframed --- gst/rtp/gstrtpmp4apay.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'gst') diff --git a/gst/rtp/gstrtpmp4apay.c b/gst/rtp/gstrtpmp4apay.c index efa30955..6d18bd06 100644 --- a/gst/rtp/gstrtpmp4apay.c +++ b/gst/rtp/gstrtpmp4apay.c @@ -37,11 +37,13 @@ GST_ELEMENT_DETAILS ("RTP MPEG4 audio payloader", "Payload MPEG4 audio as RTP packets (RFC 3016)", "Wim Taymans "); +/* FIXME: add framed=(boolean)true once our encoders have this field set + * on their output caps */ static GstStaticPadTemplate gst_rtp_mp4a_pay_sink_template = GST_STATIC_PAD_TEMPLATE ("sink", GST_PAD_SINK, GST_PAD_ALWAYS, - GST_STATIC_CAPS ("audio/mpeg," "mpegversion=(int) 4") + GST_STATIC_CAPS ("audio/mpeg, mpegversion=(int)4") ); static GstStaticPadTemplate gst_rtp_mp4a_pay_src_template = @@ -280,7 +282,7 @@ gst_rtp_mp4a_pay_setcaps (GstBaseRTPPayload * payload, GstCaps * caps) GstRtpMP4APay *rtpmp4apay; GstStructure *structure; const GValue *codec_data; - gboolean res; + gboolean res, framed = TRUE; rtpmp4apay = GST_RTP_MP4A_PAY (payload); @@ -339,6 +341,10 @@ gst_rtp_mp4a_pay_setcaps (GstBaseRTPPayload * payload, GstCaps * caps) } } + if (gst_structure_get_boolean (structure, "framed", &framed) && !framed) { + GST_WARNING_OBJECT (payload, "Need framed AAC data as input!"); + } + gst_basertppayload_set_options (payload, "audio", TRUE, "MP4A-LATM", rtpmp4apay->rate); -- cgit