1 files changed, 47 insertions, 11 deletions

diff --git a/src/modules/module-cli.c b/src/modules/module-cli.c
index 41e33c7f..ce50a46b 100644
--- a/src/modules/module-cli.c
+++ b/src/modules/module-cli.c
@@ -32,38 +32,64 @@
 #include <polypcore/cli.h>
 #include <polypcore/sioman.h>
 #include <polypcore/log.h>
+#include <polypcore/modargs.h>
 
 #include "module-cli-symdef.h"
 
 PA_MODULE_AUTHOR("Lennart Poettering")
 PA_MODULE_DESCRIPTION("Command line interface")
 PA_MODULE_VERSION(PACKAGE_VERSION)
-PA_MODULE_USAGE("No arguments")
+PA_MODULE_USAGE("exit_on_eof=<exit daemon after EOF?>")
 
-static void eof_cb(pa_cli*c, void *userdata) {
+static const char* const valid_modargs[] = {
+    "exit_on_eof",
+    NULL
+};
+
+static void eof_and_unload_cb(pa_cli*c, void *userdata) {
     pa_module *m = userdata;
-    assert(c && m);
+    
+    assert(c);
+    assert(m);
 
     pa_module_unload_request(m);
 }
 
+static void eof_and_exit_cb(pa_cli*c, void *userdata) {
+    pa_module *m = userdata;
+
+    assert(c);
+    assert(m);
+
+    m->core->mainloop->quit(m->core->mainloop, 0);
+}
+
 int pa__init(pa_core *c, pa_module*m) {
     pa_iochannel *io;
-    assert(c && m);
+    pa_modargs *ma;
+    int exit_on_eof = 0;
+    
+    assert(c);
+    assert(m);
 
     if (c->running_as_daemon) {
-        pa_log_info(__FILE__": Running as daemon so won't load this module.");
+        pa_log_info(__FILE__": Running as daemon, refusing to load this module.");
         return 0;
     }
 
-    if (m->argument) {
-        pa_log(__FILE__": module doesn't accept arguments.");
-        return -1;
+    if (!(ma = pa_modargs_new(m->argument, valid_modargs))) {
+        pa_log(__FILE__": failed to parse module arguments.");
+        goto fail;
     }
     
+    if (pa_modargs_get_value_boolean(ma, "exit_on_eof", &exit_on_eof) < 0) {
+        pa_log(__FILE__": exit_on_eof= expects boolean argument.");
+        goto fail;
+    }
+
     if (pa_stdio_acquire() < 0) {
         pa_log(__FILE__": STDIN/STDUSE already in use.");
-        return -1;
+        goto fail;
     }
 
     io = pa_iochannel_new(c->mainloop, STDIN_FILENO, STDOUT_FILENO);
@@ -73,13 +99,23 @@ int pa__init(pa_core *c, pa_module*m) {
     m->userdata = pa_cli_new(c, io, m);
     assert(m->userdata);
 
-    pa_cli_set_eof_callback(m->userdata, eof_cb, m);
+    pa_cli_set_eof_callback(m->userdata, exit_on_eof ? eof_and_exit_cb : eof_and_unload_cb, m);
+
+    pa_modargs_free(ma);
     
     return 0;
+
+fail:
+
+    if (ma)
+        pa_modargs_free(ma);
+
+    return -1;
 }
 
 void pa__done(pa_core *c, pa_module*m) {
-    assert(c && m);
+    assert(c);
+    assert(m);
 
     if (c->running_as_daemon == 0) {
         pa_cli_free(m->userdata);