diff options
Diffstat (limited to 'src/pulsecore/cli-command.c')
| -rw-r--r-- | src/pulsecore/cli-command.c | 58 | 
1 files changed, 28 insertions, 30 deletions
| diff --git a/src/pulsecore/cli-command.c b/src/pulsecore/cli-command.c index e2c3c066..b57919a4 100644 --- a/src/pulsecore/cli-command.c +++ b/src/pulsecore/cli-command.c @@ -328,7 +328,7 @@ static int pa_cli_command_source_outputs(pa_core *c, pa_tokenizer *t, pa_strbuf  static int pa_cli_command_stat(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, pa_bool_t *fail) {      char ss[PA_SAMPLE_SPEC_SNPRINT_MAX];      char cm[PA_CHANNEL_MAP_SNPRINT_MAX]; -    char s[256]; +    char bytes[PA_BYTES_SNPRINT_MAX];      const pa_mempool_stat *stat;      unsigned k;      pa_sink *def_sink; @@ -352,22 +352,22 @@ static int pa_cli_command_stat(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, pa_b      pa_strbuf_printf(buf, "Memory blocks currently allocated: %u, size: %s.\n",                       (unsigned) pa_atomic_load(&stat->n_allocated), -                     pa_bytes_snprint(s, sizeof(s), (unsigned) pa_atomic_load(&stat->allocated_size))); +                     pa_bytes_snprint(bytes, sizeof(bytes), (unsigned) pa_atomic_load(&stat->allocated_size)));      pa_strbuf_printf(buf, "Memory blocks allocated during the whole lifetime: %u, size: %s.\n",                       (unsigned) pa_atomic_load(&stat->n_accumulated), -                     pa_bytes_snprint(s, sizeof(s), (unsigned) pa_atomic_load(&stat->accumulated_size))); +                     pa_bytes_snprint(bytes, sizeof(bytes), (unsigned) pa_atomic_load(&stat->accumulated_size)));      pa_strbuf_printf(buf, "Memory blocks imported from other processes: %u, size: %s.\n",                       (unsigned) pa_atomic_load(&stat->n_imported), -                     pa_bytes_snprint(s, sizeof(s), (unsigned) pa_atomic_load(&stat->imported_size))); +                     pa_bytes_snprint(bytes, sizeof(bytes), (unsigned) pa_atomic_load(&stat->imported_size)));      pa_strbuf_printf(buf, "Memory blocks exported to other processes: %u, size: %s.\n",                       (unsigned) pa_atomic_load(&stat->n_exported), -                     pa_bytes_snprint(s, sizeof(s), (unsigned) pa_atomic_load(&stat->exported_size))); +                     pa_bytes_snprint(bytes, sizeof(bytes), (unsigned) pa_atomic_load(&stat->exported_size)));      pa_strbuf_printf(buf, "Total sample cache size: %s.\n", -                     pa_bytes_snprint(s, sizeof(s), (unsigned) pa_scache_total_size(c))); +                     pa_bytes_snprint(bytes, sizeof(bytes), (unsigned) pa_scache_total_size(c)));      pa_strbuf_printf(buf, "Default sample spec: %s\n",                       pa_sample_spec_snprint(ss, sizeof(ss), &c->default_sample_spec)); @@ -529,8 +529,8 @@ static int pa_cli_command_sink_volume(pa_core *c, pa_tokenizer *t, pa_strbuf *bu          return -1;      } -    pa_cvolume_set(&cvolume, sink->sample_spec.channels, volume); -    pa_sink_set_volume(sink, &cvolume, TRUE, TRUE, TRUE, TRUE); +    pa_cvolume_set(&cvolume, 1, volume); +    pa_sink_set_volume(sink, &cvolume, TRUE, TRUE);      return 0;  } @@ -571,7 +571,7 @@ static int pa_cli_command_sink_input_volume(pa_core *c, pa_tokenizer *t, pa_strb          return -1;      } -    pa_cvolume_set(&cvolume, si->sample_spec.channels, volume); +    pa_cvolume_set(&cvolume, 1, volume);      pa_sink_input_set_volume(si, &cvolume, TRUE, TRUE);      return 0;  } @@ -607,7 +607,7 @@ static int pa_cli_command_source_volume(pa_core *c, pa_tokenizer *t, pa_strbuf *          return -1;      } -    pa_cvolume_set(&cvolume, source->sample_spec.channels, volume); +    pa_cvolume_set(&cvolume, 1, volume);      pa_source_set_volume(source, &cvolume, TRUE);      return 0;  } @@ -1549,7 +1549,7 @@ static int pa_cli_command_dump(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, pa_b      pa_sink *sink;      pa_source *source;      pa_card *card; -    int nl; +    pa_bool_t nl;      uint32_t idx;      char txt[256];      time_t now; @@ -1567,7 +1567,7 @@ static int pa_cli_command_dump(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, pa_b      pa_strbuf_printf(buf, "### Configuration dump generated at %s\n", ctime(&now));  #endif -    for (m = pa_idxset_first(c->modules, &idx); m; m = pa_idxset_next(c->modules, &idx)) { +    PA_IDXSET_FOREACH(m, c->modules, idx) {          pa_strbuf_printf(buf, "load-module %s", m->name); @@ -1577,58 +1577,58 @@ static int pa_cli_command_dump(pa_core *c, pa_tokenizer *t, pa_strbuf *buf, pa_b          pa_strbuf_puts(buf, "\n");      } -    nl = 0; - -    for (sink = pa_idxset_first(c->sinks, &idx); sink; sink = pa_idxset_next(c->sinks, &idx)) { +    nl = FALSE; +    PA_IDXSET_FOREACH(sink, c->sinks, idx) {          if (!nl) {              pa_strbuf_puts(buf, "\n"); -            nl = 1; +            nl = TRUE;          } -        pa_strbuf_printf(buf, "set-sink-volume %s 0x%03x\n", sink->name, pa_cvolume_avg(pa_sink_get_volume(sink, FALSE, TRUE))); +        pa_strbuf_printf(buf, "set-sink-volume %s 0x%03x\n", sink->name, pa_cvolume_max(pa_sink_get_volume(sink, FALSE)));          pa_strbuf_printf(buf, "set-sink-mute %s %s\n", sink->name, pa_yes_no(pa_sink_get_mute(sink, FALSE)));          pa_strbuf_printf(buf, "suspend-sink %s %s\n", sink->name, pa_yes_no(pa_sink_get_state(sink) == PA_SINK_SUSPENDED));      } -    for (source = pa_idxset_first(c->sources, &idx); source; source = pa_idxset_next(c->sources, &idx)) { +    nl = FALSE; +    PA_IDXSET_FOREACH(source, c->sources, idx) {          if (!nl) {              pa_strbuf_puts(buf, "\n"); -            nl = 1; +            nl = TRUE;          } -        pa_strbuf_printf(buf, "set-source-volume %s 0x%03x\n", source->name, pa_cvolume_avg(pa_source_get_volume(source, FALSE))); +        pa_strbuf_printf(buf, "set-source-volume %s 0x%03x\n", source->name, pa_cvolume_max(pa_source_get_volume(source, FALSE)));          pa_strbuf_printf(buf, "set-source-mute %s %s\n", source->name, pa_yes_no(pa_source_get_mute(source, FALSE)));          pa_strbuf_printf(buf, "suspend-source %s %s\n", source->name, pa_yes_no(pa_source_get_state(source) == PA_SOURCE_SUSPENDED));      } -    for (card = pa_idxset_first(c->cards, &idx); card; card = pa_idxset_next(c->cards, &idx)) { +    nl = FALSE; +    PA_IDXSET_FOREACH(card, c->cards, idx) {          if (!nl) {              pa_strbuf_puts(buf, "\n"); -            nl = 1; +            nl = TRUE;          }          if (card->active_profile)              pa_strbuf_printf(buf, "set-card-profile %s %s\n", card->name, card->active_profile->name);      } -    nl = 0; - +    nl = FALSE;      if ((sink = pa_namereg_get_default_sink(c))) {          if (!nl) {              pa_strbuf_puts(buf, "\n"); -            nl = 1; +            nl = TRUE;          } +          pa_strbuf_printf(buf, "set-default-sink %s\n", sink->name);      }      if ((source = pa_namereg_get_default_source(c))) { -        if (!nl) { +        if (!nl)              pa_strbuf_puts(buf, "\n"); -            nl = 1; -        } +          pa_strbuf_printf(buf, "set-default-source %s\n", source->name);      } @@ -1813,8 +1813,6 @@ int pa_cli_command_execute_file(pa_core *c, const char *fn, pa_strbuf *buf, pa_b      ret = pa_cli_command_execute_file_stream(c, f, buf, fail); -    ret = 0; -  fail:      if (f)          fclose(f); | 
