summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* module-jack-sink/source: protect against null return in jack_get_portsDavid Henningsson2011-03-282-10/+16
| | | | | | | | | | | | | | | | | | | | Just picking up a crash report from Ubuntu, here's the result. -- David Henningsson, Canonical Ltd. http://launchpad.net/~diwic From 934c52c79bb6faed56a64d6e15f9b285f687afee Mon Sep 17 00:00:00 2001 From: David Henningsson <david.henningsson@canonical.com> Date: Mon, 28 Mar 2011 14:30:44 +0200 Subject: [PATCH] module-jack-sink/source: protect against null return in jack_get_ports According to jack_get_ports documentation, it seems like returning NULL is valid, and that it should be freed using jack_free. Reported-by: Grayson Peddie BugLink: http://bugs.launchpad.net/bugs/733424 Signed-off-by: David Henningsson <david.henningsson@canonical.com>
* cork-on-phone: Handle sink-inputs with NULL sinksArun Raghavan2011-03-281-0/+3
| | | | | It's possible that by the time we receive the unlink hook, the given sink-input's sink is set to NULL. Handle this gracefully.
* alsa-mixer: Get rid of a compiler warning.Tanu Kaskinen2011-03-283-10/+26
| | | | | | | | | | On 64-bit systems LONG_MAX is greater than the largest possible value of a uint32_t variable, which caused the compiler to warn about a comparison that is always false. On 32-bit systems pa_atou() can return a value that will overflow when assigned to e->volume_limit, which has type long, so the comparison was necessary. This dilemma is resolved by using pa_atol() instead of pa_atou().
* .gitignore: Add ChangeLog to the ignore list.Tanu Kaskinen2011-03-281-0/+1
|
* vala: Fix path error in the last commit.Colin Guthrie2011-03-261-1/+1
|
* vala: move GLibMainLoop class into separate file to fix linker errorsAlexander Kurtz2011-03-264-12/+20
| | | | | | | | | | | | | | Vala uses the name of the *.vapi file to determine the libraries to link against. Since the pa_glib_mainloop_*() functions are in a separate library (libpulse-mainloop-glib.so) the corresponding objects in the Vala bindings have to be in a separate *.vapi file. If you are compiling an app without the GLib integration you could use: $ valac --pkg=libpulse test.vala but if you do use GLib you can use: $ valac --pkg=libpulse-mainloop-glib test.vala (libpulse is a dep of the libpulse-mainloop-glib so no need to specify it explicitly)
* bluetooth: Fix a double-free-esque error introduced in 8f3ef04bColin Guthrie2011-03-261-2/+0
|
* dbus: Do not refcnt the core.Colin Guthrie2011-03-253-7/+3
| | | | | | | We should not call pa_core_ref() anywhere in the code. Doing so will prevent proper daemon shutdown as the only call (in daemon/main.c) to pa_core_unref() should always call free_core() and perform a normal shutdown (i.e. unload all modules gracefully).
* daemon: Fix regression introduced in f1d1447e.Colin Guthrie2011-03-251-3/+43
| | | | | | | | | | | | | | | | | | | With Tanu's patch, the server no longer starts when a server is configured. While this is sensible in most circumstances there is a corner case where we still want to start. In a typical X11 login, module-x11-publish will be loaded and will thus set the PULSE_SERVER X11 property on the root window. This then hits the check introduced in f1d1447e and exits. If PA had previously crashed (thus leaving behind it's X11 properties) then this means that we will not autospawn nor even allow ourselves to be started manually until pax11publish -r is run to clear out the X11 properties. This is obviously not desirable. This patch introduces a more in-depth check of the server. If it looks like a local unix domain socket, then we do not exit straight away and instead probe further. This should not pose any problems with e.g. remote SSH usage as the DBus Machine ID is used in the server string.
* daemon: Fix some more error paths in the double forking.Colin Guthrie2011-03-251-1/+8
| | | | | | | | | | | | | | | | | | | As spotted by Tanu Kaskinen: The first process: daemon_pipe is not closed if the first fork() call fails. Even if it doesn't fail, the first process never closes daemon_pipe[0]. The second process: daemon_pipe[1] is not closed if anything fails between the first and the second fork() call. Also, if the second fork fails, then the finish section writes to daemon_pipe2[1], even though only the third process should do that. Also, if anything fails between the first and the second fork, then the second process never writes anything to daemon_pipe[1]. I don't know what happens in the first process in this case - does it get an error or does pa_loop_read() get stuck. The third process: No problems :)
* build: Bump Orc dependency to 0.4.11Arun Raghavan2011-03-251-1/+1
| | | | | | | 0.4.9 errors out at compile time, and might as well bump to 0.4.11 since that's the version being tested with and has been around for a while now. Thanks to Paul Menzel <paulepanter@users.sourceforge.net> for pointing this out.
* vala: delegate FreeCb does not have a target.Sean McNamara2011-03-251-1/+1
|
* po: Remove files no longer in the tree (and which didn't have any ↵Colin Guthrie2011-03-241-2/+0
| | | | | | translations anyway). File was removed in c470680e
* vala: Some bugfixes for the vala bindingsAlexander Kurtz2011-03-243-5/+7
| | | | | | | | | | | | | | 1. PA uses Vala's "Posix" package (see line 23 of libpulse.vapi). These dependencies have to be declared in the *.deps file. 2. Fix obvious copy/paste error. 3. Rename the parameter to match the C function. This simplifies understanding what this parameter means. 4. According to the official documentation the "dev" parameter for playback/capture streams on connection may be NULL and this is the default. Change the method definition accordingly.
* daemon: Fix regression with --start introduced with the double fork in 8e94f653Colin Guthrie2011-03-241-9/+42
| | | | | | | | The previous commit intoduced a double fork which caused a more or less immediate successful return prior to the hard work of actually starting a daemon. This patch simply used pipe() to only signal our father when the daemon really has finished starting.
* log: Correct bad function implementationVincent Becker2011-03-241-17/+15
| | | | Replace wrong implementation of log to file in pa_daemon_conf_set_log_level to pa_daemon_conf_set_log_target
* bluetooth: Get rid of warnings about unused stuff when building against a ↵Tanu Kaskinen2011-03-241-0/+10
| | | | D-Bus version that doesn't have fd-passing support.
* bluetooth: Don't log an error if an endpoint type is disabled.Tanu Kaskinen2011-03-242-12/+23
| | | | | | | | | It's perfectly normal for BlueZ to disable some endpoint types, so printing a log message at error level isn't a good idea. For facilitating an informative message in case some endpoint type is disabled, the send_and_add_to_pending() function interface is also changed to be more generic (the pa_bluetooth_device pointer is replaced with a void pointer).
* Move compile-time checks around pa_run_from_build_tree to core-utilMaarten Bosmans2011-03-244-21/+10
| | | | To make the code cleaner and have the checks all in one place.
* win32: Simplify dl_search_path codeMaarten Bosmans2011-03-241-13/+6
| | | | And add #include <sys/stat.h>, needed by the code introduced in f7acd4bd.
* Merge remote-tracking branch 'zonique/osx'Colin Guthrie2011-03-246-5/+60
|\
| * osx: add routines for real-time thread schedulingDaniel Mack2011-03-211-1/+37
| | | | | | | | | | Code sniplets are based on examples provided by Apple. See http://developer.apple.com/library/mac/#documentation/Darwin/Conceptual/KernelProgramming/scheduler/scheduler.html
| * configure.ac: add --mac-universal directive for OS XDaniel Mack2011-03-211-0/+13
| | | | | | | | | | | | On a system with all depency libs built as multi-arch binaries, this option can now be used to build fat Mach-O binaries for multiple architectures.
| * osx: add -headerpad_max_install_names to LDFLAGSDaniel Mack2011-03-211-0/+4
| | | | | | | | | | This is needed for sufficient padding of library names in linked binaries.
| * osx: re-order module locationsDaniel Mack2011-03-214-3/+3
| | | | | | | | move all Mac OS X related modules to own location.
| * module-coreaudio-detect: fix variable assignment in pa__done()Daniel Mack2011-03-211-1/+3
| | | | | | | | Do not dereference 'u' prior to its assignment.
* | echo-cancel: Fix warning/typoColin Guthrie2011-03-201-1/+1
| |
* | tunnel: Remove bogus `{`Paul Menzel2011-03-201-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Fix mistakes in: commit 36e7f8a92e8b340dd4034a39a655ba93bcd41886 Author: Colin Guthrie <cguthrie@mandriva.org> Date: Sun Mar 20 14:09:14 2011 +0000 tunnel: Fix tunnel streams with recent servers Prompted by bug #750. Thanks to Emil Renner Berthing for the original patch.
* | tunnel: Fix tunnel streams with recent serversColin Guthrie2011-03-201-0/+8
| | | | | | | | | | Prompted by bug #750. Thanks to Emil Renner Berthing for the original patch.
* | bluetooth: Run 'make update-sbc'Colin Guthrie2011-03-2013-25/+52
| | | | | | | | Note that changes to ipc.h from 8f3ef04b had to be manually reapplied.
* | build-sys: Make update-sbc, update-reserve and update-rtkit work in OOT buildsColin Guthrie2011-03-201-4/+4
| |
* | alsa-mixer: Refactoring: merge element_mute_volume(), element_zero_volume() ↵Tanu Kaskinen2011-03-201-67/+35
| | | | | | | | and element_apply_constant_volume() into a single function.
* | alsa-mixer: Implement constant volume.Tanu Kaskinen2011-03-203-12/+59
| | | | | | | | | | | | | | This change makes it possible to configure an arbitrary constant volume for a volume element in the path configuration, which is applied when the path is selected. Note: this is only useful when the exact hardware and driver are known beforehand.
* | Get rid of some warningsMaarten Bosmans2011-03-207-21/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mostly warnings about unused stuff. Furthermore, the first hunk is a fix for the change in 177948a6. Finally, comment in AEC_dtd was translated and the code simplified slightly. CC module_bluetooth_device_la-module-bluetooth-device.lo modules/bluetooth/module-bluetooth-device.c: In function ‘a2dp_process_render’: modules/bluetooth/module-bluetooth-device.c:1335:30: warning: pointer targets in passing argument 6 of ‘sbc_encode’ differ in signedness [-Wpointer-sign] ../src/modules/bluetooth/sbc/sbc.h:92:9: note: expected ‘ssize_t *’ but argument is of type ‘size_t *’ CC module_rygel_media_server_la-module-rygel-media-server.lo modules/module-rygel-media-server.c:383:13: warning: ‘append_property_dict_entry_object_array’ defined but not used [-Wunused-function] CC module_echo_cancel_la-adrian-aec.lo modules/echo-cancel/adrian-aec.h:360:15: warning: ‘AEC_getambient’ defined but not used [-Wunused-function] modules/echo-cancel/adrian-aec.h:368:14: warning: ‘AEC_setgain’ defined but not used [-Wunused-function] modules/echo-cancel/adrian-aec.h:374:14: warning: ‘AEC_setaes’ defined but not used [-Wunused-function] modules/echo-cancel/adrian-aec.h:377:16: warning: ‘AEC_max_dotp_xf_xf’ declared ‘static’ but never defined [-Wunused-function] CC module_echo_cancel_la-module-echo-cancel.lo modules/echo-cancel/module-echo-cancel.c: In function ‘time_callback’: modules/echo-cancel/module-echo-cancel.c:266:12: warning: variable ‘fs’ set but not used [-Wunused-but-set-variable] CC module-virtual-sink.lo modules/module-virtual-sink.c: In function ‘sink_input_pop_cb’: modules/module-virtual-sink.c:206:15: warning: variable ‘current_latency’ set but not used [-Wunused-but-set-variable]
* | daemon: Fix missing include - cpu-orc.hArun Raghavan2011-03-201-0/+1
| |
* | Get rid of some warnings: -Wunsafe-loop-optimizationsMaarten Bosmans2011-03-202-8/+8
| | | | | | | | | | | | | | | | | | | | pulsecore/core-util.c: In function ‘pa_hexstr’: pulsecore/core-util.c:1858: warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations] modules/alsa/alsa-mixer.c: In function ‘pa_alsa_decibel_fix_dump’: modules/alsa/alsa-mixer.c:3678: warning: cannot optimize possibly infinite loops [-Wunsafe-loop-optimizations] modules/alsa/alsa-mixer.c: In function ‘pa_alsa_path_set_new’: modules/alsa/alsa-mixer.c:2640: warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations]
* | Get rid of some warnings: -Wunused-resultMaarten Bosmans2011-03-203-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | modules/module-default-device-restore.c: In function ‘load’: modules/module-default-device-restore.c:67: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result] modules/module-default-device-restore.c:88: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result] pulsecore/authkey.c: In function ‘generate’: pulsecore/authkey.c:58: warning: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result [-Wunused-result] pulsecore/core-util.c: In function ‘pa_make_secure_dir’: pulsecore/core-util.c:261: warning: ignoring return value of ‘fchown’, declared with attribute warn_unused_result [-Wunused-result]
* | Merge remote-tracking branch 'mkbosmans/mingw32-build'Colin Guthrie2011-03-2028-295/+265
|\ \ | |/ |/|
| * module-waveout: Fix record/playback argsMaarten Bosmans2011-03-191-8/+12
| |
| * module-waveout: Move thread creationMaarten Bosmans2011-03-191-9/+13
| |
| * module-waveout: Query device for supported samplerateMaarten Bosmans2011-03-191-23/+36
| | | | | | | | | | Instead of using a fixed list list of supported rates, ask the wave subsystem whether the rate can be used.
| * Fix pa_rtclock_from_wallclockMaarten Bosmans2011-03-192-19/+18
| | | | | | | | | | | | | | | | The HAVE_CLOCK_GETTIME macro protects timespec and related functions, nothing of which is used in pa_rtclock_from_wallclock. And silently just not converting was not the proper solution anyway. Also add an assert in pulse/mainloop.c to report the integer overflow that was triggered by the wrong pa_rtclock_from_wallclock. Without the assert, debugging was painful.
| * Use pulsecore/arpa-inet.h to make arpa/inet.h functionality availableMaarten Bosmans2011-03-1921-141/+69
| | | | | | | | Automatically use replacement function on platforms (win32) where not all arpa/inet.h is available natively.
| * build: Protect some more variables by ifdefsMaarten Bosmans2011-03-191-1/+9
| | | | | | | | This avoids empty directories being created on builds without X11, ALSA, etc.
| * build: copy instead of link pacat to other utils on win32Maarten Bosmans2011-03-191-8/+13
| | | | | | | | This is necessary as symlinks are not supported on Windows. Also use the $(EXEEXT) variable.
| * Find modules and config files relative to the installed libraries.Maarten Bosmans2011-03-195-84/+65
| | | | | | | | Do not use replace %PULSE_ROOT% from the environment.
| * module-waveout: Add device_name parameterMaarten Bosmans2011-03-151-2/+30
| | | | | | | | | | | | Also use the name in the source/sink description. Based on a patch by srirams, from github.
* | log: Add a new log target to a file descriptorVincent Becker2011-03-184-2/+56
| | | | | | | | | | | | | | This patch enables logging of text debug messages (pa_log feature) into a file or a device driver. Example : pulseaudio --log-target=file:./mylog.txt (Minor tweaks by Colin + Arun)
* | Update PA_MODULE_USAGE to be in line with actual implementationMaarten Bosmans2011-03-189-11/+17
| |
* | build-sys: Fix bluetooth update-sbc now that it's in a subfolder.Colin Guthrie2011-03-181-2/+2
| |
generated by cgit (git 2.34.1) at 2024-04-28 09:46:21 +0000