summaryrefslogtreecommitdiffstats
path: root/src/pulsecore
Commit message (Collapse)AuthorAgeFilesLines
* protocol-native: Don't leak formatsArun Raghavan2011-06-191-3/+16
| | | | | This clarifies some ownership issues with the formats idxset on the server side so we don't end up leaking formats on errors.
* protocol-native: Use original requested latency on stream movesArun Raghavan2011-06-141-4/+12
| | | | | | | | We were calculating new latency based on the latency set on the old sink/source, rather than the actual latency requested by the client. Over a series of moves, this will lead the latency being ~halved each time, resulting in an eventual rewind flood from a latency that cannot be handled.
* win32: define WIN32_LEAN_AND_MEANMaarten Bosmans2011-06-121-0/+1
| | | | | This makes windows.h include less headers. Otherwise boolean is typedef'ed and that clashes with libjson.
* pulsecore: Add a couple pa_asserts() on pa_tagstruct* calls.Colin Guthrie2011-06-061-0/+2
|
* streams: Fix the actual resampler method shown in debug messages.Colin Guthrie2011-06-022-0/+2
|
* format: Fix channel map handlingArun Raghavan2011-05-201-1/+2
| | | | | Channel map handling in the extended API was broken. Thanks for Milos_SD for pointing this out on IRC.
* protocol-native: Fix memory leaks introduced in protocol 21 (passthrough ↵Colin Guthrie2011-05-161-26/+30
| | | | | | | | | | | support) The proplist used may never be freed if an error condition was found with CHECK_VALIDITY macro and the formats idxset was never freed regardless of error state. This change fixes adds a new maco CHECK_VALIDITY_GOTO() which allows for cleanup to be done before returning.
* sink-input: Fix memory leak of proplist when sending format-changed eventsColin Guthrie2011-05-161-0/+1
|
* Merge branch 'passthrough'Colin Guthrie2011-05-1513-106/+464
|\
| * sink-input: Provide more information to client when format is lostArun Raghavan2011-05-151-1/+5
| | | | | | | | | | | | | | | | When the sink format changes and we kill the stream, clients need a way to know (a) what device they should reconnect to, and (b) what the stream running time was when the stream got killed (pa_stream_get_time() won't work after the stream has been killed). This adds these two bits of information in the event callback's proplist parameter.
| * sink-input: Add a format-lost eventArun Raghavan2011-05-151-1/+2
| | | | | | | | | | | | | | This event is emitted if the sink-input could not be moved to a new sink because it doesn't support the format of the sink-input. Clients can reconnect their stream with a different format if they wish or gracefully exit.
| * sink-input: Don't restore volume for passthrough streamsArun Raghavan2011-05-151-0/+6
| |
| * sink-input: Don't print an error if a passthrough connection failsArun Raghavan2011-05-151-1/+2
| | | | | | | | | | | | The assertion message is misleading, since the passthrough connection can fail for reasons the client has no control over (like other sink inputs being connected).
| * core: Factor out passthrough checks into their own functionsArun Raghavan2011-05-023-15/+39
| | | | | | | | | | | | | | | | | | | | Since we currently have two mechanisms to signal a passthrough connection (non-PCM format or PA_SINK_INPUT_PASSTHROUGH flag), we move all the related checks into functions and use those everywhere. This makes things more consistent, and should we decide to get rid of the flag, we only need to change pa_sink_input_*_is_passthrough() accordingly.
| * introspect: Get format of sink inputArun Raghavan2011-05-021-0/+2
| | | | | | | | | | This gets the negotiated format of sink inputs in pa_context_get_sink_input*(). Also prints the format in 'pactl list'.
| * introspect: Get formats for sinksArun Raghavan2011-05-021-0/+13
| | | | | | | | | | This gets the list of supported formats for a sink in pa_context_get_sink_info*(). Also prints these in 'pactl list'.
| * core: Suspend monitor when a sink enters passthrough modeArun Raghavan2011-05-023-1/+18
| | | | | | | | | | | | | | | | | | | | | | In most cases it is expected that clients cannot consume compressed data from monitor sources, so we suspend the monitor source when the sink goes into passthrough mode. Eventually, when the extended API includes client notifications for changed formats, we should emit a notification on the monitor so that clients can decide what they want to do when this happens (disconnect or consume the data anyway).
| * sink: Trivial typo fix in commentArun Raghavan2011-05-021-1/+1
| |
| * core: Fix some FIXMEs for the extended APIArun Raghavan2011-05-021-4/+9
| | | | | | | | | | | | This adds some checks that I'd postponed and adds a "should-be-good-enough" guess for tlength when using a compressed format.
| * sink-input: Kill passthrough streams if moving to an unsupported sinkArun Raghavan2011-05-023-0/+33
| | | | | | | | | | | | This will eventually be replaced by a hook to let clients know that the stream has moved so that they can gracefully reconnect and renegotiate a supported format.
| * sink: Fix leak in pa_sink_check_formats()Arun Raghavan2011-05-021-1/+4
| | | | | | | | We weren't freeing the sink formats idxset.
| * format: Avoid some code duplicationArun Raghavan2011-05-022-14/+7
| | | | | | | | | | | | We frequently need to free an idxset containing pa_format_infos, so define an internal free function that can be used directly with this (instead of defining it once-per-file).
| * sink-input: Don't assert on bad formatsArun Raghavan2011-05-021-2/+2
| | | | | | | | Handles bad format input more gracefully and returns an error instead.
| * sink-input: Return NOTSUPPORTED if format negotiation failsArun Raghavan2011-05-021-1/+1
| | | | | | | | This is easier for clients to grok than INVALID.
| * sink-input: Minor cleanupsArun Raghavan2011-05-021-5/+5
| | | | | | | | | | Removes a couple of warnings and simplifies the assertion logic that verifies format negotiation was successful.
| * sink: Remove PASSTHROUGH flagArun Raghavan2011-05-023-44/+38
| | | | | | | | | | | | | | This removes the passthrough flag from sinks since we will drop exclusively passthrough sinks in favour of providing a list of formats supported by each sink. We can still determine whether a sink is in passthrough mode by checking if any non-PCM streams are attached to it.
| * core: Add extended stream API to support compressed formatsArun Raghavan2011-05-027-37/+193
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the beginning of work to support compressed formats natively in PulseAudio. This adds a pa_stream_new_extended() that takes a format structure, sends it to the server (=> protocol extension) and has the server negotiate with the appropropriate sink to figure out what format it should use. This is work in progress, and works only with PCM streams. Actual compressed format support in some sink needs to be implemented, and extensive testing is required. More details on how this is supposed to work is available at: http://pulseaudio.org/wiki/PassthroughSupport
| * sink: Extend API for compressed formats supportArun Raghavan2011-05-022-0/+58
| | | | | | | | | | | | This adds a get_formats() vfunc for sinks to provide a list of formats they can support. pa_sink_check_formats() can be used during or after routing to determine what formats from a stream the sink can support.
| * core: Add a pa_format_info structureArun Raghavan2011-05-022-1/+47
| | | | | | | | | | This will be used to represent the format of data provided by the client for both compressed and PCM formats in a new extended API.
| * sink: Trivial typo fixArun Raghavan2011-05-021-7/+7
| |
| * sink-input: Don't resample passthrough inputsPierre-Louis Bossart2011-05-021-12/+14
| |
* | rtkit: use private bus connection in order to avoid threading issues when ↵Lennart Poettering2011-05-061-1/+2
|/ | | | invoking pa_make_realtime()
* x11: More XCB fixes.Arnaud Fontaine2011-04-301-13/+25
| | | | | | | | | | Commit 65ef80b fixed building with xcb-util >= 0.3.8, but the reply is never checked (possible SIGSEGV if the reply is NULL) nor freed (memory leak at each call of the functions). Also, remove include and dependencies on xcb-atom, as it was only meaningful for xcb_atom_get() and STRING, and depend instead on xcb >= 1.6 for XCB_ATOM_STRING.
* core: Drop empty gaps in the memblockq when playing data from it.Antti-Ville Jansson2011-04-281-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's possible that the memblockq of a sink input is rewound to a negative read index if the sink input is moved between sinks shortly after its creation. When this happens, pa_memblockq_peek() returns a memchunk whose 'memblock' field is NULL and whose 'length' field indicates the length of the gap caused by the negative read index. This will trigger an assert in play-memblockq.c. If the memblockq had a silence memchunk, pa_memblockq_peek() would return silence for the duration of the gap and the assert would be avoided. However, this approach would prevent the sink input from being drained and is thus not possible. Instead, we handle the aforementioned situation by dropping the gap indicated by the 'length' field of the memchunk and by peeking the actual data that comes after the gap. This scenario seems to be quite rare in everyday use, but it causes a severe bug in the handheld world. The assert can be triggered e.g. by loading two null sinks, playing a sample from the cache to one of them and then moving the created sink input between the two sinks. The rewinds done by the null sinks seem to be quite long (I don't know if this is normal behaviour or something fishy in module-null-sink). See also: 6bd34156b130c07b130de10111a12ef6dab18b52 virtual-sink: Fix a crash when moving the sink to a new master right after setup. https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-February/009105.html Reproduce: This problem can be reproduced with the following script: SAMPLE_PATH="/usr/share/sounds/alsa/" SAMPLE="Front_Left" pactl remove-sample $SAMPLE 2> /dev/null pactl upload-sample $SAMPLE_PATH$SAMPLE.wav mod1=`pactl load-module module-null-sink sink_name=null1` mod2=`pactl load-module module-null-sink sink_name=null2` pactl play-sample $SAMPLE null1 input=`pactl list | grep "Sink Input #" | tail -n 1 | cut -d# -f2` echo "Sample $SAMPLE playing as Sink Input #$input" pactl move-sink-input $input null2 pactl move-sink-input $input null1 pactl unload-module $mod1 pactl unload-module $mod2
* x11: Fix build errors with newest xcb-util.Maciej Grela2011-04-281-9/+17
| | | | | | The xcb_atom_get functions were removed from xcb-util. Changed these to xcb_intern_atom/xcb_intern_atom_reply. Also, STRING is now XCB_ATOM_STRING.
* protocol-dbus: Fix some memory management bugs.Tanu Kaskinen2011-04-231-6/+6
| | | | | | | | There were several memory leaks. In addition to those, pa_dbus_protocol_add_interface() used a string from the caller as a key to a hashmap, instead of a copy of the string. This caused trouble when the caller freed the string while the key was still in use in the hashmap.
* thread-posix: Use pthread_(get|set)name_np() if availableDaniel Mack2011-04-231-0/+9
| | | | | Newer generations of libpthread have functions to set and get the thread names. If available, use them.
* pulsecore:: Define _POSIX_C_SOURCE locally for rtclock on OSXDaniel Mack2011-04-231-0/+4
| | | | | | Defining this macro on a global level is disadvantageous for other APIs, and as we need it for clock_gettime() only on Mac OS X, define it locally in pulsecore/core-rtclock.c only.
* memblockq: decode unset chunks as NULL chunks againLennart Poettering2011-04-213-1/+13
| | | | | This fixes asserts beeing hit when see requests are posted via the native protocol.
* volume: Get more data from volume testsArun Raghavan2011-04-184-57/+147
| | | | | | | This makes the volume tests run in two loops and print the minimum, maximum and standard deviation of readings from the inner loop. This makes it easier to reason out performance drops (i.e. algorithmic problems vs. other system issues such as processor contention).
* pa_poll(): Simplify detection of invalid fds in select() emulation modeDaniel Mack2011-04-181-2/+27
| | | | | | | | | | | | | For systems which have a fcntl() implementation, we can simplify the code which determines whether a file selector is valid in pa_poll(). The old code, which is harder to read and more expensive, stays around for all platforms we need to emulate poll() for using select(), and which don't provide fcntl(). IOW, for Windows. On Mac OS X, however, the detection for bad fds via more select() calls doesn't work, resulting in hung main loops, so the patch fixes a real bug there.
* sink-input: Check flat volume with pa_sink_flat_volume_enabled().Tanu Kaskinen2011-04-181-2/+2
| | | | | Checking just the flag doesn't work if the sink uses volume sharing, because such sinks never have PA_SINK_FLAT_VOLUME set.
* sink-input: Add volume_writable to pa_sink_input.Tanu Kaskinen2011-03-294-34/+14
| | | | | | | | | | This is pretty cosmetic change; there's no actual functionality added. Previously the volume_writable information was available through the pa_sink_input_is_volume_writable() function, but I find it cleaner to have a real variable. The sink input introspection variable name was also changed from read_only_volume to volume_writable for consistency.
* alsa-mixer: Get rid of a compiler warning.Tanu Kaskinen2011-03-282-8/+24
| | | | | | | | | | On 64-bit systems LONG_MAX is greater than the largest possible value of a uint32_t variable, which caused the compiler to warn about a comparison that is always false. On 32-bit systems pa_atou() can return a value that will overflow when assigned to e->volume_limit, which has type long, so the comparison was necessary. This dilemma is resolved by using pa_atol() instead of pa_atou().
* dbus: Do not refcnt the core.Colin Guthrie2011-03-251-3/+1
| | | | | | | We should not call pa_core_ref() anywhere in the code. Doing so will prevent proper daemon shutdown as the only call (in daemon/main.c) to pa_core_unref() should always call free_core() and perform a normal shutdown (i.e. unload all modules gracefully).
* Move compile-time checks around pa_run_from_build_tree to core-utilMaarten Bosmans2011-03-242-3/+5
| | | | To make the code cleaner and have the checks all in one place.
* Merge remote-tracking branch 'zonique/osx'Colin Guthrie2011-03-241-1/+37
|\
| * osx: add routines for real-time thread schedulingDaniel Mack2011-03-211-1/+37
| | | | | | | | | | Code sniplets are based on examples provided by Apple. See http://developer.apple.com/library/mac/#documentation/Darwin/Conceptual/KernelProgramming/scheduler/scheduler.html
* | Get rid of some warnings: -Wunsafe-loop-optimizationsMaarten Bosmans2011-03-201-1/+1
| | | | | | | | | | | | | | | | | | | | pulsecore/core-util.c: In function ‘pa_hexstr’: pulsecore/core-util.c:1858: warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations] modules/alsa/alsa-mixer.c: In function ‘pa_alsa_decibel_fix_dump’: modules/alsa/alsa-mixer.c:3678: warning: cannot optimize possibly infinite loops [-Wunsafe-loop-optimizations] modules/alsa/alsa-mixer.c: In function ‘pa_alsa_path_set_new’: modules/alsa/alsa-mixer.c:2640: warning: cannot optimize loop, the loop counter may overflow [-Wunsafe-loop-optimizations]
* | Get rid of some warnings: -Wunused-resultMaarten Bosmans2011-03-202-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | modules/module-default-device-restore.c: In function ‘load’: modules/module-default-device-restore.c:67: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result] modules/module-default-device-restore.c:88: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result] pulsecore/authkey.c: In function ‘generate’: pulsecore/authkey.c:58: warning: ignoring return value of ‘ftruncate’, declared with attribute warn_unused_result [-Wunused-result] pulsecore/core-util.c: In function ‘pa_make_secure_dir’: pulsecore/core-util.c:261: warning: ignoring return value of ‘fchown’, declared with attribute warn_unused_result [-Wunused-result]
generated by cgit (git 2.34.1) at 2024-11-14 02:48:43 +0000