summaryrefslogtreecommitdiffstats
path: root/src/pulsecore
Commit message (Collapse)AuthorAgeFilesLines
* fdsem: be more verbose when reading from eventfd fails.Lennart Poettering2010-02-211-6/+35
| | | | | | | | | Apperently reading from an eventfd can fail, which results in an assert to be hit. I am not sure about the reason for the failure, but in attempt to track down the issue the next time is hit this prints a more useful log message. https://bugzilla.redhat.com/attachment.cgi?id=386380
* dbus: first restart timer, then dispatch itLennart Poettering2010-02-211-13/+16
| | | | | | | This makes sure that we don't access the timer after it might have been destroyed already from the dbus timeout callback. https://bugzilla.redhat.com/attachment.cgi?id=389952
* native: rework handling of seeks that depend on variables the client does ↵Lennart Poettering2010-02-094-5/+11
| | | | | | | | | | | | not know anything about All seeks/flushes that depend on the playback buffer read pointer cannot be accounted for properly in the client since it does not know the actual read pointer. Due to that the clients do not account for it at all. We need do the same on the server side. And we did, but a little bit too extreme. While we properly have not applied the changes to the "request" counter we still do have to apply it to the "missing" counter. This patch fixes that.
* cpu: check for CMOV flag before using this intsruction in assemblyLennart Poettering2010-02-093-4/+8
| | | | http://pulseaudio.org/ticket/776
* log: add an easy way to disable log rate limitingLennart Poettering2010-02-091-38/+50
| | | | | | Should help with debuggin bugs like: https://bugzilla.redhat.com/show_bug.cgi?id=554405
* once: make once related variables volatileLennart Poettering2010-02-094-10/+5
|
* core: make sure we always return a valid memblock in sink_input_pop() callbacksLennart Poettering2010-02-094-4/+18
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=553607
* native: fix request counter miscalculationsLennart Poettering2010-02-092-57/+51
| | | | | | | | | | | | | Do not subtract bytes the client sends us beyond what we requested from our missing bytes counter. This was mostly a thinko that caused servers asking for too little data when the client initially sent more data than requested, because that data sent too much was accounted for twice. This commit fixes this miscalculation. http://bugzilla.redhat.com/show_bug.cgi?id=534130
* core: Fix macro typo - PA_SINK_IS_LINKED -> PA_SINK_INPUT_IS_LINKEDColin Guthrie2010-02-091-1/+1
|
* shm: explicitly mark shm seg for MAP_NORESERVE to request overcommiting no ↵Lennart Poettering2010-02-021-1/+5
| | | | matter what
* native: fallback to another port if the default port is takenLennart Poettering2010-01-142-29/+52
| | | | | | | Unless the port number is explicitly configured we will now fallback to a kernel picked port if the one we'd like by default we cannot get. http://pulseaudio.org/ticket/773
* sink-input: Replace a tab indentation with spaces.Tanu Kaskinen2010-01-061-1/+1
|
* idxset: Fix _get_by_data() comment.Tanu Kaskinen2010-01-061-1/+1
|
* core: volume ramping fixhuan zheng2010-01-061-1/+1
| | | | | | | | | | | | | | | Hi, I found that volume ramping is inside PA now. there's a minor fix here, it is a bug i found after the patch is submitted: line 1781 of sink-input.c : if ((i->thread_info.ramp_info.envelope_dying - nbytes) <= 0) { need to be changed to if ((i->thread_info.ramp_info.envelope_dying - (ssize_t) nbytes) <= 0) { otherwise this argument will never be negative since nbytes is of type size_t which is unsigned. Please change it when you have time, sorry if bring any inconvenience. :)
* Merge remote branch 'zonque/topic/osx'Lennart Poettering2010-01-055-57/+75
|\
| * fix a number of warningsDaniel Mack2009-12-163-12/+12
| | | | | | | | | | most of them were due to missing #ifdefs or wrong printf format type for [s]size_t.
| * hack around another OS X bug: recv() with MSG_PEEK does not workDaniel Mack2009-12-161-0/+22
| | | | | | | | | | | | | | At least for pipes, recv() with MSG_PEEK does actually eat up data from file descriptors. Hence, this can't be used for PULLHUP emulation. Use another ioctl hack for that.
| * poll() is totally broken on Mac OS XDaniel Mack2009-12-164-16/+25
| | | | | | | | | | | | Even on 10.5.8, poll() does not do the right thing. Haven't checked on newer versions. Hence, wrap all occurences of poll() to pa_poll and emulate that call with select() on OSX. This is totally embarassing.
| * core-rtclock.c: tweak OS_IS_DARWIN constraintsDaniel Mack2009-12-091-41/+28
| | | | | | | | | | Move the code for OS_IS_DARWIN to the top as on Darwin, HAVE_CLOCK_GETTIME is also defined.
* | fix a number of warningsDaniel Mack2010-01-053-12/+12
| | | | | | | | | | most of them were due to missing #ifdefs or wrong printf format type for [s]size_t.
* | headers: Some trivial fixes for some documentation typosMads Kiilerich2010-01-053-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note also the willneed/will_need inconsistency. I guess it could be nice to ASAP choose one of them and introduce a backward compatibility hack for the other. The issues was mostly found with: for a in $(grep -r '^[ /]\*.*()' $( find -name '*.[ch]') | sed 's,^.* \([^ ]*\)().*$,\1,g' | sort | uniq | grep ^pa_) do grep -rq "^.[^*].*\<$a(" $(find * -name '*.h') || echo $a done
* | Subject: rtpoll: better support for DEBUG_TIMING logsPierre-Louis Bossart2010-01-051-3/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On all the platforms I tested, PulseAudio is frequently awaken and doesn't sleep for the duration specified for the poll timeout. Sometimes wake-ups occur within milliseconds of the poll call for no good reason; this seems to be related to ALSA issues (see my posts on the ALSA mailing list on null poll events). This patch enables a better log of requested sleep times v. actual sleep times. Enable DEBUG_TIMING to see actual messages. Please let me know if you see odd behaviors like the one below - Pierre E: rtpoll.c: rtpoll_run E: rtpoll.c: poll timeout: 188 ms E: rtpoll.c: Process time 0 ms; sleep time 48 ms E: rtpoll.c: rtpoll_run E: rtpoll.c: rtpoll finish E: rtpoll.c: rtpoll_run E: rtpoll.c: poll timeout: 139 ms E: rtpoll.c: Process time 0 ms; sleep time 49 ms E: rtpoll.c: rtpoll_run E: rtpoll.c: rtpoll finish E: rtpoll.c: rtpoll_run E: rtpoll.c: poll timeout: 189 ms E: rtpoll.c: Process time 0 ms; sleep time 0 ms E: rtpoll.c: rtpoll_run E: rtpoll.c: rtpoll finish E: rtpoll.c: rtpoll_run E: rtpoll.c: poll timeout: 189 ms E: rtpoll.c: Process time 0 ms; sleep time 49 ms
* | More src/pulsecore/cpu-arm.c FTBFS fixesDaniel T Chen2009-12-221-2/+3
| | | | | | | | | | | | | | Fix missing argument to pa_read(), and be consistent with declaration of state variable in pa_cpu_init_arm(). Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
* | Fix the following warnings (which now cause buildd failures in Ubuntu 10.04):Daniel T Chen2009-12-221-0/+1
|/ | | | | | | | | | | | pulsecore/cpu-arm.c: In function 'get_cpuinfo': pulsecore/cpu-arm.c:70: warning: implicit declaration of function 'pa_read' [-Wimplicit-function-declaration] pulsecore/cpu-arm.c:72: warning: implicit declaration of function 'pa_close' [-Wimplicit-function-declaration] pulsecore/cpu-arm.c: In function 'pa_cpu_init_arm': pulsecore/cpu-arm.c:110: warning: implicit declaration of function 'pa_split_spaces' [-Wimplicit-function-declaration] pulsecore/cpu-arm.c:110: warning: assignment makes pointer from integer without a cast Function `pa_split_spaces' implicitly converted to pointer at pulsecore/cpu-arm.c:110 Signed-off-by: Daniel T Chen <crimsun@ubuntu.com>
* dbus: Add a missing break statement in handle_message_cb().Tanu Kaskinen2009-12-031-0/+1
|
* dbus: Handle the cases when a non-existing interface is detected in an ↵Tanu Kaskinen2009-12-032-0/+9
| | | | incoming message.
* Merge branch 'master' of ssh://rootserver/home/lennart/git/public/pulseaudioLennart Poettering2009-11-222-16/+120
|\
| * Rename all the signal parameters and variables to something more explicit.Diego Elio 'Flameeyes' Pettenò2009-11-211-16/+16
| | | | | | | | | | Without this change, on FreeBSD you'll be bothered by tons of warnings about overshadowing signal(2).
| * freebsd: fix atomic ops implementationsJoe Marcus Clarke2009-11-211-0/+104
| | | | | | | | | | | | Stole from http://www.freebsd.org/cgi/cvsweb.cgi/ports/audio/pulseaudio/files/patch-src_pulsecore_atomic.h?rev=1.6
* | Merge branch 'master' of ssh://rootserver/home/lennart/git/public/pulseaudioLennart Poettering2009-11-203-8/+13
|\|
| * core: make cpuid code compile cleanly with 32bit PICLennart Poettering2009-11-111-2/+6
| |
| * core: adjust volume only when there is actually a memory blockLennart Poettering2009-11-111-5/+6
| | | | | | | | | | | | Fixes an assert that is hit in somne niche cases: https://bugzilla.redhat.com/show_bug.cgi?id=533482
| * protocol: use the right sample rate for sourcesWim Taymans2009-11-101-1/+1
| | | | | | | | Use the correct sample rate for reporting about the timing.
* | ramping: minor cleanupsLennart Poettering2009-11-051-2/+10
| |
* | Merge remote branch 'origin/merge-queue'Lennart Poettering2009-11-055-140/+600
|\ \ | |/ |/| | | | | | | Conflicts: src/pulsecore/sink-input.c src/pulsecore/sink.c
| * Add volume ramping feature - sink modificationmerge-queuezbt2009-08-051-1/+5
| |
| * Add volume ramping feature - sink-input modificationzbt2009-08-052-60/+312
| |
| * Add volume ramping feature - envelop fixzbt2009-08-052-65/+273
| |
* | core-util: add call to detect if we are called from within a VMLennart Poettering2009-11-052-0/+92
| |
* | daemon: make sure pa has its own session and process group, but is not its ↵Lennart Poettering2009-10-312-0/+18
| | | | | | | | leader so that we cannot acquire a tty ever
* | Mac OS X: add semaphore implementationDaniel Mack2009-10-311-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Wed, Sep 16, 2009 at 11:57:04PM +0200, Lennart Poettering wrote: > On Wed, 16.09.09 15:15, Daniel Mack (daniel@caiaq.de) wrote: > > > + s = pa_xnew(pa_semaphore, 1); > > + MPCreateSemaphore(UINT_MAX, value, &(s->sema)); > > + pa_assert(s->sema != 0); > > Hmm, I'd prefer if the ret val of MPCreateSemaphore() would be checked > here. > > Also I find it a bit weird checking for s->sema, though not > initializing it to 0 in the beginning. If the call actually failed, > then the assert will check uninitialized memory. Also, comparing > pointers with 0 sucks. That should be NULL. > > Given that this can not realisitically fail, only in OOM or OOM-like > situations in which case we abort anyway it mght be enough just writing: > > pa_assert_se(MPCreateSemaphore(UINT_MAX, value, &s->sema) == 0); > > (Assuming that success is signalled by retval == 0 on MacOSX) > > > +void pa_semaphore_free(pa_semaphore *s) { > > + pa_assert(s); > > + MPDeleteSemaphore(s->sema); > > Same here. > > > + pa_xfree(s); > > +} > > + > > +void pa_semaphore_post(pa_semaphore *s) { > > + pa_assert(s); > > + MPSignalSemaphore(s->sema); > > And here. > > > +} > > + > > +void pa_semaphore_wait(pa_semaphore *s) { > > + pa_assert(s); > > + /* should probably check return value (-ve is error), noErr is ok. */ > > + MPWaitOnSemaphore(s->sema, kDurationForever); > > And here. Ok, done. See the patch below. Daniel >From 26df2fbae6d9215a3ae084876fb5f79e4d9cf4f0 Mon Sep 17 00:00:00 2001 From: Kim Lester <kim@dfusion.com.au> Date: Wed, 16 Sep 2009 09:23:39 +0800 Subject: [PATCH] Mac OS X: add semaphore implementation
* | Wrap clock_gettime and friendsDaniel Mack2009-10-311-6/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Wed, Sep 16, 2009 at 11:48:58PM +0200, Lennart Poettering wrote: > On Wed, 16.09.09 15:15, Daniel Mack (daniel@caiaq.de) wrote: > > > From: Kim Lester <kim@dfusion.com.au> > > > > OS X does not define clockid_t or clock_gettime() and friends. > > Add a wrapper to fix this. > > Hmpf. I am not particularly happy with this. This adds a lot of > unnecessary compat code. We don't actually need implementations of > clock_getres(). All we need is some kind of check whether system > timers are accurate or whether they are rounded up to scheduling > slices. On Linux we do that check with clock_getres(), but all the > information it returns is actually not intertesting at all. We just > check if this is below some trheshold, that's all. > > clock_settime() we don't use at all! We shouldn't carry compat code > for that. > > And clock_gettime we don't really need either. We need some kind of > accurate system timers (preferably monotonic), and on Linux we use > clock_gettime() for that. But we already have a fallback there for > gettimeofday(). > > Or in other words, the current APIs pa_rtclock_get(), > pa_rtclock_hrtimer() is supposed to be the abstract API that has > different backends on different systems. I'd very much prefer if any > MacOS specific code would simply be plugged in there instead of > creating various new abstraction interfaces! Ok - what about the version below? I don't particularily like the Daniel >From 9f0a051953ec354ccdb8aa44a9845c408b26ae0b Mon Sep 17 00:00:00 2001 From: Kim Lester <kim@dfusion.com.au> Date: Wed, 16 Sep 2009 14:40:01 +0800 Subject: [PATCH] Implement pa_rtclock_get() and pa_rtclock_hrtimer() for Darwin OS X does not define clockid_t or clock_gettime() and friends. Add wrappers to fix this. Based on a patch from Kim Lester <kim@dfusion.com.au>.
* | X11: attach X11 properties to Screen, not DisplayLeszek Koltunski2009-10-301-6/+14
| |
* | svolume: fix MMX errorWim Taymans2009-10-301-1/+6
| | | | | | | | | | We need to sign extend the lower part of the multiplication before adding it to the higher part. Makes -1 * 0xffff work again.
* | sink: simplify silence checksWim Taymans2009-10-301-12/+10
| |
* | socket-util: drop redundant castsLennart Poettering2009-10-301-12/+12
| |
* | socket-util: allocate at least sizeof(sockaddr_storage) spaceLennart Poettering2009-10-301-2/+2
| |
* | use pa_fopen_cloexec() where applicableLennart Poettering2009-10-306-10/+10
| |
* | tdb: use O_CLOEXEC if availableLennart Poettering2009-10-301-9/+34
| |
* | core-util: introduce pa_fopen_cloexec()Lennart Poettering2009-10-302-2/+28
| |
generated by cgit (git 2.34.1) at 2024-04-29 06:10:07 +0000