From f61be8b654d33f3ab1b693c7e3a5d790617fbf6e Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Thu, 12 Jan 2006 16:04:21 +0000 Subject: If the card couldn't do duplex when required we would incorrectly return success from this function with a closed fd. git-svn-id: file:///home/lennart/svn/public/pulseaudio/trunk@451 fefdeb5f-60dc-0310-8127-8f9354f1896f --- polyp/oss-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'polyp') diff --git a/polyp/oss-util.c b/polyp/oss-util.c index 20a2965a..ae6772fd 100644 --- a/polyp/oss-util.c +++ b/polyp/oss-util.c @@ -57,7 +57,7 @@ int pa_oss_open(const char *device, int *mode, int* pcaps) { if (*tcaps & DSP_CAP_DUPLEX) return fd; - close(fd); + goto fail; } if ((fd = open(device, (*mode = O_WRONLY)|O_NDELAY)) < 0) { @@ -87,7 +87,7 @@ int pa_oss_open(const char *device, int *mode, int* pcaps) { fail: if (fd >= 0) close(fd); - return fd; + return -1; } int pa_oss_auto_format(int fd, pa_sample_spec *ss) { -- cgit