From 1e381fbffc190fdede27d6f27a2d113daf3e791d Mon Sep 17 00:00:00 2001 From: Colin Guthrie Date: Fri, 25 Mar 2011 23:43:26 +0000 Subject: dbus: Do not refcnt the core. We should not call pa_core_ref() anywhere in the code. Doing so will prevent proper daemon shutdown as the only call (in daemon/main.c) to pa_core_unref() should always call free_core() and perform a normal shutdown (i.e. unload all modules gracefully). --- src/modules/dbus/iface-memstats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/modules/dbus/iface-memstats.c') diff --git a/src/modules/dbus/iface-memstats.c b/src/modules/dbus/iface-memstats.c index 73a84be8..4cd692db 100644 --- a/src/modules/dbus/iface-memstats.c +++ b/src/modules/dbus/iface-memstats.c @@ -202,7 +202,7 @@ pa_dbusiface_memstats *pa_dbusiface_memstats_new(pa_dbusiface_core *dbus_core, p pa_assert(core); m = pa_xnew(pa_dbusiface_memstats, 1); - m->core = pa_core_ref(core); + m->core = core; m->path = pa_sprintf_malloc("%s/%s", PA_DBUS_CORE_OBJECT_PATH, OBJECT_NAME); m->dbus_protocol = pa_dbus_protocol_get(core); @@ -219,7 +219,6 @@ void pa_dbusiface_memstats_free(pa_dbusiface_memstats *m) { pa_xfree(m->path); pa_dbus_protocol_unref(m->dbus_protocol); - pa_core_unref(m->core); pa_xfree(m); } -- cgit