From 596e1792e0b8af3b600db4b82ad9967815642803 Mon Sep 17 00:00:00 2001 From: Arun Raghavan Date: Thu, 2 Dec 2010 16:30:59 +0530 Subject: rescue-streams: Fix segfault in some conditions There is a call to this function where 'skip' variable is NULL. Looks like this code doesn't get hit very often, probably because a suitable default sink can be found to move the stream to. However, if we can't move to the default sink and skip is NULL, there will be a segfault. --- src/modules/module-rescue-streams.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/modules/module-rescue-streams.c') diff --git a/src/modules/module-rescue-streams.c b/src/modules/module-rescue-streams.c index 722d84b2..2fcd21f0 100644 --- a/src/modules/module-rescue-streams.c +++ b/src/modules/module-rescue-streams.c @@ -159,7 +159,7 @@ static pa_source* find_evacuation_source(pa_core *c, pa_source_output *o, pa_sou if (target == skip) continue; - if (!target->monitor_of != !skip->monitor_of) + if (skip && !target->monitor_of != !skip->monitor_of) continue; if (!PA_SOURCE_IS_LINKED(pa_source_get_state(target))) -- cgit