summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve Langasek <steve.langasek@canonical.com>2009-02-11 18:36:34 -0500
committerWilliam Jon McCann <jmccann@redhat.com>2009-02-11 18:36:34 -0500
commit1ddd056da19a9e99b10601a557ebbcaf101d0de9 (patch)
treef4d331017daa6ece7d8f6f58f892405d6fda2ec2
parenta00c329d81be8691e13915ed36f5053bd0f820f3 (diff)
close directory to fix leak
Chris Jones observed that console-kit-daemon had open a large number of redundant file descriptors, pointing to /etc/ConsoleKit/run-session.d and /usr/lib/ConsoleKit/run-session.d. It turns out that ck_run_programs() doesn't close the directory handles after iterating, resulting in a fd leak and a small memory leak. The attached patch corrects this.
-rw-r--r--src/ck-run-programs.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/ck-run-programs.c b/src/ck-run-programs.c
index f9d62c7..933fd93 100644
--- a/src/ck-run-programs.c
+++ b/src/ck-run-programs.c
@@ -225,6 +225,7 @@ ck_run_programs (const char *dirpath,
out_loop:
g_free (child_argv[0]);
}
+ g_dir_close (dir);
out:
g_strfreev (env_for_child);
}