summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHavoc Pennington <hp@redhat.com>2003-01-06 16:19:26 +0000
committerHavoc Pennington <hp@redhat.com>2003-01-06 16:19:26 +0000
commit5cf7ec5c399537b89fdbf6637413c4d2c002f4a4 (patch)
tree5f402fe894974b6a0ea42cab19b950e97d5193ec
parent96a9f80300b7794475a5451a60a07555ea3526be (diff)
add a comment about needed fix for dbus_static_mutex_lock
-rw-r--r--dbus/dbus-threads.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/dbus/dbus-threads.c b/dbus/dbus-threads.c
index 434148b8..b132e8a4 100644
--- a/dbus/dbus-threads.c
+++ b/dbus/dbus-threads.c
@@ -172,12 +172,18 @@ dbus_threads_init (const DBusThreadFunctions *functions)
/**
* Lock a static mutex
*
+ * @todo currently broken on some platforms due to
+ * non-workingness of "double checked locking"
+ * see http://bugzilla.gnome.org/show_bug.cgi?id=69668
+ * and http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html
+ * for example.
+ *
* @param mutex the mutex to lock
* @returns #TRUE on success
*/
dbus_bool_t
dbus_static_mutex_lock (DBusStaticMutex *mutex)
-{
+{
if (_DBUS_STATIC_MUTEX_IMPL (mutex))
return dbus_mutex_lock (_DBUS_STATIC_MUTEX_IMPL (mutex));