summaryrefslogtreecommitdiffstats
path: root/ext/libpng/gstpngenc.c
diff options
context:
space:
mode:
authorChristophe Fergeau <teuf@gnome.org>2004-03-06 20:56:27 +0000
committerChristophe Fergeau <teuf@gnome.org>2004-03-06 20:56:27 +0000
commit89bbfdc3683c00f14cf7142cd19faadaf2ccc1c8 (patch)
treef15690de330dcca1c0a8626706d78de0c21d5ddc /ext/libpng/gstpngenc.c
parent905db051a9c0e5559a760990044e6a205dd2cfdf (diff)
Fix several misuse of gst_buffer_merge (it doesn't take ownership of any buffer), should fix some leaks. I hope I did...
Original commit message from CVS: 2004-03-06 Christophe Fergeau <teuf@gnome.org> * ext/faac/gstfaac.c: (gst_faac_chain): * ext/flac/gstflactag.c: (gst_flac_tag_chain): * ext/libpng/gstpngenc.c: (user_write_data): * ext/mikmod/gstmikmod.c: (gst_mikmod_loop): * gst/ac3parse/gstac3parse.c: (gst_ac3parse_chain): * gst/mpeg2sub/gstmpeg2subt.c: (gst_mpeg2subt_chain_subtitle): * gst/mpegstream/gstrfc2250enc.c: (gst_rfc2250_enc_add_slice): Fix several misuse of gst_buffer_merge (it doesn't take ownership of any buffer), should fix some leaks. I hope I didn't unref buffers that shouldn't be...
Diffstat (limited to 'ext/libpng/gstpngenc.c')
-rw-r--r--ext/libpng/gstpngenc.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/ext/libpng/gstpngenc.c b/ext/libpng/gstpngenc.c
index 8af25d38..393e642c 100644
--- a/ext/libpng/gstpngenc.c
+++ b/ext/libpng/gstpngenc.c
@@ -207,8 +207,11 @@ void user_write_data (png_structp png_ptr, png_bytep data, png_uint_32 length)
if (pngenc->buffer_out)
{
- pngenc->buffer_out = gst_buffer_merge (pngenc->buffer_out, buffer);
+ GstBuffer *merge;
+ merge = gst_buffer_merge (pngenc->buffer_out, buffer);
gst_buffer_unref (buffer);
+ gst_buffer_unref (pngenc->buffer_out);
+ pngenc->buffer_out = merge;
}
else
pngenc->buffer_out = buffer;