Ported the gstfilter plugin to GStreamer 0.10.

Original commit message from CVS:
Patch by: Mathis Hofer <mathis dot hofer at dreamlab dot net>
* configure.ac:
* gst/filter/Makefile.am:
* gst/filter/gstbpwsinc.c: (gst_bpwsinc_dispose),
(gst_bpwsinc_base_init), (gst_bpwsinc_class_init),
(gst_bpwsinc_init), (bpwsinc_set_caps), (bpwsinc_transform_ip),
(bpwsinc_set_property), (bpwsinc_get_property):
* gst/filter/gstfilter.c: (plugin_init):
* gst/filter/gstfilter.h:
* gst/filter/gstiir.c: (gst_iir_dispose), (gst_iir_base_init),
(gst_iir_class_init), (gst_iir_init), (iir_set_caps),
(iir_transform_ip), (iir_set_property), (iir_get_property):
* gst/filter/gstlpwsinc.c: (gst_lpwsinc_dispose),
(gst_lpwsinc_base_init), (gst_lpwsinc_class_init),
(gst_lpwsinc_init), (lpwsinc_set_caps), (lpwsinc_transform_ip),
(lpwsinc_set_property), (lpwsinc_get_property):
Ported the gstfilter plugin to GStreamer 0.10.

1 files changed, 201 insertions, 237 deletions

diff --git a/gst/audiofx/audiowsincband.c b/gst/audiofx/audiowsincband.c
index f94e201b..07175dee 100644
--- a/gst/audiofx/audiowsincband.c
+++ b/gst/audiofx/audiowsincband.c
@@ -1,6 +1,8 @@
 /* -*- c-basic-offset: 2 -*-
+ * 
  * GStreamer
  * Copyright (C) 1999-2001 Erik Walthinsen <omega@cse.ogi.edu>
+ *               2006 Dreamlab Technologies Ltd. <mathis.hofer@dreamlab.net>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ -16,15 +18,14 @@
  * License along with this library; if not, write to the
  * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
  * Boston, MA 02111-1307, USA.
- */
-
-/* this windowed sinc filter is taken from the freely downloadable DSP book,
+ * 
+ * 
+ * this windowed sinc filter is taken from the freely downloadable DSP book,
  * "The Scientist and Engineer's Guide to Digital Signal Processing",
  * chapter 16
  * available at http://www.dspguide.com/
- */
-
-/* FIXME:
+ *
+ * FIXME:
  * - this filter is totally unoptimized !
  * - we do not destroy the allocated memory for filters and residue
  * - this might be improved upon with bytestream
@@ -33,18 +34,27 @@
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
+
+#include <string.h>
+#include <math.h>
 #include <gst/gst.h>
-#include "gstfilter.h"
-#include <math.h>               /* M_PI */
-#include <string.h>             /* memmove */
+#include <gst/base/gstbasetransform.h>
+#include <gst/controller/gstcontroller.h>
 
-/* elementfactory information */
-static const GstElementDetails gst_bpwsinc_details =
-GST_ELEMENT_DETAILS ("BPWSinc",
+#include "gstbpwsinc.h"
+
+#define GST_CAT_DEFAULT gst_bpwsinc_debug
+GST_DEBUG_CATEGORY_STATIC (GST_CAT_DEFAULT);
+
+static const GstElementDetails bpwsinc_details =
+GST_ELEMENT_DETAILS ("Band-pass Windowed sinc filter",
     "Filter/Effect/Audio",
-    "Band-Pass Windowed sinc filter",
-    "Thomas <thomas@apestaart.org>, " "Steven W. Smith");
+    "Band-pass Windowed sinc filter",
+    "Thomas <thomas@apestaart.org>, "
+    "Steven W. Smith, "
+    "Dreamlab Technologies Ltd. <mathis.hofer@dreamlab.net>");
 
+/* Filter signals and args */
 enum
 {
   /* FILL ME */
@@ -53,82 +63,54 @@ enum
 
 enum
 {
-  ARG_0,
-  ARG_LENGTH,
-  ARG_LOWER_FREQUENCY,
-  ARG_UPPER_FREQUENCY
-};
-
-#define GST_TYPE_BPWSINC \
-  (gst_bpwsinc_get_type())
-#define GST_BPWSINC(obj) \
-      (G_TYPE_CHECK_INSTANCE_CAST((obj),GST_TYPE_BPWSINC,GstBPWSinc))
-#define GST_BPWSINC_CLASS(klass) \
-      (G_TYPE_CHECK_CLASS_CAST((klass),GST_TYPE_ULAW,GstBPWSinc))
-#define GST_IS_BPWSINC(obj) \
-      (G_TYPE_CHECK_INSTANCE_TYPE((obj),GST_TYPE_BPWSINC))
-#define GST_IS_BPWSINC_CLASS(obj) \
-      (G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_BPWSINC))
-
-typedef struct _GstBPWSinc GstBPWSinc;
-typedef struct _GstBPWSincClass GstBPWSincClass;
-
-struct _GstBPWSinc
-{
-  GstElement element;
-
-  GstPad *sinkpad, *srcpad;
-
-  double frequency;
-  double lower_frequency, upper_frequency;
-  int wing_size;                /* length of a "wing" of the filter; 
-                                   actual length is 2 * wing_size + 1 */
-
-  gfloat *residue;              /* buffer for left-over samples from previous buffer */
-  double *kernel;
-};
-
-struct _GstBPWSincClass
-{
-  GstElementClass parent_class;
+  PROP_0,
+  PROP_LENGTH,
+  PROP_LOWER_FREQUENCY,
+  PROP_UPPER_FREQUENCY
 };
 
-static void gst_bpwsinc_base_init (gpointer g_class);
-static void gst_bpwsinc_class_init (GstBPWSincClass * klass);
-static void gst_bpwsinc_init (GstBPWSinc * filter);
-
-static void gst_bpwsinc_set_property (GObject * object, guint prop_id,
+static GstStaticPadTemplate bpwsinc_sink_template =
+GST_STATIC_PAD_TEMPLATE ("sink",
+    GST_PAD_SINK,
+    GST_PAD_ALWAYS,
+    GST_STATIC_CAPS ("audio/x-raw-float, "
+        "rate = (int) [ 1, MAX ], "
+        "channels = (int) [ 1, MAX ], "
+        "endianness = (int) BYTE_ORDER, " "width = (int) 32")
+    );
+
+static GstStaticPadTemplate bpwsinc_src_template = GST_STATIC_PAD_TEMPLATE
+    ("src",
+    GST_PAD_SRC,
+    GST_PAD_ALWAYS,
+    GST_STATIC_CAPS ("audio/x-raw-float, "
+        "rate = (int) [ 1, MAX ], "
+        "channels = (int) [ 1, MAX ], "
+        "endianness = (int) BYTE_ORDER, " "width = (int) 32")
+    );
+
+#define DEBUG_INIT(bla) \
+  GST_DEBUG_CATEGORY_INIT (gst_bpwsinc_debug, "bpwsinc", 0, "Band-pass Windowed sinc filter plugin");
+
+GST_BOILERPLATE_FULL (GstBPWSinc, gst_bpwsinc, GstBaseTransform,
+    GST_TYPE_BASE_TRANSFORM, DEBUG_INIT);
+
+static void bpwsinc_set_property (GObject * object, guint prop_id,
     const GValue * value, GParamSpec * pspec);
-static void gst_bpwsinc_get_property (GObject * object, guint prop_id,
+static void bpwsinc_get_property (GObject * object, guint prop_id,
     GValue * value, GParamSpec * pspec);
 
-static void gst_bpwsinc_chain (GstPad * pad, GstData * _data);
-static GstPadLinkReturn
-gst_bpwsinc_sink_connect (GstPad * pad, const GstCaps * caps);
-
-static GstElementClass *parent_class = NULL;
+static GstFlowReturn bpwsinc_transform_ip (GstBaseTransform * base,
+    GstBuffer * outbuf);
+static gboolean bpwsinc_set_caps (GstBaseTransform * base, GstCaps * incaps,
+    GstCaps * outcaps);
 
-/*static guint gst_bpwsinc_signals[LAST_SIGNAL] = { 0 }; */
+/* Element class */
 
-GType
-gst_bpwsinc_get_type (void)
+static void
+gst_bpwsinc_dispose (GObject * object)
 {
-  static GType bpwsinc_type = 0;
-
-  if (!bpwsinc_type) {
-    static const GTypeInfo bpwsinc_info = {
-      sizeof (GstBPWSincClass),
-      gst_bpwsinc_base_init,
-      NULL,
-      (GClassInitFunc) gst_bpwsinc_class_init, NULL, NULL,
-      sizeof (GstBPWSinc), 0,
-      (GInstanceInitFunc) gst_bpwsinc_init,
-    };
-
-    bpwsinc_type = g_type_register_static (GST_TYPE_ELEMENT, "GstBPWSinc",
-        &bpwsinc_info, 0);
-  }
-  return bpwsinc_type;
+  G_OBJECT_CLASS (parent_class)->dispose (object);
 }
 
 static void
@@ -136,195 +118,181 @@ gst_bpwsinc_base_init (gpointer g_class)
 {
   GstElementClass *element_class = GST_ELEMENT_CLASS (g_class);
 
-  /* register src pads */
   gst_element_class_add_pad_template (element_class,
-      gst_static_pad_template_get (&gst_filter_src_template));
+      gst_static_pad_template_get (&bpwsinc_src_template));
   gst_element_class_add_pad_template (element_class,
-      gst_static_pad_template_get (&gst_filter_sink_template));
-
-  gst_element_class_set_details (element_class, &gst_bpwsinc_details);
+      gst_static_pad_template_get (&bpwsinc_sink_template));
+  gst_element_class_set_details (element_class, &bpwsinc_details);
 }
 
 static void
 gst_bpwsinc_class_init (GstBPWSincClass * klass)
 {
   GObjectClass *gobject_class;
-  GstElementClass *gstelement_class;
+  GstBaseTransformClass *trans_class;
 
   gobject_class = (GObjectClass *) klass;
-  gstelement_class = (GstElementClass *) klass;
+  trans_class = (GstBaseTransformClass *) klass;
 
-  parent_class = g_type_class_peek_parent (klass);
+  gobject_class->set_property = bpwsinc_set_property;
+  gobject_class->get_property = bpwsinc_get_property;
+  gobject_class->dispose = gst_bpwsinc_dispose;
 
-  g_object_class_install_property (G_OBJECT_CLASS (klass), ARG_LOWER_FREQUENCY,
+  g_object_class_install_property (gobject_class, PROP_LOWER_FREQUENCY,
       g_param_spec_double ("lower-frequency", "Lower Frequency",
           "Cut-off lower frequency (relative to sample rate)",
           0.0, 0.5, 0, G_PARAM_READWRITE));
-  g_object_class_install_property (G_OBJECT_CLASS (klass), ARG_UPPER_FREQUENCY,
+  g_object_class_install_property (gobject_class, PROP_UPPER_FREQUENCY,
       g_param_spec_double ("upper-frequency", "Upper Frequency",
           "Cut-off upper frequency (relative to sample rate)",
           0.0, 0.5, 0, G_PARAM_READWRITE));
-  g_object_class_install_property (G_OBJECT_CLASS (klass), ARG_LENGTH,
+  g_object_class_install_property (gobject_class, PROP_LENGTH,
       g_param_spec_int ("length", "Length",
           "N such that the filter length = 2N + 1",
           1, G_MAXINT, 1, G_PARAM_READWRITE));
 
-  gobject_class->set_property = gst_bpwsinc_set_property;
-  gobject_class->get_property = gst_bpwsinc_get_property;
+  trans_class->transform_ip = GST_DEBUG_FUNCPTR (bpwsinc_transform_ip);
+  trans_class->set_caps = GST_DEBUG_FUNCPTR (bpwsinc_set_caps);
 }
 
 static void
-gst_bpwsinc_init (GstBPWSinc * filter)
+gst_bpwsinc_init (GstBPWSinc * this, GstBPWSincClass * g_class)
 {
-  filter->sinkpad =
-      gst_pad_new_from_template (gst_static_pad_template_get
-      (&gst_filter_sink_template), "sink");
-  gst_pad_set_chain_function (filter->sinkpad, gst_bpwsinc_chain);
-  gst_pad_set_link_function (filter->sinkpad, gst_bpwsinc_sink_connect);
-  gst_element_add_pad (GST_ELEMENT (filter), filter->sinkpad);
-
-  filter->srcpad =
-      gst_pad_new_from_template (gst_static_pad_template_get
-      (&gst_filter_src_template), "src");
-  gst_element_add_pad (GST_ELEMENT (filter), filter->srcpad);
-
-  filter->wing_size = 50;
-  filter->lower_frequency = 0.25;
-  filter->upper_frequency = 0.3;
-  filter->kernel = NULL;
+  this->wing_size = 50;
+  this->lower_frequency = 0.25;
+  this->upper_frequency = 0.3;
+  this->kernel = NULL;
 }
 
-static GstPadLinkReturn
-gst_bpwsinc_sink_connect (GstPad * pad, const GstCaps * caps)
+
+/* GstBaseTransform vmethod implementations */
+
+/* get notified of caps and plug in the correct process function */
+static gboolean
+bpwsinc_set_caps (GstBaseTransform * base, GstCaps * incaps, GstCaps * outcaps)
 {
   int i = 0;
   double sum = 0.0;
   int len = 0;
   double *kernel_lp, *kernel_hp;
-  GstPadLinkReturn set_retval;
-
-  GstBPWSinc *filter = GST_BPWSINC (gst_pad_get_parent (pad));
-
-  g_assert (GST_IS_PAD (pad));
-  g_assert (caps != NULL);
-
-  set_retval = gst_pad_try_set_caps (filter->srcpad, caps);
-
-  if (set_retval > 0) {
-    len = filter->wing_size;
-    /* fill the lp kernel */
-    GST_DEBUG ("bpwsinc: initializing LP kernel of length %d with cut-off %f",
-        len * 2 + 1, filter->lower_frequency);
-    kernel_lp = (double *) g_malloc (sizeof (double) * (2 * len + 1));
-    for (i = 0; i <= len * 2; ++i) {
-      if (i == len)
-        kernel_lp[i] = 2 * M_PI * filter->lower_frequency;
-      else
-        kernel_lp[i] = sin (2 * M_PI * filter->lower_frequency * (i - len))
-            / (i - len);
-      /* Blackman windowing */
-      kernel_lp[i] *= (0.42 - 0.5 * cos (M_PI * i / len)
-          + 0.08 * cos (2 * M_PI * i / len));
-    }
-
-    /* normalize for unity gain at DC
-     * FIXME: sure this is not supposed to be quadratic ? */
-    sum = 0.0;
-    for (i = 0; i <= len * 2; ++i)
-      sum += kernel_lp[i];
-    for (i = 0; i <= len * 2; ++i)
-      kernel_lp[i] /= sum;
-
-    /* fill the hp kernel */
-    GST_DEBUG ("bpwsinc: initializing HP kernel of length %d with cut-off %f",
-        len * 2 + 1, filter->upper_frequency);
-    kernel_hp = (double *) g_malloc (sizeof (double) * (2 * len + 1));
-    for (i = 0; i <= len * 2; ++i) {
-      if (i == len)
-        kernel_hp[i] = 2 * M_PI * filter->upper_frequency;
-      else
-        kernel_hp[i] = sin (2 * M_PI * filter->upper_frequency * (i - len))
-            / (i - len);
-      /* Blackman windowing */
-      kernel_hp[i] *= (0.42 - 0.5 * cos (M_PI * i / len)
-          + 0.08 * cos (2 * M_PI * i / len));
-    }
-
-    /* normalize for unity gain at DC
-     * FIXME: sure this is not supposed to be quadratic ? */
-    sum = 0.0;
-    for (i = 0; i <= len * 2; ++i)
-      sum += kernel_hp[i];
-    for (i = 0; i <= len * 2; ++i)
-      kernel_hp[i] /= sum;
-
-    /* do spectral inversion to get a HP filter */
-    for (i = 0; i <= len * 2; ++i)
-      kernel_hp[i] = -kernel_hp[i];
-    kernel_hp[len] += 1;
-
-    /* combine the two filters */
-
-    filter->kernel = (double *) g_malloc (sizeof (double) * (2 * len + 1));
-
-    for (i = 0; i <= len * 2; ++i)
-      filter->kernel[i] = kernel_lp[i] + kernel_hp[i];
-
-    /* do spectral inversion to go from band reject to bandpass */
-    for (i = 0; i <= len * 2; ++i)
-      filter->kernel[i] = -filter->kernel[i];
-    filter->kernel[len] += 1;
-
-    /* free the helper kernels */
-    g_free (kernel_lp);
-    g_free (kernel_hp);
-
-    /* set up the residue memory space */
-    filter->residue = (gfloat *) g_malloc (sizeof (gfloat) * (len * 2 + 1));
-    for (i = 0; i <= len * 2; ++i)
-      filter->residue[i] = 0.0;
+  GstBPWSinc *this = GST_BPWSINC (base);
+
+  GST_DEBUG_OBJECT (this,
+      "set_caps: in %" GST_PTR_FORMAT " out %" GST_PTR_FORMAT, incaps, outcaps);
+
+  len = this->wing_size;
+  /* fill the lp kernel */
+  GST_DEBUG ("bpwsinc: initializing LP kernel of length %d with cut-off %f",
+      len * 2 + 1, this->lower_frequency);
+  kernel_lp = (double *) g_malloc (sizeof (double) * (2 * len + 1));
+  for (i = 0; i <= len * 2; ++i) {
+    if (i == len)
+      kernel_lp[i] = 2 * M_PI * this->lower_frequency;
+    else
+      kernel_lp[i] = sin (2 * M_PI * this->lower_frequency * (i - len))
+          / (i - len);
+    /* Blackman windowing */
+    kernel_lp[i] *= (0.42 - 0.5 * cos (M_PI * i / len)
+        + 0.08 * cos (2 * M_PI * i / len));
+  }
+
+  /* normalize for unity gain at DC
+   * FIXME: sure this is not supposed to be quadratic ? */
+  sum = 0.0;
+  for (i = 0; i <= len * 2; ++i)
+    sum += kernel_lp[i];
+  for (i = 0; i <= len * 2; ++i)
+    kernel_lp[i] /= sum;
+
+  /* fill the hp kernel */
+  GST_DEBUG ("bpwsinc: initializing HP kernel of length %d with cut-off %f",
+      len * 2 + 1, this->upper_frequency);
+  kernel_hp = (double *) g_malloc (sizeof (double) * (2 * len + 1));
+  for (i = 0; i <= len * 2; ++i) {
+    if (i == len)
+      kernel_hp[i] = 2 * M_PI * this->upper_frequency;
+    else
+      kernel_hp[i] = sin (2 * M_PI * this->upper_frequency * (i - len))
+          / (i - len);
+    /* Blackman windowing */
+    kernel_hp[i] *= (0.42 - 0.5 * cos (M_PI * i / len)
+        + 0.08 * cos (2 * M_PI * i / len));
   }
 
-  return set_retval;
+  /* normalize for unity gain at DC
+   * FIXME: sure this is not supposed to be quadratic ? */
+  sum = 0.0;
+  for (i = 0; i <= len * 2; ++i)
+    sum += kernel_hp[i];
+  for (i = 0; i <= len * 2; ++i)
+    kernel_hp[i] /= sum;
+
+  /* combine the two thiss */
+  this->kernel = (double *) g_malloc (sizeof (double) * (2 * len + 1));
+
+  for (i = 0; i <= len * 2; ++i)
+    this->kernel[i] = kernel_lp[i] + kernel_hp[i];
+
+  /* do spectral inversion to go from band reject to bandpass */
+  for (i = 0; i <= len * 2; ++i)
+    this->kernel[i] = -this->kernel[i];
+  this->kernel[len] += 1;
+
+  /* free the helper kernels */
+  g_free (kernel_lp);
+  g_free (kernel_hp);
+
+  /* set up the residue memory space */
+  this->residue = (gfloat *) g_malloc (sizeof (gfloat) * (len * 2 + 1));
+  for (i = 0; i <= len * 2; ++i)
+    this->residue[i] = 0.0;
+
+  return TRUE;
 }
 
-static void
-gst_bpwsinc_chain (GstPad * pad, GstData * _data)
+static GstFlowReturn
+bpwsinc_transform_ip (GstBaseTransform * base, GstBuffer * outbuf)
 {
-  GstBuffer *buf = GST_BUFFER (_data);
-  GstBPWSinc *filter;
+  GstBPWSinc *this = GST_BPWSINC (base);
+  GstClockTime timestamp;
+
+  /* don't process data in passthrough-mode */
+  if (gst_base_transform_is_passthrough (base))
+    return GST_FLOW_OK;
+
+  /* FIXME: subdivide GST_BUFFER_SIZE into small chunks for smooth fades */
+  timestamp = GST_BUFFER_TIMESTAMP (outbuf);
+
+  if (GST_CLOCK_TIME_IS_VALID (timestamp))
+    gst_object_sync_values (G_OBJECT (this), timestamp);
+
   gfloat *src;
   gfloat *input;
-  gint residue_samples;
+  int residue_samples;
   gint input_samples;
   gint total_samples;
   int i, j;
 
-  filter = GST_BPWSINC (gst_pad_get_parent (pad));
-
   /* FIXME: out of laziness, we copy the left-over bit from last buffer
    * together with the incoming buffer to a new buffer to make the loop
    * easy; this could be a lot more optimized though
    * to make amends we keep the incoming buffer around and write our
    * output samples there */
 
-  /* get a writable buffer */
-  buf = gst_buffer_copy_on_write (buf);
-
-  src = (gfloat *) GST_BUFFER_DATA (buf);
-  residue_samples = filter->wing_size * 2 + 1;
-  input_samples = GST_BUFFER_SIZE (buf) / sizeof (gfloat);
+  src = (gfloat *) GST_BUFFER_DATA (outbuf);
+  residue_samples = this->wing_size * 2 + 1;
+  input_samples = GST_BUFFER_SIZE (outbuf) / sizeof (gfloat);
   total_samples = residue_samples + input_samples;
 
   input = (gfloat *) g_malloc (sizeof (gfloat) * total_samples);
 
   /* copy the left-over bit */
-  memcpy (input, filter->residue, sizeof (gfloat) * residue_samples);
+  memcpy (input, this->residue, sizeof (gfloat) * residue_samples);
 
   /* copy the new buffer */
   memcpy (&input[residue_samples], src, sizeof (gfloat) * input_samples);
   /* copy the tail of the current input buffer to the residue */
-  memcpy (filter->residue, &src[input_samples - residue_samples],
+  memcpy (this->residue, &src[input_samples - residue_samples],
       sizeof (gfloat) * residue_samples);
 
   /* convolution */
@@ -333,57 +301,53 @@ gst_bpwsinc_chain (GstPad * pad, GstData * _data)
   for (i = 0; i < input_samples; ++i) {
     src[i] = 0.0;
     for (j = 0; j < residue_samples; ++j)
-      src[i] += input[i - j + residue_samples] * filter->kernel[j];
+      src[i] += input[i - j + residue_samples] * this->kernel[j];
   }
 
   g_free (input);
-  gst_pad_push (filter->srcpad, GST_DATA (buf));
+
+  return GST_FLOW_OK;
 }
 
 static void
-gst_bpwsinc_set_property (GObject * object, guint prop_id, const GValue * value,
+bpwsinc_set_property (GObject * object, guint prop_id, const GValue * value,
     GParamSpec * pspec)
 {
-  GstBPWSinc *filter;
-
-  g_return_if_fail (GST_IS_BPWSINC (object));
+  GstBPWSinc *this = GST_BPWSINC (object);
 
-  filter = GST_BPWSINC (object);
+  g_return_if_fail (GST_IS_BPWSINC (this));
 
   switch (prop_id) {
-    case ARG_LENGTH:
-      filter->wing_size = g_value_get_int (value);
+    case PROP_LENGTH:
+      this->wing_size = g_value_get_int (value);
       break;
-    case ARG_LOWER_FREQUENCY:
-      filter->lower_frequency = g_value_get_double (value);
+    case PROP_LOWER_FREQUENCY:
+      this->lower_frequency = g_value_get_double (value);
       break;
-    case ARG_UPPER_FREQUENCY:
-      filter->upper_frequency = g_value_get_double (value);
+    case PROP_UPPER_FREQUENCY:
+      this->upper_frequency = g_value_get_double (value);
       break;
     default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
   }
 }
 
 static void
-gst_bpwsinc_get_property (GObject * object, guint prop_id, GValue * value,
+bpwsinc_get_property (GObject * object, guint prop_id, GValue * value,
     GParamSpec * pspec)
 {
-  GstBPWSinc *filter;
-
-  g_return_if_fail (GST_IS_BPWSINC (object));
-
-  filter = GST_BPWSINC (object);
+  GstBPWSinc *this = GST_BPWSINC (object);
 
   switch (prop_id) {
-    case ARG_LENGTH:
-      g_value_set_int (value, filter->wing_size);
+    case PROP_LENGTH:
+      g_value_set_int (value, this->wing_size);
       break;
-    case ARG_LOWER_FREQUENCY:
-      g_value_set_double (value, filter->lower_frequency);
+    case PROP_LOWER_FREQUENCY:
+      g_value_set_double (value, this->lower_frequency);
       break;
-    case ARG_UPPER_FREQUENCY:
-      g_value_set_double (value, filter->upper_frequency);
+    case PROP_UPPER_FREQUENCY:
+      g_value_set_double (value, this->upper_frequency);
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);