Add unit test for aspectratiocrop Fixes bug #527951

Add unit test for aspectratiocrop and refactor this element. Added
finalize function to cleanup leaking mutex.

2 files changed, 208 insertions, 6 deletions

diff --git a/tests/check/Makefile.am b/tests/check/Makefile.am
index 89a151c4..2fd65b36 100644
--- a/tests/check/Makefile.am
+++ b/tests/check/Makefile.am
@@ -68,17 +68,18 @@ check_PROGRAMS = \
 	generic/states \
 	$(check_annodex) \
 	elements/alphacolor \
-	elements/audiopanorama \
-	elements/audioinvert \
+	elements/aspectratiocrop \
+	elements/audioamplify \
 	elements/audiochebband \
 	elements/audiocheblimit \
-	elements/audioiirfilter \
-	elements/audioamplify \
-	elements/audioecho \
 	elements/audiodynamic \
+	elements/audioecho \
+	elements/audiofirfilter \
+	elements/audioiirfilter \
+	elements/audioinvert \
+	elements/audiopanorama \
 	elements/audiowsincband \
 	elements/audiowsinclimit \
-	elements/audiofirfilter \
 	elements/avimux \
 	elements/avisubtitle \
 	elements/deinterleave \
diff --git a/tests/check/elements/aspectratiocrop.c b/tests/check/elements/aspectratiocrop.c
new file mode 100644
index 00000000..4f805520
--- /dev/null
+++ b/tests/check/elements/aspectratiocrop.c
@@ -0,0 +1,201 @@
+/* GStreamer unit test for the aspectratiocrop element
+ * Copyright (C) 2009 Thijs Vermeir <thijsvermeir@gmail.com>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+ * Boston, MA 02111-1307, USA.
+ */
+
+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
+#include <gst/gst.h>
+#include <gst/video/video.h>
+#include <gst/check/gstcheck.h>
+
+#define ASPECT_RATIO_CROP_CAPS                   \
+  GST_VIDEO_CAPS_RGBx ";"                        \
+  GST_VIDEO_CAPS_xRGB ";"                        \
+  GST_VIDEO_CAPS_BGRx ";"                        \
+  GST_VIDEO_CAPS_xBGR ";"                        \
+  GST_VIDEO_CAPS_RGBA ";"                        \
+  GST_VIDEO_CAPS_ARGB ";"                        \
+  GST_VIDEO_CAPS_BGRA ";"                        \
+  GST_VIDEO_CAPS_ABGR ";"                        \
+  GST_VIDEO_CAPS_RGB ";"                         \
+  GST_VIDEO_CAPS_BGR ";"                         \
+  GST_VIDEO_CAPS_YUV ("AYUV") ";"                \
+  GST_VIDEO_CAPS_YUV ("YUY2") ";"                \
+  GST_VIDEO_CAPS_YUV ("YVYU") ";"                \
+  GST_VIDEO_CAPS_YUV ("UYVY") ";"                \
+  GST_VIDEO_CAPS_YUV ("Y800") ";"                \
+  GST_VIDEO_CAPS_YUV ("I420") ";"                \
+  GST_VIDEO_CAPS_YUV ("YV12") ";"                \
+  GST_VIDEO_CAPS_RGB_16 ";"                      \
+  GST_VIDEO_CAPS_RGB_15
+
+GstBuffer *
+make_buffer_with_caps (const gchar * caps_string, int buffer_size)
+{
+  GstCaps *caps;
+  GstBuffer *temp;
+
+  caps = gst_caps_from_string (caps_string);
+  temp = gst_buffer_new_and_alloc (buffer_size);
+  fail_if (caps == NULL);
+  fail_if (temp == NULL);
+  gst_buffer_set_caps (temp, caps);
+  gst_caps_unref (caps);
+
+  return temp;
+}
+
+void
+check_aspectratiocrop (const gchar * in_string, const gchar * out_string,
+    gint in_size, gint out_size, gint ar_n, gint ar_d)
+{
+  GstElement *element;
+  GstPad *pad_peer;
+  GstPad *sink_pad = NULL;
+  GstPad *src_pad;
+  GstBuffer *new;
+  GstBuffer *buffer;
+  GstBuffer *buffer_out;
+  GstCaps *sink_caps;
+
+  buffer = make_buffer_with_caps (in_string, in_size);
+  buffer_out = make_buffer_with_caps (out_string, out_size);
+
+  /* check that there are no buffers waiting */
+  gst_check_drop_buffers ();
+
+  /* create the element */
+  element = gst_check_setup_element ("aspectratiocrop");
+
+  /* set the requested aspect ratio */
+  g_object_set (G_OBJECT (element), "aspect-ratio", ar_n, ar_d, NULL);
+
+  /* create the src pad */
+  src_pad = gst_pad_new (NULL, GST_PAD_SRC);
+  gst_pad_set_caps (src_pad, GST_BUFFER_CAPS (buffer));
+  pad_peer = gst_element_get_static_pad (element, "sink");
+  fail_if (pad_peer == NULL);
+  fail_unless (gst_pad_link (src_pad, pad_peer) == GST_PAD_LINK_OK,
+      "Could not link source and %s sink pads", GST_ELEMENT_NAME (element));
+  gst_object_unref (pad_peer);
+  gst_pad_set_active (src_pad, TRUE);
+
+  /* create the sink pad */
+  pad_peer = gst_element_get_static_pad (element, "src");
+  sink_caps = gst_caps_from_string (ASPECT_RATIO_CROP_CAPS);
+  sink_pad = gst_pad_new (NULL, GST_PAD_SINK);
+  GST_PAD_CAPS (sink_pad) = sink_caps;
+  fail_unless (gst_pad_link (pad_peer, sink_pad) == GST_PAD_LINK_OK,
+      "Could not link sink and %s source pads", GST_ELEMENT_NAME (element));
+  gst_object_unref (pad_peer);
+  gst_pad_set_chain_function (sink_pad, gst_check_chain_func);
+  gst_pad_set_active (sink_pad, TRUE);
+
+  /* configure the sink pad */
+  fail_unless (gst_element_set_state (element,
+          GST_STATE_PLAYING) == GST_STATE_CHANGE_SUCCESS,
+      "could not set to playing");
+  fail_unless (gst_pad_push (src_pad, buffer) == GST_FLOW_OK,
+      "Failed to push buffer");
+  fail_unless (gst_element_set_state (element,
+          GST_STATE_NULL) == GST_STATE_CHANGE_SUCCESS, "could not set to null");
+
+  /* check the result */
+  fail_unless (g_list_length (buffers) == 1);
+  new = GST_BUFFER (buffers->data);
+  buffers = g_list_remove (buffers, new);
+  fail_unless (GST_BUFFER_SIZE (buffer_out) == GST_BUFFER_SIZE (new),
+      "size of the buffers are not the same");
+  gst_check_caps_equal (GST_BUFFER_CAPS (buffer_out), GST_BUFFER_CAPS (new));
+  gst_buffer_unref (new);
+  gst_buffer_unref (buffer_out);
+
+  /* teardown the element and pads */
+  gst_pad_set_active (src_pad, FALSE);
+  gst_check_teardown_src_pad (element);
+  gst_pad_set_active (sink_pad, FALSE);
+  gst_check_teardown_sink_pad (element);
+  gst_check_teardown_element (element);
+}
+
+GST_START_TEST (test_no_cropping)
+{
+  check_aspectratiocrop
+      ("video/x-raw-yuv, format=(fourcc)YUY2, width=(int)320, height=(int)240, framerate=(fraction)30/1",
+      "video/x-raw-yuv, format=(fourcc)YUY2, width=(int)320, height=(int)240, framerate=(fraction)30/1",
+      153600, 153600, 4, 3);
+  check_aspectratiocrop
+      ("video/x-raw-yuv, format=(fourcc)YUY2, width=(int)320, height=(int)320, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)4/3",
+      "video/x-raw-yuv, format=(fourcc)YUY2, width=(int)320, height=(int)320, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)4/3",
+      204800, 204800, 4, 3);
+}
+
+GST_END_TEST;
+
+GST_START_TEST (test_autocropping)
+{
+  check_aspectratiocrop
+      ("video/x-raw-yuv, format=(fourcc)YUY2, width=(int)320, height=(int)240, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)4/3",
+      "video/x-raw-yuv, format=(fourcc)YUY2, width=(int)240, height=(int)240, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)4/3",
+      153600, 115200, 4, 3);
+
+  check_aspectratiocrop
+      ("video/x-raw-yuv, format=(fourcc)YUY2, width=(int)320, height=(int)240, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)16/9",
+      "video/x-raw-yuv, format=(fourcc)YUY2, width=(int)180, height=(int)240, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)16/9",
+      153600, 86400, 4, 3);
+
+  check_aspectratiocrop
+      ("video/x-raw-yuv, format=(fourcc)YUY2, width=(int)320, height=(int)240, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)16/15",
+      "video/x-raw-yuv, format=(fourcc)YUY2, width=(int)320, height=(int)192, framerate=(fraction)30/1, pixel-aspect-ratio=(fraction)16/15",
+      153600, 122880, 16, 9);
+
+}
+
+GST_END_TEST;
+
+static Suite *
+aspectratiocrop_suite (void)
+{
+  Suite *s = suite_create ("aspectratiocrop");
+  TCase *tc_chain = tcase_create ("general");
+
+  suite_add_tcase (s, tc_chain);
+  tcase_add_test (tc_chain, test_no_cropping);
+  tcase_add_test (tc_chain, test_autocropping);
+
+  return s;
+}
+
+int
+main (int argc, char **argv)
+{
+  int nf;
+
+  Suite *s = aspectratiocrop_suite ();
+  SRunner *sr = srunner_create (s);
+
+  gst_check_init (&argc, &argv);
+
+  srunner_run_all (sr, CK_NORMAL);
+  nf = srunner_ntests_failed (sr);
+  srunner_free (sr);
+
+  return nf;
+}