| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=54455
|
| |
|
|
|
|
|
|
|
|
| |
I am slowly moving all my projects to kernel-inspired 8ch indenting.
This will break patches that haven't been merged yet, which I am aware
of, but OTOH in times of git's --ignore-space-change shouldn't be too
problematic.
Yes, I am aware that reindenting like this sucks, but I cannot stand 4ch
indenting anymore. Sorry.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
hi,
while playing around with cppcheck, the tool noticed that there is a file descriptor leak:
[libcanberra-0.22/src/gstreamer.c:285]: (error) Resource leak: fd
Attached patch fixes the leak in two places.
Regards, Eric
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
I wrote the attached patch to fix some bugs in the GStreamer backend of
libcanberra.
When you run gnome-sound-properties, and then enable "Play alerts and
sound effects" on the "Sounds" tab, then click on one of the little
arrow buttons to preview the sound, it plays okay. However, the second
time you try clicking on any little arrow preview buttons it crashes.
It does this even if you wait for the first sound to stop playing before
playing the second sound.
Signed-off-by: Lennart Poettering <lennart@poettering.net>
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lennart:
>> --- libcanberra-0.8/src/gstreamer.c-orig 2008-08-30 00:54:34.477944000 -0500
>> +++ libcanberra-0.8/src/gstreamer.c 2008-08-30 01:03:11.619656000 -0500
>> @@ -230,7 +230,7 @@ static GstBusSyncReply bus_cb(GstBus *bu
>> /* g_debug (gst_element_state_get_name (pending)); */
>>
>> if (pending == GST_STATE_NULL || pending == GST_STATE_VOID_PENDING)
>> - err = CA_SUCCESS;
>> + return TRUE;
>> else
>> return GST_BUS_DROP;
>> break;
>
> Uh? bus_cb returns a variable of type GstBusSyncReply. Returning TRUE
> here really doesn't make sense to me.
Oops, sorry about that.
I find changing the line to either GST_BUS_PASS or GST_BUS_ASYNC seems
to work just fine. Providing an updated patch which uses GST_BUS_PASS.
Brian
Signed-off-by: Lennart Poettering <lennart@poettering.net>
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Brian, I will release libcanberra 0.8 shortly. If you want to make
> sure that the Gst driver works fine on solaris before I do the
> release, please test quickly!
Sorry I was not able ot test before the release. I just tested, and
I found it doesn't work for two reasons. One reason I fixed in the
attached patch. On Solaris, it is necessary to include "audioconvert !
audioconfig" in the GStreamer pipeline. This is needed to ensure that
GStreaner "just works" with sink plugins that may not implement the
full range of possible output that can come out of decodebin.
The attached patch fixes this. Totem, rhythmbox, and other GStreamer
based programs use similar logic.
Before the above fix, GStreamer would just hang, which would also
happen with the gst-launch command if you ran it with a similar
pipeline without "audioconvert".
Brian
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Signed-off-by: Lennart Poettering <lennart@poettering.net>
|
| | |
|
|
|
Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Signed-off-by: Lennart Poettering <lennart@poettering.net>
|
