diff options
| author | Colin Guthrie <cguthrie@mandriva.org> | 2011-03-25 09:12:51 +0000 |
|---|---|---|
| committer | Colin Guthrie <cguthrie@mandriva.org> | 2011-03-25 21:35:40 +0000 |
| commit | 34ddc5b9c533ed83d53238fff0777663f9c50336 (patch) | |
| tree | 0f274a06d544cc68daa9154b06e26a9a8d5b5370 /src/pulsecore/remap_sse.c | |
| parent | f49711c99a86075de0a2337c4ea71049a9aa146a (diff) | |
daemon: Fix some more error paths in the double forking.
As spotted by Tanu Kaskinen:
The first process: daemon_pipe is not closed if the first fork() call
fails. Even if it doesn't fail, the first process never closes
daemon_pipe[0].
The second process: daemon_pipe[1] is not closed if anything fails
between the first and the second fork() call. Also, if the second fork
fails, then the finish section writes to daemon_pipe2[1], even though
only the third process should do that. Also, if anything fails between
the first and the second fork, then the second process never writes
anything to daemon_pipe[1]. I don't know what happens in the first
process in this case - does it get an error or does pa_loop_read() get
stuck.
The third process: No problems :)
Diffstat (limited to 'src/pulsecore/remap_sse.c')
0 files changed, 0 insertions, 0 deletions