summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Smith <msmith@xiph.org>2006-01-13 18:35:00 +0000
committerThomas Vander Stichele <thomas@apestaart.org>2006-01-13 18:35:00 +0000
commit78e58c24314e28558cb11e263bd14ebffa86a187 (patch)
tree14f3a5c54a79806e805090b6ca3a9db6a7a0e77f
parent013f1dcab24948eec5625712ae6616e694f15a5b (diff)
gst/level/gstlevel.c: Fix memleak. Fixes #326612
Original commit message from CVS: 2006-01-13 Thomas Vander Stichele <thomas at apestaart dot org> patch by: Mike Smith * gst/level/gstlevel.c: (gst_level_message_new), (gst_level_message_append_channel): Fix memleak. Fixes #326612
-rw-r--r--ChangeLog8
-rw-r--r--gst/level/gstlevel.c4
2 files changed, 12 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index f27b5cc7..e7eb8dbe 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2006-01-13 Thomas Vander Stichele <thomas at apestaart dot org>
+
+ patch by: Mike Smith
+
+ * gst/level/gstlevel.c: (gst_level_message_new),
+ (gst_level_message_append_channel):
+ Fix memleak. Fixes #326612
+
2006-01-11 Thomas Vander Stichele <thomas at apestaart dot org>
* configure.ac:
diff --git a/gst/level/gstlevel.c b/gst/level/gstlevel.c
index 26afb08d..ab641183 100644
--- a/gst/level/gstlevel.c
+++ b/gst/level/gstlevel.c
@@ -390,6 +390,8 @@ gst_level_message_new (GstLevel * l, GstClockTime endtime)
gst_structure_set_value (s, "peak", &v);
gst_structure_set_value (s, "decay", &v);
+ g_value_unset (&v);
+
return gst_message_new_element (GST_OBJECT (l), s);
}
@@ -416,6 +418,8 @@ gst_level_message_append_channel (GstMessage * m, gdouble rms, gdouble peak,
l = (GValue *) gst_structure_get_value (s, "decay");
g_value_set_double (&v, decay);
gst_value_list_append_value (l, &v); /* copies by value */
+
+ g_value_unset (&v);
}
static GstFlowReturn