summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSjoerd Simons <sjoerd@luon.net>2008-05-05 11:19:13 +0000
committerWim Taymans <wim.taymans@gmail.com>2008-05-05 11:19:13 +0000
commit89b114fe44016c9bf96662fdebfc048f8540ee1d (patch)
treeb3b123001e88c96e66fe627fea33d09945693e80
parent24e21ae6e9d0cc81b5fb93668848437e6a851df9 (diff)
gst/rtsp/gstrtspsrc.c: Don't leak file descriptors on error. Fixes #531532.
Original commit message from CVS: Patch by: Sjoerd Simons <sjoerd at luon dot net> * gst/rtsp/gstrtspsrc.c: (gst_rtspsrc_init), (gst_rtspsrc_open): Don't leak file descriptors on error. Fixes #531532.
-rw-r--r--ChangeLog7
-rw-r--r--gst/rtsp/gstrtspsrc.c4
2 files changed, 11 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 0c1ef471..3b5e292c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-05-05 Wim Taymans <wim.taymans@collabora.co.uk>
+
+ Patch by: Sjoerd Simons <sjoerd at luon dot net>
+
+ * gst/rtsp/gstrtspsrc.c: (gst_rtspsrc_init), (gst_rtspsrc_open):
+ Don't leak file descriptors on error. Fixes #531532.
+
2008-05-03 Sebastian Dröge <slomo@circular-chaos.org>
* ext/gconf/gstgconfaudiosrc.c: (gst_gconf_audio_src_reset),
diff --git a/gst/rtsp/gstrtspsrc.c b/gst/rtsp/gstrtspsrc.c
index 069b6d37..6c53138d 100644
--- a/gst/rtsp/gstrtspsrc.c
+++ b/gst/rtsp/gstrtspsrc.c
@@ -4064,6 +4064,10 @@ setup_failed:
}
cleanup_error:
{
+ if (src->connection) {
+ gst_rtsp_connection_free (src->connection);
+ src->connection = NULL;
+ }
GST_RTSP_STATE_UNLOCK (src);
gst_rtsp_message_unset (&request);
gst_rtsp_message_unset (&response);