diff options
author | Sebastian Dröge <slomo@circular-chaos.org> | 2008-02-11 13:48:03 +0000 |
---|---|---|
committer | Sebastian Dröge <slomo@circular-chaos.org> | 2008-02-11 13:48:03 +0000 |
commit | b603027de797e7e2b5afaf01afd369db2178ce7f (patch) | |
tree | 286d910de02b687fc2f1d3ca0aa8a39a17408ec1 | |
parent | f13c8b6576edd83e99fbec2c7effb75df1d545e4 (diff) |
ext/gconf/gconf.c: Use and unset the GError when pipeline creation fails instead of simply leaking it. Fixes bug #515...
Original commit message from CVS:
* ext/gconf/gconf.c: (gst_gconf_render_bin_with_default):
Use and unset the GError when pipeline creation fails instead of
simply leaking it. Fixes bug #515704.
-rw-r--r-- | ChangeLog | 6 | ||||
-rw-r--r-- | ext/gconf/gconf.c | 8 |
2 files changed, 14 insertions, 0 deletions
@@ -1,3 +1,9 @@ +2008-02-11 Sebastian Dröge <slomo@circular-chaos.org> + + * ext/gconf/gconf.c: (gst_gconf_render_bin_with_default): + Use and unset the GError when pipeline creation fails instead of + simply leaking it. Fixes bug #515704. + 2008-02-10 Sebastian Dröge <slomo@circular-chaos.org> * gst/audiofx/audioamplify.c: diff --git a/ext/gconf/gconf.c b/ext/gconf/gconf.c index 2bda0669..e7214e2d 100644 --- a/ext/gconf/gconf.c +++ b/ext/gconf/gconf.c @@ -180,6 +180,14 @@ gst_gconf_render_bin_with_default (const gchar * bin, ret = gst_parse_bin_from_description (bin, TRUE, &err); if (ret == NULL || err != NULL) { + if (err) { + GST_DEBUG ("Could not create audio sink from GConf settings: %s", + err->message); + g_error_free (err); + } else { + GST_DEBUG ("Could not create audio sink from GConf settings"); + } + ret = gst_element_factory_make (default_sink, NULL); if (!ret) |