Don't use gst_element_get_pad(), it's a bad method.

Original commit message from CVS:
* ext/gconf/gstgconfaudiosrc.c: (gst_gconf_audio_src_reset),
(do_toggle_element):
* ext/gconf/gstgconfvideosink.c: (gst_gconf_video_sink_reset),
(do_toggle_element):
* ext/gconf/gstgconfvideosrc.c: (gst_gconf_video_src_reset),
(do_toggle_element):
* ext/gconf/gstswitchsink.c: (gst_switch_commit_new_kid):
* ext/hal/gsthalaudiosink.c: (gst_hal_audio_sink_reset),
(do_toggle_element):
* ext/hal/gsthalaudiosrc.c: (gst_hal_audio_src_reset),
(do_toggle_element):
* gst/autodetect/gstautoaudiosink.c: (gst_auto_audio_sink_reset),
(gst_auto_audio_sink_detect):
* gst/autodetect/gstautovideosink.c: (gst_auto_video_sink_reset),
(gst_auto_video_sink_detect):
* gst/rtsp/gstrtspsrc.c: (gst_rtspsrc_init),
(gst_rtspsrc_stream_free), (gst_rtspsrc_stream_configure_udp),
(gst_rtspsrc_stream_configure_udp_sink), (gst_rtspsrc_skip_lws),
(gst_rtspsrc_unskip_lws), (gst_rtspsrc_skip_commas),
(gst_rtspsrc_skip_item), (gst_rtsp_decode_quoted_string),
(gst_rtspsrc_parse_digest_challenge), (gst_rtspsrc_parse_auth_hdr):
* tests/icles/videocrop-test.c: (test_with_caps),
(video_crop_get_test_caps):
Don't use gst_element_get_pad(), it's a bad method.

4 files changed, 7 insertions, 7 deletions

diff --git a/ext/gconf/gstgconfaudiosrc.c b/ext/gconf/gstgconfaudiosrc.c
index 589cf6af..babd653d 100644
--- a/ext/gconf/gstgconfaudiosrc.c
+++ b/ext/gconf/gstgconfaudiosrc.c
@@ -88,7 +88,7 @@ gst_gconf_audio_src_reset (GstGConfAudioSrc * src)
   }
   gst_bin_add (GST_BIN (src), src->kid);
 
-  targetpad = gst_element_get_pad (src->kid, "src");
+  targetpad = gst_element_get_static_pad (src->kid, "src");
   gst_ghost_pad_set_target (GST_GHOST_PAD (src->pad), targetpad);
   gst_object_unref (targetpad);
 
@@ -194,7 +194,7 @@ do_toggle_element (GstGConfAudioSrc * src)
 
   /* re-attach ghostpad */
   GST_DEBUG_OBJECT (src, "Creating new ghostpad");
-  targetpad = gst_element_get_pad (src->kid, "src");
+  targetpad = gst_element_get_static_pad (src->kid, "src");
   gst_ghost_pad_set_target (GST_GHOST_PAD (src->pad), targetpad);
   gst_object_unref (targetpad);
   GST_DEBUG_OBJECT (src, "done changing gconf audio source");
diff --git a/ext/gconf/gstgconfvideosink.c b/ext/gconf/gstgconfvideosink.c
index 1e7c16e6..ec04cd86 100644
--- a/ext/gconf/gstgconfvideosink.c
+++ b/ext/gconf/gstgconfvideosink.c
@@ -87,7 +87,7 @@ gst_gconf_video_sink_reset (GstGConfVideoSink * sink)
   }
   gst_bin_add (GST_BIN (sink), sink->kid);
 
-  targetpad = gst_element_get_pad (sink->kid, "sink");
+  targetpad = gst_element_get_static_pad (sink->kid, "sink");
   gst_ghost_pad_set_target (GST_GHOST_PAD (sink->pad), targetpad);
   gst_object_unref (targetpad);
 
@@ -193,7 +193,7 @@ do_toggle_element (GstGConfVideoSink * sink)
 
   /* re-attach ghostpad */
   GST_DEBUG_OBJECT (sink, "Creating new ghostpad");
-  targetpad = gst_element_get_pad (sink->kid, "sink");
+  targetpad = gst_element_get_static_pad (sink->kid, "sink");
   gst_ghost_pad_set_target (GST_GHOST_PAD (sink->pad), targetpad);
   gst_object_unref (targetpad);
   GST_DEBUG_OBJECT (sink, "done changing gconf video sink");
diff --git a/ext/gconf/gstgconfvideosrc.c b/ext/gconf/gstgconfvideosrc.c
index 5d5fcb11..f56f43a2 100644
--- a/ext/gconf/gstgconfvideosrc.c
+++ b/ext/gconf/gstgconfvideosrc.c
@@ -88,7 +88,7 @@ gst_gconf_video_src_reset (GstGConfVideoSrc * src)
   }
   gst_bin_add (GST_BIN (src), src->kid);
 
-  targetpad = gst_element_get_pad (src->kid, "src");
+  targetpad = gst_element_get_static_pad (src->kid, "src");
   gst_ghost_pad_set_target (GST_GHOST_PAD (src->pad), targetpad);
   gst_object_unref (targetpad);
 
@@ -187,7 +187,7 @@ do_toggle_element (GstGConfVideoSrc * src)
 
   /* re-attach ghostpad */
   GST_DEBUG_OBJECT (src, "Creating new ghostpad");
-  targetpad = gst_element_get_pad (src->kid, "src");
+  targetpad = gst_element_get_static_pad (src->kid, "src");
   gst_ghost_pad_set_target (GST_GHOST_PAD (src->pad), targetpad);
   gst_object_unref (targetpad);
   GST_DEBUG_OBJECT (src, "done changing gconf video source");
diff --git a/ext/gconf/gstswitchsink.c b/ext/gconf/gstswitchsink.c
index 6c9fff17..815bfada 100644
--- a/ext/gconf/gstswitchsink.c
+++ b/ext/gconf/gstswitchsink.c
@@ -205,7 +205,7 @@ gst_switch_commit_new_kid (GstSwitchSink * sink)
 
   /* re-attach ghostpad */
   GST_DEBUG_OBJECT (sink, "Creating new ghostpad");
-  targetpad = gst_element_get_pad (sink->kid, "sink");
+  targetpad = gst_element_get_static_pad (sink->kid, "sink");
   gst_ghost_pad_set_target (GST_GHOST_PAD (sink->pad), targetpad);
   gst_object_unref (targetpad);
   GST_DEBUG_OBJECT (sink, "done changing child of switchsink");